Code correction in replacing dash sign while concatnet

Try this...

Private Sub Worksheet_Change(ByVal Target As Range)

If Target.Row < 7 Then Exit Sub
Dim rng As Range, r As Range, vTemp As Variant

Application.EnableEvents = False

If Target.Row > 1 And Not Range(Cells(Target.Row, "c"), Cells(Target.Row, "f")) Is Nothing Then
    Set rng = Range(Cells(Target.Row, "c"), Cells(Target.Row, "f"))
    For Each r In rng
        vTemp = vTemp & r.Value & " "
    Next r
    vTemp = Replace(Trim(vTemp), "-", " ")
    With rng
        Cells(Target.Row, 7).Value = vTemp
    End With
End If

Application.EnableEvents = True

End Sub

Hi, Mukesh,

if you check the row to be greater or equal to 7 in order to proceed with the code there is no need to check again later if it will be greater 1 - this must be fulfilled. Maybe try

Private Sub Worksheet_Change(ByVal Target As Range)

If Target.Row < 7 Then Exit Sub
Dim r As Range, vTemp As Variant

Application.EnableEvents = False

For Each r In Range(Cells(Target.Row, "c"), Cells(Target.Row, "f"))
    vTemp = vTemp & r.Value & " "
Next r
vTemp = Replace(Trim(vTemp), "-", " ")
Cells(Target.Row, 7).Value = vTemp

Application.EnableEvents = True

End Sub

This should work fine if you are only handling one row at a time.

Ciao,
Holger

Hi, Mukesh,

like this:

Private Sub Worksheet_Change(ByVal Target As Range)

If Target.Row < 7 Then Exit Sub
Dim vTemp As Variant
Dim var As Variant
Dim lngArr As Long

var = Array("C", "E", "D")

Application.EnableEvents = False

For lngArr = LBound(var) To UBound(var)
  vTemp = vTemp & Cells(Target.Row, var(lngArr)).Value & " "
Next lngArr
vTemp = Replace(Trim(vTemp), "-", " ")
Cells(Target.Row, 7).Value = vTemp

Application.EnableEvents = True

End Sub

Ciao,
Holger