+ Reply to Thread
Results 1 to 6 of 6

Code Review for newbie

  1. #1
    Registered User
    Join Date
    10-14-2010
    Location
    BC Canada
    MS-Off Ver
    Excel 365
    Posts
    78

    Code Review for newbie

    This code works, but I was wondering if someone would review it

    Thanks

    Please Login or Register  to view this content.

  2. #2
    Valued Forum Contributor
    Join Date
    01-19-2010
    Location
    Melbourne Australia
    MS-Off Ver
    latest is Excel 2016. have older versions
    Posts
    624

    Re: Code Review for newbie

    Hi thisandthat,

    Just wondering if it works why you would want to review it and wondering what in particular is causing you to doubt the code / want it changed?

    a little more direction and possibly a sample worksheet would assist us

    Cheers

    Jmac1947

    1. Please consider clicking on the * Add Reputation if you think this post has helped you
    2. Mark your thread as SOLVED when question is resolved

  3. #3
    Forum Guru xladept's Avatar
    Join Date
    04-14-2012
    Location
    Pasadena, California
    MS-Off Ver
    Excel 2003,2010
    Posts
    12,378

    Re: Code Review for newbie

    Hi t and t,

    This is what I would do - but see if it still works:

    Please Login or Register  to view this content.
    Last edited by xladept; 01-27-2014 at 07:27 PM. Reason: Details
    If I've helped you, please consider adding to my reputation - just click on the liitle star at the left.

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~(Pride has no aftertaste.)

    You can't do one thing. XLAdept

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~aka Orrin

  4. #4
    Registered User
    Join Date
    10-14-2010
    Location
    BC Canada
    MS-Off Ver
    Excel 365
    Posts
    78

    Re: Code Review for newbie

    Thanks,

    Reason I wanted feedback is that I know for particular coding languages there are good rules to follow, and bad habits you can get into, that's why I asked.

  5. #5
    Forum Guru xladept's Avatar
    Join Date
    04-14-2012
    Location
    Pasadena, California
    MS-Off Ver
    Excel 2003,2010
    Posts
    12,378

    Re: Code Review for newbie

    You're welcome! And, thanks for the rep!

  6. #6
    Forum Contributor
    Join Date
    05-29-2013
    Location
    MD
    MS-Off Ver
    Excel 365
    Posts
    148

    Re: Code Review for newbie

    I think it's worth mentioning that this line:

    Please Login or Register  to view this content.
    is declaring 'resultssht' as a string, but everything else as a Variant. There's no quick way of declaring multiple variables of the same type.

+ Reply to Thread

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. simple date comparison - code review
    By VBA FTW in forum Excel Programming / VBA / Macros
    Replies: 6
    Last Post: 12-11-2013, 06:33 PM
  2. Code review please!
    By NikonMan in forum Excel Programming / VBA / Macros
    Replies: 3
    Last Post: 02-27-2013, 02:16 AM
  3. Review my code and help me write it better
    By tradesjackofall in forum Excel Programming / VBA / Macros
    Replies: 5
    Last Post: 08-26-2008, 01:04 PM
  4. Code Review
    By Eric in forum Excel Programming / VBA / Macros
    Replies: 3
    Last Post: 02-17-2006, 03:00 PM
  5. [SOLVED] Change the interior color of a cell - Code Review
    By Tiny Tim in forum Excel Programming / VBA / Macros
    Replies: 6
    Last Post: 12-17-2005, 05:55 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Search Engine Friendly URLs by vBSEO 3.6.0 RC 1