Best way to handle if error with call function

Hi guys,

Please see this code:

Sub GenerateOutbound()

    Call Merge_CSV_DHL_OUT
    Call Merge_XLS_FEDEX_OUT
    Call Merge_XLS_KN_OUT
    Call Merge_XLS_PANALPINA_OUT
    Call Merge_XLS_Speedlink_OUT
    Call Merge_CSV_TNT_Express_OUT
    Call Merge_CSV_TNT_France_OUT
    Call Merge_CSV_UPS_OUT
    Call JoinFiles
        
End Sub

So this is verry simple code which runs several macros after eachother.
Now it could be that one of these runs into error (ligit) because there is no data in the folder they are for.
Then of course the macro will crash.
But what I want is that it then just continious to the next macro.

What would be the best and cleanest way to adjust this code to do so?
Thanks!

Sub GenerateOutbound()
    Call Merge_CSV_DHL_OUT
    Call Merge_XLS_FEDEX_OUT
    Call Merge_XLS_KN_OUT
    Call Merge_XLS_PANALPINA_OUT
    Call Merge_XLS_Speedlink_OUT
    Call Merge_CSV_TNT_Express_OUT
    Call Merge_CSV_TNT_France_OUT
    Call Merge_CSV_UPS_OUT
    Call JoinFiles
End Sub
sub Merge_CSV_DHL_OUT()
on error goto end_sub_due_to_error
'code
end_sub_due_to_error:
on error goto 0
end sub

and so on

Originally Posted by Norie

Can't you handle the errors in the code of the subs being called?

For example, check that there are files in a folder before continuing.

Yes could also be option but how then to tell the macro that the next sub-macro in line should be run?

Hmm dunno if I understand this right yudlugar.
So it cannot be done in the macro which calls the sub-macros but has to be done in the sub-macros themself?
Ok if so but I do not grasp which code then makes sure that when "sub Merge_CSV_DHL_OUT()" runs into error it automatically goes to number 2 in the list "Call Merge_XLS_FEDEX_OUT".

Because I think now you want me to put everything in 1 macro?

Sub macro_1()
On Error GoTo next_sub
Call macro_2
next_sub:
On Error GoTo next_sub_1
Call macro_3
next_sub_1:
On Error GoTo next_sub_2
Call macro_4
next_sub_2:
End Sub

you could do it like that I guess.

Hmm thanks Yudlugar.
That looks likes it worth a shot, I am going to try that.

Originally Posted by Norie

rpinxt

You don't need to, after you've dealt with the error you exit the sub.

Then code execution will return to the calling sub, GenerateOutbound, and the next sub will be called.

That would also be good.
Thanks guys! These solutions will help me one way or the other

@rpinxt - that was essentially what I was looking at doing first, just with a generalised error handling in each individual sub (if there is an error to just skip to the end).

Originally Posted by yudlugar

@rpinxt - that was essentially what I was looking at doing first, just with a generalised error handling in each individual sub (if there is an error to just skip to the end).

Ah ok sorry I did not understand right away.
But must say your second solution also looks nice.
And I would not have to adept all the underlying macros with error handling code if I can do it on the master macro.