Trying to understand IF Else Statements

[Justair07]

Hello,

Can someone take a look at some basic code I wrote and help me figure out what i'm doing wrong.

I would like for a person to enter 2 colors (red, blue or yellow) to make a new color.

If they choose any other color they get an error.

Sub colorMix()

Dim color1 As String
Dim color2 As String

color1 = InputBox("Enter the first color")
color2 = InputBox("Enter the second color")

If Not color1 = "Red" Then
    MsgBox ("You can only enter Red, Blue, or Yellow")
End If

If Not color1 = "Blue" Then
    MsgBox ("You can only enter Red, Blue, or Yellow")
End If

If Not color1 = "Yellow" Then
    MsgBox ("You can only enter Red, Blue, or Yellow")
End If

If Not color2 = "Red" Then
    MsgBox ("You can only enter Red, Blue, or Yellow")
End If

If Not color2 = "Blue" Then
    MsgBox ("You can only enter Red, Blue, or Yellow")
End If

If Not color2 = "Yellow" Then
    MsgBox ("You can only enter Red, Blue, or Yellow")
End If

If Color = "Red" And color2 = "Blue" Then
    MsgBox ("The new color is Purple")

Else

If color1 = "Red" And color2 = "Yellow" Then
   MsgBox ("The new color is orange")

Else

If color1 = "Blue" And color2 = "Yellow" Then
   MsgBox ("The new color is Green")

End If
End If
End If
End Sub

Thank you very much

[majosum]

This should work. However, did you want a result if they select the same color in both input boxes?

Dim color1 As String
Dim color2 As String
Dim color1flag As Boolean
Dim color2flag As Boolean
Dim differentColor As Boolean

differentColor = false
color1flag = false
color2flag = false

Do Until differentColor = True

Do Until color1flag = True
color1 = InputBox("Enter the first color")
If color1 = "Red" Or color1 = "Blue" Or color1 = "Yellow" Then
    color1flag = True
Else
    MsgBox ("You can only enter Red, Blue, or Yellow")
End If
Loop

Do Until color2flag = True
color2 = InputBox("Enter the second color")
If color2 = "Red" Or color2 = "Blue" Or color2 = "Yellow" Then
    color2flag = True
Else
    MsgBox ("You can only enter Red, Blue, or Yellow")
End If
Loop

If color1 = color2 Then
differentColor = True
Else
MsgBox ("You selected the same color.  Please enter the colors again.")
End If

Loop
If Color1 = "Red" And color2 = "Blue" Then
    MsgBox ("The new color is Purple")
Else
If color1 = "Red" And color2 = "Yellow" Then
   MsgBox ("The new color is orange")
Else
If color1 = "Blue" And color2 = "Yellow" Then
   MsgBox ("The new color is Green")
End If
End If
End If

[Justair07]

Good question, same color should probably be a separate error message.

[majosum]

I edited my code in my original post. Try that now.

[GC Excel]

Hi Justair07,
Here's a code to try :

Option Explicit
Option Compare Text

Sub ColorMix()

   Dim color1 As String
   Dim color2 As String
   Dim arColor1 As String
   Dim arColor2 As String
   Dim ColorMix As String

   arColor1 = "(Red, Blue, Yellow)"      'acceptable color1
   arColor2 = "(Red, Blue, Yellow)"      'acceptable color2

   color1 = InputBox("Enter the first color" & vbLf & arColor1, "Color 1")
   color2 = InputBox("Enter the second color" & vbLf & arColor2, "Color 2")

   Do Until InStr(1, arColor1, color1) > 0
      color1 = InputBox("You can only enter Red, Blue, or Yellow", "Color 1")
   Loop

   Do Until InStr(1, arColor2, color2) > 0
      color2 = InputBox("You can only enter Red, Blue, or Yellow", "Color 2")
   Loop

   Select Case color1
   Case "Red"
      Select Case color2
      Case "Red": ColorMix = "Red"
      Case "Blue": ColorMix = "Purple"
      Case "Yellow": ColorMix = "Orange"
      End Select
   Case "Blue"
      Select Case color2
      Case "Red": ColorMix = "Purple"
      Case "Blue": ColorMix = "Blue"
      Case "Yellow": ColorMix = "Green"
      End Select
   Case "Yellow"
      Select Case color2
      Case "Red": ColorMix = "Orange"
      Case "Blue": ColorMix = "Green"
      Case "Yellow": ColorMix = "Yellow"
      End Select
   End Select
   
   MsgBox ColorMix

End Sub

[GC Excel]

Just saw the condition to have 2 different colors...
code slightly modified :

Option Explicit
Option Compare Text

Sub ColorMix()

   Dim color1 As String
   Dim color2 As String
   Dim arColor1 As String
   Dim arColor2 As String
   Dim ColorMix As String

   arColor1 = "(Red, Blue, Yellow)"      'acceptable color1
   arColor2 = "(Red, Blue, Yellow)"      'acceptable color2

   color1 = InputBox("Enter the first color" & vbLf & arColor1, "Color 1")
   color2 = InputBox("Enter the second color" & vbLf & "Different from Color 1" & vbLf & arColor2, "Color 2")

   Do Until InStr(1, arColor1, color1) > 0
      color1 = InputBox("You can only enter Red, Blue, or Yellow", "Color 1")
   Loop

   Do Until InStr(1, arColor2, color2) > 0 And color1 <> color2
      color2 = InputBox("You can only enter Red, Blue, or Yellow" & vbLf & "Different from color1", "Color 2")
   Loop

   Select Case color1
   Case "Red"
      Select Case color2
      Case "Red": ColorMix = "Red"
      Case "Blue": ColorMix = "Purple"
      Case "Yellow": ColorMix = "Orange"
      End Select
   Case "Blue"
      Select Case color2
      Case "Red": ColorMix = "Purple"
      Case "Blue": ColorMix = "Blue"
      Case "Yellow": ColorMix = "Green"
      End Select
   Case "Yellow"
      Select Case color2
      Case "Red": ColorMix = "Orange"
      Case "Blue": ColorMix = "Green"
      Case "Yellow": ColorMix = "Yellow"
      End Select
   End Select
   
   MsgBox ColorMix

End Sub

[Justair07]

Thank you guys very much for the help! majosum, I got an error when I entered Red for the first color and blue for the 2nd. It said I entered the same color? GC Excel thank you very much for your help, your code worked great, I was hoping to add an error message instead of a repeated question. I'm going to play around with what you gave me so far. Thank you!