password lost when reopening workbook

[vlady]

Basically i have password to protect selected sheets.
Then ask for password to protect entire sheet.
The problem is that the inputted password is lost when closed and reopen the workbook.
And i can't find the bug in this one. I think another eye would be very helpful. Thanks.

Option Explicit
Public pWord1 As String
Public pWord2 As String

Private Sub CommandButton3_Click()
Const PW As String = "scorpion" 
ActiveSheet.Unprotect PW
pWord1 = InputBox("PLEASE TYPE PASSWORD TO PROTECT. SALAMAT")
ActiveSheet.Cells.Locked = True
Columns("AA").Hidden = True
Columns("AE").Hidden = True
ActiveSheet.Protect Password:=pWord1
CommandButton3.Enabled = False
CommandButton4.Enabled = True
End Sub

Private Sub CommandButton4_Click()
Const PW As String = "scorpion" 'hehehe secret ko ito
pWord2 = InputBox("PLEASE TYPE PASSWORD TO UN_PROTECT. ")
If pWord2 = pWord1 Then
ActiveSheet.Unprotect pWord1
ActiveSheet.Cells.Locked = False
Columns("AA").Hidden = False
Columns("AE").Hidden = False
ActiveSheet.Protect PW
CommandButton4.Enabled = False
CommandButton3.Enabled = True
Else
MsgBox "YOU HAVE TYPE A WRONG PASSWORD", vbInformation
End If
End Sub

[shyamhappy]

Please try this code


Moderator's Note: Sorry i have to delete that code, against forum rules.

[HaHoBe]

Hi, vlady,

you would need to store the password (in the CustomProperties of the workbook, a name, a range in a hidden sheet, a text file, the registry) in order to rely on these. You may even put that password into the code but I prefer not to do so but keep it away. Also check the length of the password and assign a value to it if it is still 0.

In your second code you protect with a given password. Please make sure to assign that password to your variables as well.

Ciao,
Holger

[vlady]

sorry it's against rule to post bypassing passwords. and my issue is the code aboce on what am i missing.just cann't find it.

the issue is pWord1 losses it's containment( the password typed) when save/closed then reopen the workbook but still it is password protected.

[vlady]

yup but the problem is there would be a change of password now and then for pword1.


...You mean paste the value of pword1 in a cell when protecting then turn that cell blank after unprotect.. i think i got the idea if that's what you mean.

[HaHoBe]

Hi, vlady,

thatīs why I mostly use a UserForm with 2 TextBoxes (which show * as password character instead of the clear characters typed in) and 2 CommandButtons (Cancel and OK). The logic of doing all is behind OK: check the passwords against each other to be identical, compare them to the values at the given place, adjust password if needed, make sure to save the changes to the workbook. And maybe even use encryption for storing and reading the password (up to you and the effort you would like to take for keeping it away from the eyes of the user).

Ciao,
Holger

[vlady]

Thanks. I've edited it now. i did not use userform since i think this will slow down since there will be too many sheet tabs and each sheet tabs will have two buttons for protecting and unprotecting. i used a cell that will be hidden also when the user protects if way down to last row.. thanks to the idea.

Solves the problem.

Regards,
Vladimir