Sorting VBA Simplification

Perhaps.

arrRanges("SgDV_TestGrp", "SgDV_Product", "SgDV_Machine", "SgDV_SampleType")

For I = LBound(arrRanges) To UBound(arrRanges)

   'Sort Unique Values: TestGrp
   Range(arrRanges(I)).Sort Key1:=Range(arrRanges(I)), Order1:=xlAscending, Header:= _
        xlGuess, OrderCustom:=1, MatchCase:=False, Orientation:=xlTopToBottom, _
        DataOption1:=xlSortNormal
Next I

Oops did't notice that.

arrRanges("TestGrp", "Product", "Machine", "SampleType")

For I = LBound(arrRanges) To UBound(arrRanges)

   'Sort Unique Values: TestGrp
   Range("SgDV_" & arrRanges(I)).Sort Key1:=Range("SgSort_" & arrRanges(I)), Order1:=xlAscending, Header:= _
        xlGuess, OrderCustom:=1, MatchCase:=False, Orientation:=xlTopToBottom, _
        DataOption1:=xlSortNormal
Next I

Why do you have StartMachine in the array?

Shouldn't it be Machine?

As far as I can see all the names are right, has anything else been changed?

Can you upload an example workbook?

Click on GO ADVANCED and use the paperclip icon to open the upload window.

Sorry but I'm at a loss here.

I tried a few variations, for example the below code, but still same error.

Dim arrRanges As Variant
Dim arrSort As Variant
Dim i As Long

    arrRanges = Array("SgDV_TestGrp", "SgDV_Product", "SgDV_Machine", "SgDV_SampleType")
    arrSort = Array("SgSort_TestGrp", "SgSort_Product", "SgSort_Machine", "SgSort_SampleType")

    For i = LBound(arrRanges) To UBound(arrRanges)
        
        Sheet3.Range(arrRanges(i)).Sort Key1:=Sheet3.Range(arrSort(i)), _
        Order1:=xlAscending, Header:=xlGuess, OrderCustom:=1, MatchCase:=False, _
        Orientation:=xlTopToBotom, DataOption1:=xlSortNormal
        
    Next i

The arrays have the same no of elements so you can use i for both of them.

When i is 0 arrRanges(0) will return "SgDV_TestGrp" and arrSort(0) will return "SgSort_TestGrp".

Figured out what the problem was. Look at posting #12 on the last line, the word "Bottom" is misspelled as "Botom". Once this was corrected everything worked.

Sorry, posted this without realizing that this was pointed out by tigeravatar in posting #16.

Thanks to everyone who contributed to this thread. I learned alot.

The problem is that the Orientation argument is mispelled:

Orientation:=xlTopToBotom

Should be xlTopToBottom

Alternatively, since it is an optional argument and that is its default value anyway, you could just delete that argument (and the other optional arguments that are set to their default values) to correct the issue also:

Sub UniqueValues_SG2()
    
    Dim arrRanges As Variant, i As Long
    
    arrRanges = Array("TestGrp", "Product", "Machine", "SampleType")
    For i = LBound(arrRanges) To UBound(arrRanges)
        Range("SgDV_" & arrRanges(i)).Sort Range("SgSort_" & arrRanges(i)), xlAscending, Header:=xlGuess
    Next i
    
End Sub

So that means the code I posted in #4 would work, if the error with the array was fixed.

Indeed it would!

Perhaps you could do it this way - you could play with the strings for the setups:

Sub SUV(SgDV As String, SgSort As String)
Range(SgDV).Sort Key1:=Range(SgSort), Order1:=xlAscending, Header:= _
xlGuess, OrderCustom:=1, MatchCase:=False, Orientation:=xlTopToBottom, _
DataOption1:=xlSortNormal:End Sub

Call SUV("SgDV_TestGrp","SgSort_TestGrp")
Call SUV("SgDV_Product","SgSort_Product")
Call SUV("SgDV_Machine","SgSort_Machine")
Call SUV("SgDV_SampleType","SgSort_SampleType")

If this is solved then please mark it solved, and spread some rep about.

If that takes care of your original question, please select Thread Tools from the menu link above and mark this thread as SOLVED. Thanks.