InputBox Function not as flexible as needed

I'm using a simple inputbox function to query a number of variables from the workbook user, to be used in a new object created from a class module.

I'd like to name the new object a unique concatenation of the variables being stored within it to archive in a library for tracking.

Currently, my functions (seven in all) are written as such:

Please Login or Register  to view this content.

I run into trouble because everytime I need to reference the returned variable in my primary macro I call a new InputBox (the function). I will also need to error check these user inputs in the function to ensure they're the appropriate datatype, thus it makes sense to return a different variable name from the function.

How can I write my functions to call the inputbox function (function within a function) in such a way that a different variable name is returned? Please bear in mind the function should allow for IF statements to qualify the user input before being returned to the sub.

I've included the workbook for reference. The primary macro is named "AddNMP", and the sub "InputBoxNewMarginPlacement" will ultimately be inserted / called into / by "AddNMP." The code is a bit messier than usual because I've been trying to test the concatenation, but those lines have been remarked - feel free to ignore.

What exactly are you trying to concatenate?

How are the input boxes being duplicated?

What is it you want to change about them?

I've tried to put it into context below.

Function candfirstname
Function calls InputBox function to query user for candidate's first name and stores in string candfirstname

Please Login or Register  to view this content.

Sub InputBoxNewMarginPlacement
Calls Class CTempCandidate to create object for storage of user input in an array of strings, singles and integers. The Functions are called for user input, then passed to a class to create a new object. Hit Ctrl+F and search for [ISSUE] to see the two specific areas that call the function and explain the duplicate InputBoxes. The solution I had in mind involved adding a RETURN to the Function and differentiating the Function name and the returned variable. Thoughts on how to change the Function to achieve this?

Please Login or Register  to view this content.

Class CTempPlacement (for reference)

Please Login or Register  to view this content.

Do you actually need the variables?

Can't you assign directly to the object from the functions?

What wll you be concatentating the name of the object to?

To me it sounds like you want to do that for some sort of dynamic variable name.

By the way, this is what I was meaning about not needing the variables.

Please Login or Register  to view this content.

This part of the code is taking the return values of the functions and assigning them to the new candidate.

Please Login or Register  to view this content.

I would recommend a more direct approach, there's no need to call a separate function for each variable, and it appears things are getting confusing by trying. Just collect the information directly in the main macro:

Please Login or Register  to view this content.

I would also recommend you don't use

Please Login or Register  to view this content.

just use

Please Login or Register  to view this content.

and then set to a New instance as you are doing. that may also help show you why you are getting a 438 error-you're trying to assign a string to an object

your class properties should validate the input data but using application.inputbox as Jerry demonstrated gives you the option to specify a type unlike the vba.inputbox function