SOLVED: Same code in two different sheets, yet 1004 error in one

please check the code in workbook LeasingTest 2.xls

i found this code, perhaps it which caused error

Please Login or Register  to view this content.

Hi Winon,

Thanks so much for your help. Unfortunately, that doesn't seem to have worked. It's stopped throwing an error when BNCheckButton is clicked, but the code isn't doing what it should:

-When BNCheckButton is clicked, it's not filling the form with pre-existing entries
-When UpdateExistingButton is clicked, it's not overwriting the text in that row with what has been filled in on the userform
-When OKNext is clicked, it saves the data to the spreadsheet, but still shows the 1004 error
-When OKClose is clicked, it saves the data to the spreadsheet, but still shows the 1004 error.

But thanks for getting rid of the error on BNCheckButton! What's the next step?

Thanks!

Hi dwint,

Thanks for picking that up. I fixed that up, but unfortunately, that didn't fix my problem.

Hi Winon,

No, there's nothing wrong in that regard. I have an OpenUserFormButton macro, but there's no button for it on the userform or the spreadsheet. It gets linked to a button on the Excel ribbon. But there's nothing wrong with that part, and in fact, that code is not related to the userform at all. It's completely separate and not affecting anything else.

As for the BNCheckButton, if you have a look at the Franchise spreadsheet, you will see how each of the buttons work. For instance, open the Franchise spreadsheet, and in the Branch Name text box, type in Brisbane, and then click Branch Name Check. You will see that it searches column A of the spreadsheet, and then fills the userform with the information in that row, so that a user can double check if that's the right record. Clicking on Branch Name Check again will then loop through Column A, searching for any other record with Brisbane in the name (eg, Brisbane City, Royal Brisbane Hospital, etc).

However, that exact same code does not work in the Leasing spreadsheet. It throws a 1004 error, and I have no idea why.

Any insight would be greatly appreciated!

Just thought I would post the solution here, in case anyone else had the same issue (someone on another forum solved it).

The button "SignageNeededButton" had a Tag property of 4, and although I can't see how that could affect the FillForm() or SaveForm() functions, when the two are not connected in any way, apparently it did. Apparently 4 can't be used with Columns in code such as:

Please Login or Register  to view this content.

Removing that tag property (and ensuring no other controls had that tag property) solved everything, and everything works exactly as it should now.

Thanks so much for your input, Winon and Dwint!

Both subs have that exact same code in them.

Oh! Hi Norie! Thanks for solving this for me on the other forum. I didn't realise you were over here too.

I know both subs have the same code, but I just don't understand how a button that's not writing to the database could have any effect on those subs. But I don't understand vba well enough yet.

In any event, you were absolutely correct, and removing that tag solved everything, so it's all good! I'll wrap my head around why it worked at a later date. Right now, I'm just so happy it's fixed!

Thanks again! Absolute genius!

The button, was it 'Branch Check', called the sub FillForm.

It doesn't call SaveForm but since that has that same piece of code you would have encountered the same problem there.