Very slow macro

[ESF]

Sorry, but another question about slow macro's. I've read a lot of threads about it but cannot figure out what I'm doing wrong here.

This macro will check a large cost estimate for empty line items. If no quantity is calculated, the line item is hidden. Also if a heading has no line items at all, the heading (incl. subtotal) is hidden as well. So far, this works. However if a cost estimate has several hundred line items and a couple of dozen objects (worksheets) it takes a very long time.

Maybe somebody has some advice to improve this macro? Maybe the 'case' statement instead of 'if end if'?

Please Login or Register  to view this content.

The code with ?????0 knows what a line item is. They always have 6 digits and a zero at the end.

Thank you in advance.
Erik

[JosephP]

maybe

Please Login or Register  to view this content.

[watersev]

hi ESF, please check attachment, run code "test". The code has been modified completely.

Please Login or Register  to view this content.

[ESF]

Wow! This a huge time saving for both suggestions! Initially I had to wait many many minutes. Now for the code by watersev 1,5 minute and JosephP to 11 seconds!

Please Login or Register  to view this content.

As I try to understand both your improvements, I see you skip the hiding part till the end and then use 'union' to hide them all in once. The code by watersev is doing perfect, however for more time saving I tried to fix JP’s code.

Unfortunately one row is not hidden by mistake (see screendump). If a heading has no line items underneath, its sub-total is hidden (correctly) but the heading itself not. I think this is checked in this part:

Please Login or Register  to view this content.

but I don't know how to correct it.

[JosephP]

my bad

Please Login or Register  to view this content.

[ESF]

Perfect! I'll turn this thread into 'solved'.

Thank you all