Trouble with Split Function

**cr6196** · 09-04-2012, 03:57 PM

Hi,

I am having trouble with the code below. I am trying to use the below code to split up a ticker symbol entered in Sheet1.A1. The format is XXXX:XXX and I am looking to preserve the letters after :

The code below only returns the stuff before the :

Any help would be appreciated.

Sub SplitIt()

    Dim s As Variant
    Dim p As Variant
    
    s = Worksheets("Sheet1").Cells(1, 1).Value
    
    p = Split(s, ":")
    
    For Each i In p
    Worksheets("Sheet6").Cells(1, 1).Value = p
    Next
    
    

End Sub

**Jakobshavn** · 09-04-2012, 04:01 PM

Note that p(0) is the first part and p(1) is the second part

Worksheets("Sheet6").Cells(1, 1).Value = p(1)
inserts the part after the colon

**MaczaQ** · 09-04-2012, 04:01 PM

here you run a loop without changing destination range so you always return last word:

    For Each i In p
    Worksheets("Sheet6").Cells(1, 1).Value = p 'here should be i ?
    Next

try

Sub SplitIt()

    Dim s As Variant
    Dim p As Variant
    
    s = Worksheets("Sheet1").Cells(1, 1).Value
    
    p = Split(s, ":")
    
    Worksheets("Sheet6").Cells(1, 1).Value = p(0) 'first element in array p
    
    'or
    ' Worksheets("Sheet6").Cells(1, 1).Value = p(1) 'second element in array p
 
End Sub

**cr6196** · 09-04-2012, 04:04 PM

Thank you very much. I suspected it was something embarassingly simple.

**mike7952** · 09-04-2012, 04:06 PM

This what you want?

    s = Worksheets("Sheet1").Cells(1, 1).Value
    p = Split(s, ":")
    For i = LBound(p) To UBound(p)
        Worksheets("Sheet2").Cells(i + 1, 1).Value = p(i)
    Next

**Cutter** · 09-04-2012, 05:27 PM

@ cr6196

Based on your last post it seems that you are satisfied with the solution(s) you've received but you haven't marked your thread as SOLVED. I'll do that for you now but please keep in mind for your future threads that Rule #9 requires you to do that yourself. If your problem has not been solved you can use Thread Tools (located above your first post) and choose "Mark this thread as unsolved".
Thanks.

Also, as a new member of the forum, you may not be aware that you can thank those who have helped you by clicking the small star icon located in the lower left corner of the post in which the help was given. By doing so you can add to the reputation(s) of those who helped.