Macro has to run twice to change correct pivot items

[fratello]

hi guys,
I am new to vba and tried to create a macro which changes the pivot items on a specific pivot table based on the inputs in 2 cells (range called product1 or product2).
However, the code only works if i run the macro twice. I read that it could have something to do with refreshing the worksheet, but the codes i found online did not work for me.
The data for the pivot table comes from another worksheet within the same workbook, so no external connection.

Sub newproduct()
'
On Error Resume Next
    Dim pt As PivotTable
    Dim pi As PivotItem

Sheets("pivot").Select  
    Set pt = ActiveSheet.PivotTables("PivotTable1")
     
    For Each pi In pt.PivotFields("Product").PivotItems
     pi.Visible = True
  'if the criterias are shown in the range, make pivot item visible
        If pi.Name = Range("product1") Or pi.Name = Range("product2") Then
            pi.Visible = True
           
   'if item not shown in the range, deselect
        Else
            pi.Visible = False
        End If
    Next pi
end sub

I suppose there are errors in my code. hope someone can help me out.
Thanks.
greetings,
michael

[Mordred]

So are you wanting this to run twice? If so, try (not tested):

Sub newproduct()
'
On Error Resume Next
    Dim pt As PivotTable
    Dim pi As PivotItem
    Dim x as Long
Sheets("pivot").Select  
    Set pt = ActiveSheet.PivotTables("PivotTable1")
    for x = 1 to 2
       For Each pi In pt.PivotFields("Product").PivotItems
        pi.Visible = True
        'if the criterias are shown in the range, make pivot item visible
        If pi.Name = Range("product1") Or pi.Name = Range("product2") Then
            pi.Visible = True
           
       'if item not shown in the range, deselect
       Else
            pi.Visible = False
       End If
       Next pi
    next x
end sub

[fratello]

Hi Mordred,
Actually, i am trying to find out what is wrong with my code because it only works if the macro is run twice. So what i did was insert my code into the module twice and then it works. But your code looks much neater because you use the long function.
Thank you very much for that, it works perfectly and i will use ur code for now!

Do you also know wy my code has to run twice to give the correct answer?

[Mordred]

I'm not sure why you would have to run it twice but perhaps it is due to your

If pi.Name = Range("product1") Or pi.Name = Range("product2") Then

Maybe that line could be split like

If pi.Name = Range("product1") Then
...
ElseIf pi.Name = Range("product2") Then
...
Else
...
End If

The whole thing without a for loop

Sub newproduct()
'
On Error Resume Next
    Dim pt As PivotTable
    Dim pi As PivotItem

Sheets("pivot").Select  
    Set pt = ActiveSheet.PivotTables("PivotTable1")
     
    For Each pi In pt.PivotFields("Product").PivotItems
     pi.Visible = True
  'if the criterias are shown in the range, make pivot item visible
        If pi.Name = Range("product1") Then 
            pi.Visible = True
        ElseIf pi.Name = Range("product2") Then
            pi.Visible = True 
   'if item not shown in the range, deselect
        Else
            pi.Visible = False
        End If
    Next pi
end sub

I don't know for sure if this will work but give it a test. If it doesn't then go with my last post's code sample.

[fratello]

ok great i will try it out when i get home. thanks a lot for ur time and help!

[MarvinP]

I'd try to put a line of code at the end of

ActiveWorkbook.RefreshAll

to see if that keeps you from running it twice.

[fratello]

thanks marvinp, i saw that in a similar thread and already tried it out. but it didnt work in my case strangely

[JosephP]

you could remove the on error resume next to find out what is actually going wrong

[fratello]

you could remove the on error resume next to find out what is actually going wrong

hmm then i get a "runtime error 1004 Unable to set the Visible property of the pivot item class" when the macro comes to
" Else pi.Visible = False" Line.

What does that mean?

[MarvinP]

I found in Pivot Tables I could not visible = false everything. I needed to do a loop to turn all visible = true first and then turn things off. Perhaps you are trying to do this, which produces your error?

[fratello]

ok i found this solution in another thread http://www.excelforum.com/excel-prog...vot-table.html and i changed it to fit my sheets

    Dim pt As PivotTable
    Dim pi As PivotItem
    Sheets("pivot").Select

With ActiveSheet.PivotTables("PivotTable1").PivotFields("Product")
    
    .ClearAllFilters
    For Each pi In .PivotItems
        Select Case pi.Name
            Case Range("product1"), Range("product2")
                pi.Visible = True
            Case Else
                pi.Visible = False
        End Select
    Next pi
End With
End Sub

This code is quite similar to the one i had before (except that it clears all filters first?), but it seems to work after running only once.
Thanks for help guys

[Cutter]

@ fratello

Based on your last post it seems that you are satisfied with the solution(s) you've received but you haven't marked your thread as SOLVED. I'll do that for you now but please keep in mind for your future threads that Rule #9 requires you to do that yourself. If your problem has not been solved you can use Thread Tools (located above your first post) and choose "Mark this thread as unsolved".
Thanks.

Also, as a new member of the forum, you may not be aware that you can thank those who have helped you by clicking the small star icon located in the lower left corner of the post in which the help was given. By doing so you can add to the reputation(s) of those who helped.

[fratello]

thanks cutter u are rihgt it is solved