+ Reply to Thread
Results 1 to 6 of 6

To improve Efficiency of code, code running too long

  1. #1
    Registered User
    Join Date
    04-09-2012
    Location
    Singapore
    MS-Off Ver
    Excel 2010
    Posts
    54

    To improve Efficiency of code, code running too long

    Hi guys,

    i have this code to be run on excel. What i have done previously was spliting the email message body each text to each cells before running this code.

    However every alternate cells has a blank cell for this particular sender( i have many sender with different formart, only this affecting) so by running this code will take out all the blank cells. i also notice that the blank cell contains Chr(10) .


    This code is working but taking way too long to process for just one email only. So is there anyway to improve on this ? Timing for this was 30 sec ~ 50 Sec to process ( using timer ). About me i am new to VBA , those codes is i happen to learn through the net.

    Thanks in an advance !



    Please Login or Register  to view this content.
    Last edited by andywsw; 06-18-2012 at 09:55 PM.

  2. #2
    Forum Expert
    Join Date
    01-15-2007
    Location
    Brisbane, Australia
    MS-Off Ver
    2007
    Posts
    6,591

    Re: To improve Efficiency of code, code running too long

    Hi

    If there is always something that will be to the far right on each of the rows to be actioned (ie past the last of the chr(10) items that are to be deleted) then try something like

    Please Login or Register  to view this content.
    HTH

    rylo

  3. #3
    Registered User
    Join Date
    04-09-2012
    Location
    Singapore
    MS-Off Ver
    Excel 2010
    Posts
    54

    Re: To improve Efficiency of code, code running too long

    Hi rlyo


    thanks for the response !did try your codes.

    It works! but it takes jsut as long as the original i been using

    But i am going to use ur code seems more stable ( just the feeling ) !

    i think there is not much way to make it faster i assume

    Cheers

  4. #4
    Forum Expert
    Join Date
    01-15-2007
    Location
    Brisbane, Australia
    MS-Off Ver
    2007
    Posts
    6,591

    Re: To improve Efficiency of code, code running too long

    Hi

    Don't give up quite so easily.

    What would happen if you did a replace on the chr(10) items and made them blank? Sure the blank cells are still there, but can you just not process them?

    Maybe give us an example of the file, and explain what it is you want to get from it.

    rylo

  5. #5
    Registered User
    Join Date
    04-09-2012
    Location
    Singapore
    MS-Off Ver
    Excel 2010
    Posts
    54

    Re: To improve Efficiency of code, code running too long

    try.xlsx

    this a sample of a file

  6. #6
    Forum Expert
    Join Date
    01-15-2007
    Location
    Brisbane, Australia
    MS-Off Ver
    2007
    Posts
    6,591

    Re: To improve Efficiency of code, code running too long

    and you want the result to be what? Or the processing to be?

    Are you merely trying to make sure that all the data is in the first 3 columns?

    What are you wanting to do?

    rylo

+ Reply to Thread

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Search Engine Friendly URLs by vBSEO 3.6.0 RC 1