Hi,

I tried to write a macro, it works fine but as I am learning I wondered if there were any pitfalls or perhaps something I have missed.
Your guidance will be greatly appreciated.

Thanks

Sub Copy_Value()
'
'
'

'
    Rows("1:1").Select
    Selection.Find(What:="CASH_CODE", After:=ActiveCell, LookIn:=xlFormulas, _
        LookAt:=xlPart, SearchOrder:=xlByRows, SearchDirection:=xlNext, _
        MatchCase:=False, SearchFormat:=False).Activate
    ActiveSheet.ListObjects("tblBoNYData").Range.AutoFilter Field:=12, Criteria1 _
        :="BATRANS"
        
    Do
    ActiveCell.Offset(1, 0).Select
    Loop Until Rows(ActiveCell.Row).Hidden = False
    
    Selection.Copy
 
    Rows("1:1").Select
    Selection.Find(What:="ELE_CODE4", After:=ActiveCell, LookIn:=xlFormulas, _
        LookAt:=xlPart, SearchOrder:=xlByRows, SearchDirection:=xlNext, _
        MatchCase:=False, SearchFormat:=False).Activate
        
    Do
    ActiveCell.Offset(1, 0).Select
    Loop Until Rows(ActiveCell.Row).Hidden = False
        
    ActiveSheet.Paste
    Range(Selection, Selection.End(xlDown)).Select
    Selection.SpecialCells(xlCellTypeVisible).Select
    Application.CutCopyMode = False
    Selection.FillDown
    
    Rows("1:1").Select
    Selection.Find(What:="CASH_CODE", After:=ActiveCell, LookIn:=xlFormulas, _
        LookAt:=xlPart, SearchOrder:=xlByRows, SearchDirection:=xlNext, _
        MatchCase:=False, SearchFormat:=False).Activate
    
    Do
    ActiveCell.Offset(1, 0).Select
    Loop Until Rows(ActiveCell.Row).Hidden = False
    
   ActiveCell.FormulaR1C1 = "-"
    Range(Selection, Selection.End(xlDown)).Select
    Selection.SpecialCells(xlCellTypeVisible).Select
    Selection.FillDown
    
    ActiveSheet.ListObjects("tblBoNYData").Range.AutoFilter Field:=12
        
End Sub