Excel shutting down during save

Okay, I've done some more testing, and I can narrow down the problem even more.

The problem seems to be triggered by the HO and MO variants; for some reason Excel doesn't seem happy about those two. Any ideas on another way to do it?

I still need help.

I tried this morning just saving the active workbook with a new name.

Please Login or Register  to view this content.

Same reaction, Excel shuts down and offers to recover my work.

1) Self-taught in VBA, so blame my teacher that I don't know the right code to use. What do you mean by "Call directly", rather than "Run"?

2) You'd have to point out specifics for me to explain the "why"s of these.

3)

Please Login or Register  to view this content.

TwoB is the workbook that contains the Lookups sheet I attached to my first post. HO and MO are in there.

Run or Call;
I just did some research, and it appears you use Run when you're calling a macro from another workbook, Call when you're running a macro within a workbook. All of my macros are run from one workbook, and they all modify another workbook, and use other workbooks. So that's why I use Run.

For 1), are you saying I could just put Killbutts, with nothing else, and "Killbutts()" would run?

For 2, you're right. I had thought

Please Login or Register  to view this content.

would cover all of the code under it until my "End With", but my WITH is only talking about A1, not the other cells. Sloppy of me; I'll work on that.

For 3, I don't remember what values were in the workbook I first posted, as they change depending on what month we're in a what region we're running. Representative values are June for H1, 030 for M1.

No, nothing before save. Would it help if I posted the workbook that all of my code is in? A lot of it wouldn't run, as it depends on other workbooks, but you're welcome to inspect the code if you'd like.

It's getting worse. When my active workbook (TwoB) is created, it's automatically saved to my desktop. So, I added a routine right before my attempted save to the new drive, to save the active workbook, no name change or anything. Excel crashed again, no error message other than Excel is attempting to save my work. The code I used to save my workbook is simply

Please Login or Register  to view this content.

. I use it successfully in previous macros, but at the point in question it causes Excel to crash.

I've attached my workbook containing all of my code in the hope that someone can pinpoint the problem. As it stands now, ActiveWorkbook.Save works in the "Lookups" macro, but fails in the "Finish" macro. Any help is greatly appreciated.

Okay, I've narrowed it down more. ActiveWorkbook.Save works BEFORE "Killbutts", but ActiveWorkbook.Save immediately after "Killbutts" causes Excel to fail. So, I'm thinking "Killbutts" might be the problem, I just don't know why. If I remove Killbutts, it runs flawlessly.

Here's "Killbutts"; it's purpose is to delete some autoshape buttons on the active sheet. It seems to work well, but something's going wonky with it.

Please Login or Register  to view this content.

BTW, Killbutts grew from this post: http://www.excelforum.com/excel-prog...-coloring.html

Running it like this, everything works fine (except my buttons aren't deleted):

Please Login or Register  to view this content.

That works, no Excel failure. It deletes my two buttons, but it doesn't delete the two red rectangular autoshapes I had behind my two buttons.

Romper, thanks for the advice on deleting shapes. I'm not at all familiar with shapes, so this stuff is all new to me.

I changed Killbutts as you suggested, and it's doing the trick now with no hiccups. Thank you very much for helping me locate and fix the problem. I'll see if I can implement all your suggestions for tightening up my code.

Thanks,
John

Please Login or Register  to view this content.

Sure. Except for all my hair falling out, a nervous giggle whenever I speak, and the twitching of the whole left side of my face, I'm having the time of my life!