Results 1 to 32 of 32

Macros: Data cleaning macros not producing expected outputes.

Threaded View

  1. #1
    Registered User
    Join Date
    06-03-2011
    Location
    chertsey, england
    MS-Off Ver
    Excel 2007
    Posts
    19

    Macros: Data cleaning macros not producing expected outputes.

    I want the attached excel document (001) to take the pasted data (as in 002 sheet 2) and after macros cleaner1 (0004) and cleaner 2, (0005) produce a final output as in the output doc.
    However after running macro cleaner 1, the sum formula on sheet 2 under column P changes in the number of cells to be added up.

    Then after running cleaner 2, I noticed that although the entire sheet 1 uses fixed references, some of the cell references have been changed such that they are fetching the wrong data. Also, in sheet 2, under number 3, there is an "SP" that should have been deleted just as there are some blanks under column T that should have been deleted.
    All the cleaner codes are included below.
    Thanks.
    Sub Cleaner1()
    '
    ' Cleaner Macro
    ' Cleans imported data.
    '
    ' Keyboard Shortcut: Ctrl+Shift+C
    '
        Range("A20").Select
        Selection.ClearContents
       Range("A21").Select
        Selection.ClearContents
        Range("A32").Select
        Selection.ClearContents
       Range("A33").Select
        Selection.ClearContents
        Range("A44").Select
        Range("A45").Select
        Selection.ClearContents
        Selection.ClearContents
        Range("A56").Select
        Selection.ClearContents
        Range("A57").Select
        Selection.ClearContents
        Range("A68").Select
        Selection.ClearContents
        Range("A69").Select
        Selection.ClearContents
        Range("A80").Select
        Selection.ClearContents
        Range("A81").Select
        Selection.ClearContents
        Rows("90:104").Select
        Selection.Insert Shift:=xlDown, CopyOrigin:=xlFormatFromLeftOrAbove
       Rows("78:92").Select
        Selection.Insert Shift:=xlDown, CopyOrigin:=xlFormatFromLeftOrAbove
        Rows("66:80").Select
        Selection.Insert Shift:=xlDown, CopyOrigin:=xlFormatFromLeftOrAbove
        Rows("54:68").Select
        Selection.Insert Shift:=xlDown, CopyOrigin:=xlFormatFromLeftOrAbove
       Rows("42:56").Select
        Selection.Insert Shift:=xlDown, CopyOrigin:=xlFormatFromLeftOrAbove
        Rows("30:44").Select
        Selection.Insert Shift:=xlDown, CopyOrigin:=xlFormatFromLeftOrAbove
    
    End Sub
    Sub Cleaner2()
    '
    ' Cleaner2 Macro
    '
    ' Keyboard Shortcut: Ctrl+Shift+L
    '
     On Error Resume Next
    ' In case there are no blanks
      Columns("G:I").Select
        Selection.Insert Shift:=xlToRight, CopyOrigin:=xlFormatFromLeftOrAbove
        Columns("F:F").Select
        Range("F25:F44").Select
        Selection.TextToColumns Destination:=Range("F25"), DataType:=xlFixedWidth, _
            FieldInfo:=Array(Array(0, 1), Array(1, 1), Array(2, 1), Array(3, 1)), _
            TrailingMinusNumbers:=True
       Range("F52:F71").Select
        Selection.TextToColumns Destination:=Range("F52"), DataType:=xlFixedWidth, _
            FieldInfo:=Array(Array(0, 1), Array(1, 1), Array(2, 1), Array(3, 1)), _
            TrailingMinusNumbers:=True
         Range("F79:F98").Select
        Selection.TextToColumns Destination:=Range("F79"), DataType:=xlFixedWidth, _
            FieldInfo:=Array(Array(0, 1), Array(1, 1), Array(2, 1), Array(3, 1)), _
            TrailingMinusNumbers:=True
        Range("F106:F125").Select
        Selection.TextToColumns Destination:=Range("F106"), DataType:=xlFixedWidth, _
            FieldInfo:=Array(Array(0, 1), Array(1, 1), Array(2, 1), Array(3, 1)), _
            TrailingMinusNumbers:=True
     Range("F133:F152").Select
        Selection.TextToColumns Destination:=Range("F133"), DataType:=xlFixedWidth _
            , FieldInfo:=Array(Array(0, 1), Array(1, 1), Array(2, 1), Array(3, 1)), _
            TrailingMinusNumbers:=True
     Range("F160:F179").Select
        Selection.TextToColumns Destination:=Range("F160"), DataType:=xlFixedWidth _
            , FieldInfo:=Array(Array(0, 1), Array(1, 1), Array(2, 1), Array(3, 1)), _
            TrailingMinusNumbers:=True
     Range("A1").Select
        Selection.TextToColumns Destination:=Range("A1"), DataType:=xlDelimited, _
            TextQualifier:=xlDoubleQuote, ConsecutiveDelimiter:=True, Tab:=True, _
            Semicolon:=False, Comma:=False, Space:=True, Other:=False, FieldInfo _
            :=Array(Array(1, 1), Array(2, 1), Array(3, 1)), TrailingMinusNumbers:=True
        Range("A10").Select
        Selection.TextToColumns Destination:=Range("A10"), DataType:=xlDelimited, _
            TextQualifier:=xlDoubleQuote, ConsecutiveDelimiter:=True, Tab:=True, _
            Semicolon:=False, Comma:=False, Space:=True, Other:=False, FieldInfo _
            :=Array(Array(1, 1), Array(2, 1), Array(3, 1), Array(4, 1), Array(5, 1), Array(6, 1), _
            Array(7, 1)), TrailingMinusNumbers:=True
        Range("A19").Select
        Selection.TextToColumns Destination:=Range("A19"), DataType:=xlDelimited, _
            TextQualifier:=xlDoubleQuote, ConsecutiveDelimiter:=True, Tab:=True, _
            Semicolon:=False, Comma:=False, Space:=True, Other:=False, FieldInfo _
            :=Array(Array(1, 1), Array(2, 1), Array(3, 1), Array(4, 1), Array(5, 1), Array(6, 1)), _
            TrailingMinusNumbers:=True
        Range("A46").Select
        Selection.TextToColumns Destination:=Range("A46"), DataType:=xlDelimited, _
            TextQualifier:=xlDoubleQuote, ConsecutiveDelimiter:=True, Tab:=True, _
            Semicolon:=False, Comma:=False, Space:=True, Other:=False, FieldInfo _
            :=Array(Array(1, 1), Array(2, 1), Array(3, 1), Array(4, 1), Array(5, 1), Array(6, 1)), _
            TrailingMinusNumbers:=True
     Range("A73").Select
        Selection.TextToColumns Destination:=Range("A73"), DataType:=xlDelimited, _
            TextQualifier:=xlDoubleQuote, ConsecutiveDelimiter:=True, Tab:=True, _
            Semicolon:=False, Comma:=False, Space:=True, Other:=False, FieldInfo _
            :=Array(Array(1, 1), Array(2, 1), Array(3, 1), Array(4, 1), Array(5, 1), Array(6, 1), _
            Array(7, 1)), TrailingMinusNumbers:=True
        Range("A100").Select
        Selection.TextToColumns Destination:=Range("A100"), DataType:=xlDelimited, _
            TextQualifier:=xlDoubleQuote, ConsecutiveDelimiter:=True, Tab:=True, _
            Semicolon:=False, Comma:=False, Space:=True, Other:=False, FieldInfo _
            :=Array(Array(1, 1), Array(2, 1), Array(3, 1), Array(4, 1), Array(5, 1), Array(6, 1)), _
            TrailingMinusNumbers:=True
        Range("A127").Select
        Selection.TextToColumns Destination:=Range("A127"), DataType:=xlDelimited, _
            TextQualifier:=xlDoubleQuote, ConsecutiveDelimiter:=True, Tab:=True, _
            Semicolon:=False, Comma:=False, Space:=True, Other:=False, FieldInfo _
            :=Array(Array(1, 1), Array(2, 1), Array(3, 1), Array(4, 1), Array(5, 1), Array(6, 1), _
            Array(7, 1)), TrailingMinusNumbers:=True
     Range("A154").Select
        Selection.TextToColumns Destination:=Range("A154"), DataType:=xlDelimited, _
            TextQualifier:=xlDoubleQuote, ConsecutiveDelimiter:=True, Tab:=True, _
            Semicolon:=False, Comma:=False, Space:=True, Other:=False, FieldInfo _
            :=Array(Array(1, 1), Array(2, 1), Array(3, 1), Array(4, 1), Array(5, 1), Array(6, 1)), _
            TrailingMinusNumbers:=True
    Range("S1").Select
        Selection.AutoFill Destination:=Range("S1:S190"), Type:=xlFillDefault
        Range("T1").Select
        Selection.AutoFill Destination:=Range("T1:T190"), Type:=xlFillDefault
        Range("G1").Activate
     Range("T1:T500").SpecialCells(xlCellTypeBlanks).EntireRow.Delete
    With ActiveSheet
    Do While .Range("U159").Value < "6"
    Range("A160:T160").Select
    Selection.Copy
    Range("A159:A179").Select
    Selection.Find(What:="", After:=ActiveCell, LookIn:=xlFormulas, LookAt _
    :=xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlNext, MatchCase:= _
    False).Activate
    ActiveCell.Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
    :=False, Transpose:=False
    Loop
    End With
    With ActiveSheet
    Do While .Range("U132").Value < "6"
    Range("A133:T133").Select
    Selection.Copy
    Range("A132:A152").Select
    Selection.Find(What:="", After:=ActiveCell, LookIn:=xlFormulas, LookAt _
    :=xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlNext, MatchCase:= _
    False).Activate
    ActiveCell.Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
    :=False, Transpose:=False
    Loop
    End With
    With ActiveSheet
    Do While .Range("U105").Value < "6"
    Range("A106:T106").Select
    Selection.Copy
    Range("A105:A125").Select
    Selection.Find(What:="", After:=ActiveCell, LookIn:=xlFormulas, LookAt _
    :=xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlNext, MatchCase:= _
    False).Activate
    ActiveCell.Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
    :=False, Transpose:=False
    Loop
    End With
    
    With ActiveSheet
    Do While .Range("U78").Value < "6"
    Range("A79:T79").Select
    Selection.Copy
    Range("A78:A97").Select
    Selection.Find(What:="", After:=ActiveCell, LookIn:=xlFormulas, LookAt _
    :=xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlNext, MatchCase:= _
    False).Activate
    ActiveCell.Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
    :=False, Transpose:=False
    Loop
    End With
    With ActiveSheet
    Do While .Range("U51").Value < "6"
    Range("A52:T52").Select
    Selection.Copy
    Range("A51:A71").Select
    Selection.Find(What:="", After:=ActiveCell, LookIn:=xlFormulas, LookAt _
    :=xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlNext, MatchCase:= _
    False).Activate
    ActiveCell.Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
    :=False, Transpose:=False
    Loop
    End With
    With ActiveSheet
    Do While .Range("U24").Value < "6"
    Range("A25:T25").Select
    Selection.Copy
    Range("A24:A44").Select
    Selection.Find(What:="", After:=ActiveCell, LookIn:=xlFormulas, LookAt _
    :=xlPart, SearchOrder:=xlByColumns, SearchDirection:=xlNext, MatchCase:= _
    False).Activate
    ActiveCell.Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
    :=False, Transpose:=False
    Loop
    End With
    Range("G1").Activate
    Range("A1:A500").SpecialCells(xlCellTypeBlanks).EntireRow.Delete
    End Sub
    Attached Files Attached Files
    Last edited by bertlogdi1; 06-07-2011 at 12:34 PM. Reason: To conform to rules.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Search Engine Friendly URLs by vBSEO 3.6.0 RC 1