Results 1 to 2 of 2

wrong data copied into new cell from macro

Threaded View

johnmerlino wrong data copied into new... 05-11-2011, 08:53 PM
JBeaucaire Re: wrong data copied into... 05-12-2011, 10:42 AM
  1. #2
    Forum Expert JBeaucaire's Avatar
    Join Date
    03-21-2004
    Location
    Bakersfield, CA
    MS-Off Ver
    2010, 2016, Office 365
    Posts
    33,492

    Re: wrong data copied into new cell from macro

    Try this:
    Option Explicit
    
    Sub Inspect()
    Dim LValue  As String, LValue2  As String
    Dim lngLastRow As Long, i As Long
    
    lngLastRow = ActiveSheet.Range("A" & Rows.Count).End(xlUp).Row
      
    For i = 1 To lngLastRow
        If InStr(Range("F" & i), "FORECLOSURE") Then
            If InStr(Range("J" & i), "DEFENDANT") Then
                If InStr(Range("G" & i), " V ESTATE OF ") <> 0 Then
                    Range("N" & i) = Trim(Mid(Range("G" & i), InStr(Range("G" & i), " V ESTATE OF ") + 12, 100))
                ElseIf InStr(Range("G" & i), " V ") <> 0 Then
                    Range("N" & i) = Trim(Mid(Range("G" & i), InStr(Range("G" & i), " V ") + 3, 100))
                ElseIf InStr(Range("G" & i), " VS ") <> 0 Then
                    Range("N" & i) = Trim(Mid(Range("G" & i), InStr(Range("G" & i), " VS ") + 4, 100))
                End If
     
                If InStr(Range("K" & i), "  ") <> 0 Then
                    Range("O" & i) = Range("K" & i)
                Else
                    If InStr(Range("K" & i), "UNKNOWN SPOUSE") > 0 Then
                        Range("O" & i) = Trim(Replace(Left(Range("K" & i), Len(Range("K" & i)) - 1), "_", ""))
                    Else
                        Range("O" & i) = Trim(Replace(Range("K" & i), "_", ""))
                    End If
                End If
            End If
        End If
    Next i
     
    End Sub

    The problem was you hadn't put in the UNKNOWN SPOUSE stuff anywhere, and you were only filling in your LValue variable when there were dblspaces. Since most of your variables were only being referenced one time, I took a bunch out and issued commands directly against the one-time calculations.

    Also, based on your final instructions above, you had the wrong information going into N and O, backwards.
    Last edited by JBeaucaire; 05-12-2011 at 10:44 AM.
    _________________
    Microsoft MVP 2010 - Excel
    Visit: Jerry Beaucaire's Excel Files & Macros

    If you've been given good help, use the icon below to give reputation feedback, it is appreciated.
    Always put your code between code tags. [CODE] your code here [/CODE]

    ?None of us is as good as all of us? - Ray Kroc
    ?Actually, I *am* a rocket scientist.? - JB (little ones count!)

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Search Engine Friendly URLs by vBSEO 3.6.0 RC 1