Loop in canceling of event

Hello everyone.

I have a bug that causes a loop in in my code. Let me walk you through it:

A user is prompted to select a Port

Private Sub Port_BeforeUpdate(ByVal Cancel As MSForms.ReturnBoolean)
    If Port.ListIndex = -1 Then
        MsgBox "Please select from the list of ports provided"
        Cancel = True
    End If
End Sub

Say the user changes her mind and does not want to select any Port, she wants to quit, I have a cancel button

that is supposed to do this,

Private Sub btnCancel_Click()
    Dim vols As String
    Dim notes As String
    Dim volVals() As String
    Dim noteVals() As String
    Dim NCode As Integer
    Dim volCode As Integer
    Dim iVol As Integer
    Dim iNote As Integer
    
    ' since any changes to the Opportunity recordset have not occured (only applied when Done button is selected)
    ' they do not need to be 'rolled back'
    If VolTrans Then
        ' this will rollback any deletes
        VolConn.RollbackTrans
    End If
    'The next block rollsback any Added records (since UPDATES are not properly handled by an ADO Transaction with Access)
    If NewVol And addedVol.Count > 0 Then
        For iVol = 1 To addedVol.Count
            vols = vols & addedVol(iVol) & ","
        Next
        vols = Left(vols, Len(vols) - 1)
        VolConn.Execute "Delete from VOL where VolCode in (" & vols & ")"
    End If
    'this handles any Edited volume records
    
    If updVol And editVol.Count > 0 Then
        For iVol = 1 To editVol.Count
            volVals = Split(editVol(iVol), "|")
            volCode = val(volVals(3))
            VolConn.Execute "Update VOL set Port = '" & volVals(0) & "', Subport = '" & volVals(1) & "', Product = '" & volVals(2) & "'," & _
                "PartialVolume = " & val(volVals(3)), "PartialMargin = " & val(volVals(4)) & " where volCode = " & volCode
        Next iVol
    End If
    ' this handles any Deleted Note records
    If NoteTrans Then
        NoteConn.RollbackTrans
    End If
    'this will remove any Added Notes
    If addedNote.Count > 0 Then
        For iNote = 1 To addedNote.Count
            notes = vols & addedNote(iNote) & ","
        Next
        notes = Left(notes, Len(notes) - 1)
        NoteConn.Execute "Delete from NOTES where NCode in (" & notes & ")"
    End If
    'this handles any Edited volume records - set them back to their original value
    If updNote And editNote.Count > 0 Then
        For iNote = 1 To editNote.Count
            noteVals = Split(editNote(iNote), "|")
            NCode = val(noteVals(4))
            NoteConn.Execute "Update Notes set NoteDate = #" & Replace(noteVals(0), ".", "/") & "#, NoteDetails = '" & noteVals(1) & "'," & _
                "Step = '" & noteVals(2) & "', Type = '" & noteVals(3) & "' where NCode = " & NCode
        Next
    End If
    
    Unload Me

End Sub

The problem is that the cancellation button is not wokring properly. When you press "Cancel" it loops back to "Please select a product from the list provided" instead of exiting the userform.
Any suggestions?

hi,


Not sure if this is correct, but did you try Exit Sub after the "Unload Me"

Private Sub Port_BeforeUpdate(ByVal Cancel As MSForms.ReturnBoolean)
  If Port.ListIndex = -1 Then MsgBox "Please select from the list of ports provided"
End Sub

snb,

I should have seen that, because I just addressed the same issue in another forum.
May be I should take my "Blinders" off.