Reviewing Code

**AnthonyWB** · 08-20-2010, 09:58 AM

Hello everyone. This is not a specific programming questions. I have started to finish an automation project. I was wondering if someone with solid VBA experience would be interested in reviewing my code. The code spans several modules and comprises approximately 2,000 lines of written code. Most of that code is repetitious and I suspect a more senior programmer could provide hints, suggestions or even ways to condense the code so that it is more readable and more effecitent. It would be greatly appreciated and improve my VBA skills. Note that the code does not "fit" into the Excel forums space requirements. Thanks.

**StephenR** · 08-20-2010, 10:07 AM

Is that 2,000 or 20,000?! Can you post a sample of a bit you think could be improved. I doubt anyone will undertake to look through that much code, at least not for free!

**AnthonyWB** · 08-20-2010, 10:24 AM

Here is some of the code: This is a small chunk. I am sure this can be trimmed down.

Please Login or Register  to view this content.

**T-J** · 08-20-2010, 12:24 PM

Subs Create_105_File_1, Create_105_File_2, Create_105_File_3 all do the same thing with a different string, so replace with a single Sub which takes a string argument(s)? and call by passing each string into it.

Likewise, in Sub Create_Disclosure_Breakdown_Files the bits where you Add and Save can be slimmed down the same way.