Code Writing Tips

[Mordred]

I've decided I am going to go through code that I have from projects I have completed and I wanted to get some advice on better writing techniques. I'll give two examples that do the same thing (clean my insert page) from all my projects.

Original code:

Please Login or Register  to view this content.

Or, is this a better, smoother way:

Please Login or Register  to view this content.

I think the second way is easier on the eyes but does it make any difference as far as how the code runs?

Thank Ya Big Big

[Marcol]

Try this

Please Login or Register  to view this content.

or

Please Login or Register  to view this content.

Either should do the same.

Hope this helps

[Mordred]

Wow Marcol, that was great! Just so I understand

Please Login or Register  to view this content.

(forgive my terminology here), but that function has all of the lines of code that I had used in it already? Either way, that is going to be very useful to me. Thanks so much.

[JBeaucaire]

As Marcol has demonstrated, the Macro Recorder gives real garbage for many events you record. The best time to edit down a macro is immediately after you record it.

If you record yourself simply adding a border to the bottom of a cell and bolding the cell, you get a 15+ lines of code, when you know you only did two things...sounds like it should only be two lines, yes? So as you review the edited code you can pretty safely edit lines that don't have to do with what you recorded.

[Mordred]

I did just what you said about recording the process of adding a line to the bottom of a cell. It outputs in the module a lot of fluff and stuff that is default like xlNone references. When I am at work tomorrow I am going to make quite a few changes to my finished projects. Thanks JB.

[romperstomper]

Just one small point: there is a big difference between the code you posted originally and the Clear method and, depending on your intentions, the latter may not be what you want.
Your initial code targets certain specific formatting and contents; Clear removes everything, including data validation and conditional formatting. No real way of us knowing from your post whether that was your intention.
A literal translation of your original would I think be:

Please Login or Register  to view this content.

[Mordred]

Hey romperstomper, fortunately, the clear method is perfect for my use. The method is run when the workbook closes so that the insert sheet is clear of all formatting and values. It is an insert sheet where data from our source is originally pasted, to update our records. The tables we bring in from the source are full of borders, interior colors, and merged cells, all of which need to go at close. Thanks for your insight though, just knowing that I don't have to enter all of the different border removals will help me in the future when I want to clear just borders.