hi Foxguy,
Cool, I'm pleased it reminded you
I haven't seen that version before & I think that I'll be making use of it too.
LOL
Try a [ctrl + F], I found 5 of them, in the post 28 file, that weren't "on error goto...". The one that caught my eye was "GoTo ReSet_Colors" which you've used to create a looping effect. You may be better off with a "Do ... until" loop or even a For... Next loop that incorporates an "exit for" (you could also have an "Exit Do") when the condition is met.
Yes, each occurence may for something really simple, but they annihilate a top to bottom (start to finish) "flow" by creating multiple exit points (w/o even considering the cases where goto causes a looping effect) and make debugging that much more difficult.
Ooopps!
I knew I had forgotten a couple of suggestions last time...
- For portability, many users may find it easier to change a "shLinks" worksheet variable in one place near the top of your code rather than by changing the code name of a sheet. Although... on the flip side, the code name of a sheet is probably less likely to be changed in error...
- Your "label1" in your last post reminded me of this. What do the "EF" & "HE" labels stand for in your code?
Could they be identified by a more descriptive phrase?
hth
Rob
Bookmarks