VBA If else statement

[peedarp1985]

Hi,
I am trying to write a program for a user form which takes data from the user interface and calculates on the command click and I am trying to do using if else statements but something is wrong can any body help me with this. The code have written is below. I am a beginner and just started using VBA.

Thanks

Private Sub Tolerance_Click()

Dim Msg1 As String
Msg1 = Msg1 & ComboBox1
Dim D As Integer
D = D & TextBox1
Dim L As Integer
L = L & TextBox2
Dim Ts As Integer
Dim S As Integer
Dim Ci As Integer
Dim Cy As Integer

If Msg1 = "Size" Then
Select Case D
Case Is >= 0.25
Ts = 0.001 + (0.006 + 0.005 * D)
Case Is < 0.25
Ts = 0.001 + (0.003 + 0.016 * D)
MsgBox Ts
End Select


If Msg1 = "Straightness" Then
S = L * 0.0087
MsgBox S


If Msg1 = "Circularity" Then
Ci = 0.25 * Size
MsgBox Ci


If Msg1 = "Cylindricity" Then
Cy = S + Ci
MsgBox Cy

End If

End Sub

[royUK]

Your post does not comply with Rule 1 of our Forum RULES. Your post title should accurately and concisely describe your problem, not your anticipated solution. Use terms appropriate to a Google search. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will be addressed according to the OP's experience in the forum: If you have less than 10 posts, expect (and respond to) a request to change your thread title. If you have 10 or more posts, expect your post to be locked, so you can start a new thread with an appropriate title.
To change a Title on your post, click EDIT then Go Advanced and change your title, if 2 days have passed ask a moderator to do it for you.

Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code. Posting code without them makes your code hard to read and difficult to be copied for testing. Highlight your code and click the # at the top of your post window. For more information about these and other tags, found here

[foxguy]

I not sure that I understand what you're doing, but I'll try

Dim Msg1 As String
Dim D As Integer
Dim L As Integer
Dim Ts As Integer
Dim S As Integer
Dim Ci As Integer
Dim Cy As Integer

Msg1 = ComboBox1.Value
D = TextBox1.Value
L = TextBox2.Value

If Msg1 = "Size" Then
    Select Case D
        Case Is >= 0.25
            Ts = 0.001 + (0.006 + 0.005 * D)
        Case Is < 0.25
            Ts = 0.001 + (0.003 + 0.016 * D)
    End Select
    MsgBox Ts

EsleIf Msg1 = "Straightness" Then
    S = L * 0.0087
    MsgBox S


EsleIf Msg1 = "Circularity" Then
    'Can't tell what Size is, so can't correct
    Ci = 0.25 * Size
    MsgBox Ci

ElseIf Msg1 = "Cylindricity" Then
    'S is ALWAYS 0  and Ci is ALWAYS 0 for this test
    '    if S is supposed to be L * 0.0087 then don't put it in the ElseIf above.

    Cy = S + Ci
    MsgBox Cy

End If

End Sub

[peedarp1985]

Thnak's for helping me out with this. Well I am trying to build a user form where it takes value from text box for size D and one for length L and I choose a process in a combobox like size, straightness, circularity and cylyindricity which have different formulas and are associated with each other. So when I enter a size and length and choose a process and hit the command button I want it to calculate the value. So D is a constant and ts, ci, cy are all results which I want to be able to calculate . I am not sure if you understand what i am trying to do? But i could use some assistance on this.

[foxguy]

The way you describe the process could easily be done on a spreadsheet without using a form.
If you really want to do it on a form, can you give some examples of what you're looking for, like if the user enters 3 in size and 2 in length what will be the answer for each selection in the combobox?

[Leith Ross]

Hello peedarp1985,

Your If Then statements are not working because the data being evaluated is a String and not a Number. All data going into and coming out of a TextBox is a String. You will need to convert the text to a number before you test it. It is easier to read using the Select Case statement rather than multiple If Then. Indent your code. It makes it easier to read and to correct.

Private Sub Tolerance_Click()

Dim Msg1 As String
Dim D As Double
Dim L As Double
Dim Ts As Double
Dim S As Double
Dim Ci As Double
Dim Cy As Double

Msg1 = Msg1 & ComboBox1

D = D + Val(TextBox1)
L = L + Val(TextBox2)

Select Case  Msg1
  Case is = "Size"
    Select Case D
      Case Is >= 0.25
        Ts = 0.001 + (0.006 + 0.005 * D)
      Case Is < 0.25
        Ts = 0.001 + (0.003 + 0.016 * D)
    End Select
    MsgBox Ts
  Case Is = "Straightness"
    S = L * 0.0087
    MsgBox S
  Case Is = "Circularity"
    Ci = 0.25 * Size
    MsgBox Ci
  Case Is = "Cylindricity"
    Cy = S + Ci
    MsgBox Cy
End Select

End Sub

[peedarp1985]

Thanks guys I actually solved it. I just had to use double in place of integer which was a silly goof up. Thanks for the help and advice once again.