Referencing command buttons within if-then-else

Hi guys & gals,

I made a userform to calculate the net weight of a package by taking the gross weight and deducting the amount of boxes included in the package. The most boxes possible is 25, so I used 25 command buttons numbered 1 to 25, so users only have to press the desired amount of boxes for the calculation to begin. But that also means I've got 25 subs containing the same formula, and that's a bit much. I'm pretty sure this could be done more efficiently, but I'm not sure what's possible, me not being a VB kind o' guy...

I included the sheet, so if anybody has a better way of doing this, it would be appreciated!

Good morning opopanax666

Originally Posted by opopanax666

I'm pretty sure this could be done more efficiently, but I'm not sure what's possible, me not being a VB kind o' guy...

The file you've uploaded is an Excel 2007 file, and I only have 2003 at work, so I can't bring this into your file, but have a look at the example attached. It contains a simple userform with 8 buttons and a class module to catch the ID of each command button clicked : would this be of any use to you?

More on classes.

HTH

DominicB

There are a number of ways to tackle this.

First and simplest would be to use a dropdown list in order to select quantity.
This would then only require 1 routine.

Or you could move all of the code from a click event in to a routine where you pass the quantity as an argument from the click event

Single calculating routine

Please Login or Register  to view this content.

Click events would look like this, although you will still need 25 calls to the m_Calculate routine.

Please Login or Register  to view this content.

Or you could go with a class and put all of the code in there but that is quite a complex approach.

I noticed if you press a quantity button multiple times the total keeps on changing, if this to be expected?

Originally Posted by dominicb

It contains a simple userform with 8 buttons and a class module to catch the ID of each command button clicked : would this be of any use to you?

Yes, I think I will go the "class" way. Thanks a lot for the speedy reply!

Originally Posted by Andy Pope

Or you could go with a class and put all of the code in there but that is quite a complex approach.

I noticed if you press a quantity button multiple times the total keeps on changing, if this to be expected?

This is a learning experience, so "classes" it is. About the multiple quantities: yes, this is normal given that a package can contain different kinds of boxes... Thanks for the quick reply!