Can this code be tidied up? Macro recorder appears to need some organizational skills

[duugg]

I used macro recorder, and this code was the result. Is there a way to shorten this code up? The more I use macro recorder, the more I'm beginning to realize that the code generated from macro recorder can be very sloppy.

By seeing you all work your magic, I can analysis what you did, and hopefully start shortening these myself

Please Login or Register  to view this content.

[Leith Ross]

Hello duugg,

It would help to know what you are doing. Part of the code applies borders to the selected cells and the other part formats column "C" and then selects "C1". What to you want to do exactly?

[Kenneth Hobson]

Select or Selection is seldom needed. http://www.tushar-mehta.com/excel/vb...acro_recorder/

[duugg]

Basically I'm trying to figure out how you guys figure this stuff out.

A lot there seems to be extra nonsense. It would seem that if you just left a lot of the extra code out, it would default to it anyway. For example, instead of writing ALL this code out to fill an inside and outline border with the same formatting like this..

Please Login or Register  to view this content.

I would think it would make more sense to say it more efficiently...I know this code is wrong, but something to this effect...

Please Login or Register  to view this content.

Is there an equivalent to the above "guessed" code?

[StephenR]

Perhaps the BorderAround method - have a look at Help. That said, I think it would only do outside borders.

[duugg]

How about something like

Please Login or Register  to view this content.

I have the "thought" right, but I know I probably have the syntax wrong..is there a way to combine this?

Thanks

[Phil_V]

As far as I am aware 'With' only operates on single objects / collections at a time, so you are unable to combine the borders within the 'With' statement.
The macro recorder, whilst giving you the 'idea' of what you want to right is not, as you have found, particularly efficient. For one thing it will never use an array, or loops, both of which could be used to 'condense' this code.
However what you can do if you need to apply the same settings to mulitple objects is something like this:

Please Login or Register  to view this content.

[romperstomper]

You can replace your Borders code with:

Please Login or Register  to view this content.

[duugg]

Thanks to both,

Romper, I used your code first because it was shorter, and it worked perfectly.

Thanks!