+ Reply to Thread
Results 1 to 6 of 6

Macro quitting before completion

Hybrid View

  1. #1
    Valued Forum Contributor
    Join Date
    11-20-2003
    MS-Off Ver
    2010, 2016
    Posts
    1,176
    I put resume (plus some additional code) in the error handler and that cleared up the first issue if symbol is not found in column A. Still having trouble if the user enters and invalid date in column B (e.g. enters a Saturday, Sunday, holiday, etc). Not sure if I need another resume someplace in the code and I am just not seeing it.

    Option Explicit
    
    Private Sub CommandButton1_Click()
    
        Application.ScreenUpdating = False
        
        Dim HSDFY As HistoricalStockDataFromYahoo
        Dim rs As ADODB.Recordset
        Dim i As Long
        Dim j As Integer
        Dim lastrow As Integer
    
        On Error GoTo Err_CommandButton1_Click
        
        Range("C2:D" & Rows.Count).ClearContents
    
        i = 2
    
        lastrow = Range("A" & Rows.Count).End(xlUp).Row
    
        For j = 2 To lastrow
            Set HSDFY = New HistoricalStockDataFromYahoo
            Set rs = HSDFY.GetHistoricalData(Cells(j, 1).Value, Cells(j, 2).Value, Cells(j, 2).Value)
            rs.MoveFirst
            Cells(j, 3).CopyFromRecordset rs
            i = i + 1
        Next j
    
    Exit Sub
    
    Err_CommandButton1_Click:
        Select Case Err.Number
            Case 10000
                MsgBox Err.Description
                j = j + 1
                i = i + 1
                Resume
            Case 10001
                'invalid interval
                MsgBox Err.Description
                j = j + 1
                i = i + 1
                Resume
            Case 10002
                'query failed
                MsgBox Err.Description
                j = j + 1
                i = i + 1
                Resume
        End Select
        
        Application.ScreenUpdating = True
        
    End Sub

  2. #2
    Forum Expert shg's Avatar
    Join Date
    06-20-2007
    Location
    The Great State of Texas
    MS-Off Ver
    2010, 2019
    Posts
    40,689
    Set breakpoints; what if the error is none of those you catch?
    Entia non sunt multiplicanda sine necessitate

  3. #3
    Forum Expert shg's Avatar
    Join Date
    06-20-2007
    Location
    The Great State of Texas
    MS-Off Ver
    2010, 2019
    Posts
    40,689
    Err_CommandButton1_Click:
        Select Case Err.Number
            Case 10000
                MsgBox Err.Description
                j = j + 1
                i = i + 1
            Case 10001
                'invalid interval
                MsgBox Err.Description
                j = j + 1
                i = i + 1
            Case 10002
                'query failed
                MsgBox Err.Description
                j = j + 1
                i = i + 1
           Case Else
                MsgBox "some other error"
        End Select
        Resume
        
    End Sub

  4. #4
    Valued Forum Contributor
    Join Date
    11-20-2003
    MS-Off Ver
    2010, 2016
    Posts
    1,176
    That did the trick. Code is working as expected. As always, thank you and all others that take the time out of their day to help others with Excel issues.

    P.S. I really liked your advice for setting breakpoints. This was something I did not know even existed before you made your comment. This is really helpful for debugging.

    Err_CommandButton1_Click:
        Select Case Err.Number
            Case 10000
                MsgBox Err.Description
                j = j + 1
                i = i + 1
            Case 10001
                'invalid interval
                MsgBox Err.Description
                j = j + 1
                i = i + 1
            Case 10002
                'query failed
                MsgBox Err.Description
                j = j + 1
                i = i + 1
           Case Else
                MsgBox "Invalid Search Parameters or other error.  No data was returned."
                j = j + 1
                i = i + 1
        End Select
        Resume

+ Reply to Thread

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Search Engine Friendly URLs by vBSEO 3.6.0 RC 1