Select Case

[Rick_Stanich]

I don't see what I am doing wrong in this code using "Select Case". When activated and the correct string is entered I should get a msgbox pop up.

     Dim sLogin As String
    Dim CapsLock As New SetCapsClass

    CapsLock.Value = True
    sLogin = InputBox("Enter Employee Number here!")
    If sLogin = "" Then
        MsgBox "You must enter your Employee Number!"
        sLogin = InputBox("Enter Employee Number here!")
        Select Case sLogin
        Case 1
            If sLogin = "RS61" Then
                MsgBox "User has full READ/WRITE capabilities!"
                sLogin = True
            End If
        Case 2
            If sLogin = "JE80" Then
                MsgBox "User has full READ/WRITE capabilities!"
                sLogin = True
            End If
        Case 3
            If sLogin = "BC58" Then
                MsgBox "User has full READ/WRITE capabilities!"
                sLogin = True
            End If
        Case 4
            If sLogin = "BF56" Then
                MsgBox "User has full READ/WRITE capabilities!"
                sLogin = True
            End If
        Case 5
            MsgBox "User has WRITE capabilities ONLY!"
            sLogin = False
        End Select
    End If

[Stuie]

Hi Rick_Stanich,

When you say Case 1 that is checking the value entered into sLogin and saying if it is 1 then do the code in this block.

same as Case 2, Case 3, etc...

change it to this.

    Select Case sLogin
        Case "RS61"
            MsgBox "User has full READ/WRITE capabilities!"
            sLogin = True

        Case "JE80"
            MsgBox "User has full READ/WRITE capabilities!"
            sLogin = True
        
        Case "BC58"
            MsgBox "User has full READ/WRITE capabilities!"
            sLogin = True

        Case "BF56"
            MsgBox "User has full READ/WRITE capabilities!"
            sLogin = True

        Case 5
            MsgBox "User has WRITE capabilities ONLY!"
            sLogin = False
    End Select

and on Case 5 change the 5 to the string your checking for

[Andy Pope]

Your code logic does not make sense.

For the inner test of Inputted value you would need to convert the string value to a number before the case tests will work,

        MsgBox "You must enter your Employee Number!"
        sLogin = InputBox("Enter Employee Number here!")
        Select Case CLng(sLogin)

But if you enter 1 the first case test will be true so this code is executed.

        Select Case CLng(sLogin)
        Case 1
            If sLogin = "RS61" Then
                MsgBox "User has full READ/WRITE capabilities!"
                sLogin = True
            End If

Your problem now is that we already know sLogin contains "1" so it can not possible contain "RS61".

[Rick_Stanich]

I see, I misunderstood what "Case 1" represented. I thought it meant "Case 1" as the first event and "Case 2" as the second and so on.

Thanks!

[Stuie]

Yea no problem, easy mistake to make really

[royUK]

You don't need the If to test for blank entry statement either

Option Explicit
Option Compare Text
Sub logIn()
 Dim sLogin As String
 'not sure what you need this for. If it setting Caps Lock then use Option Compare Text
'    Dim CapsLock As New SetCapsClass
'
'    CapsLock.Value = True
    sLogin = InputBox("Enter Employee Number here!")
 
        Select Case sLogin
        Case vbNullString
        MsgBox "You must enter your employee number", vbCritical, "Input error"
        Case "RS61"
                MsgBox "User has full READ/WRITE capabilities!"
                sLogin = True
        Case "JE80"
                MsgBox "User has full READ/WRITE capabilities!"
                sLogin = True           
        Case "BC58"
                MsgBox "User has full READ/WRITE capabilities!"
                sLogin = True
        Case "BF56"
                MsgBox "User has full READ/WRITE capabilities!"
                sLogin = True
        Case Else
            MsgBox "User has WRITE capabilities ONLY!"
            sLogin = False
        End Select  
    End Sub

[Rick_Stanich]

One more question. :D

I now display a msgbox when the Case is true, how do I capture when it is not true? (and show a msgbox).

HAHA

You answered my question before I posted, how astute!

[Stuie]

not sure exactly what you mean do you mean to check if it is not a certain value like is not RS61.

can you explain a little more??

EDIT: Lol i was too late

[Rick_Stanich]

Case closed!

hehe

I kill me!