combining codes

Hi,

I wonder what seems to be wrong with this code, if i apply each code separately, it works but if i combine them, it doesn't...please help..thanks so much...

rivate Sub Worksheet_Change(ByVal Target As Range)
Dim i As Integer, j As Integer, x As Integer, y As Integer




i = Target.Row
j = Target.Column
x = Target.Row
y = Target.Column


If i > 15 Then
    If j = 9 Then
        If Cells(i, 9).Value = "Yes" Then
               Range("M" & i).Value = Date
    
    Else
        Range("M" & i).Value = ""
        End If
    End If
Else

If x > 15 Then
    If y = 7 Then
        If Cells(y, 7).Value = "Others" Then
               Range("K" & x).Value = "Marianne Elder"
    
    Else
        Range("K" & x).Value = " "
        
        End If
    End If
Else
End If
End If


End Sub

Hey,

I'm not quite sure what you are trying to do but have noticed some errors in your code that if you correct might help.

Firstly from the following code, i and x will be the same value and j and y will be there same value, therefore you don't need both sets of variables. Alternatively if they are ment to be different you would need to ammend your code.

i = Target.Row
j = Target.Column
x = Target.Row
y = Target.Column

From the above point it follows that the second set of calculations will never be called, since i=x.

Also I believe you have a typo in one line where you have writed i when you mean j.

If you midified the code as follows I think it may work.

Private Sub Worksheet_Change(ByVal Target As Range)
Dim i As Integer, j As Integer

i = Target.Row
j = Target.Column

If i > 15 Then
    If j = 9 Then
        If Cells(j, 9).Value = "Yes" Then
               Range("M" & i).Value = Date
        Else
               Range("M" & i).Value = ""
        End If
    ElseIf j = 7 Then
        If Cells(j, 7).Value = "Others" Then
               Range("K" & i).Value = "Marianne Elder"
        Else
               Range("K" & i).Value = " "
        End If
    End If
End If

End Sub

I haven't tested the above code and I'm not really sure what you are trying to achieve so it may not work, but it basically just changes all the x and y values to i and j values and ensures that the secon set of code will triggar.

Thanks for your response.

Here is what i am trying to do.

if column j = yes then automatically column m = current date

or

if column G = others then automatically column K = "Marianne Elder"

it doesn't follow that both condition must be satisfied...

thanks so much

Hey

I've made a slight change to the code I originally posted (the red bit). What the code should do (not tested if it doesn't work let me know) is check that the row number is greater than 15. If so it will then check if column I = "Yes" and if so put the date in column M and then it will check if column G = "Others" and if so put "Marianne Elder" in column K. The latter two tests are independant of each other which wasn't the case before

Private Sub Worksheet_Change(ByVal Target As Range)
Dim i As Integer, j As Integer

i = Target.Row
j = Target.Column

If i > 15 Then
    If j = 9 Then
        If Cells(j, 9).Value = "Yes" Then
               Range("M" & i).Value = Date
        Else
               Range("M" & i).Value = ""
        End If
    End If
    
    If j = 7 Then
        If Cells(j, 7).Value = "Others" Then
               Range("K" & i).Value = "Marianne Elder"
        Else
               Range("K" & i).Value = " "
        End If
    End If
End If

End Sub

Hope this helps and sorry for the delay in responding got sidetracked

LOL I guess she really didn't need any help.

I thought I saw a puddy cat , I did saw a puddy cat , I did.