Elseif Not IsNumber error

Good evening,

Having a little trouble with some code. I guess it won't work as I have it but I was wondering if anyone could recommend an easy way to do it. I don't want to write the code to verify each textbox separately. I was hoping to have it do a loop. Here is the code... It is the "Else if..." statement that generates the error. Thanks in advance for any help! dw

Sub test()
For i = 1 To 12
If Updateform.Controls("Textbox" & i).Value = "" Then
MsgBox ("You have to enter a value in each box.")
Exit Sub
ElseIf Not IsNumber(Updateform.Controls("Textbox" & i).Value ) Then
MsgBox ("Values entered have to be numeric.")
Exit Sub
End If
Next i
End Sub

HI

The result from a textbox will be text, so the test not isnumber will always be true.

If the number will always be > 0, then you could convert the text to a numbrer (val) and if it is > 0, then it would be numeric.


HTH

rylo

To answer the first question, yes the textboxes are on a userform. There are 12 of them and this code is to ensure that all of the required information is provided before it is posted to the sheets.

As to the second response, I don't think this is the problem. I could be wrong. I am still playing with it but it seems that if I don't use the "controls" feature, the elseif statement works. i.e.


Sub test()
If Updateform.Textbox1.Value = "" Then
MsgBox ("You have to enter a value in each box.")
Exit Sub
ElseIf Not IsNumber(Updateform.Textbox1.Value) Then
MsgBox ("Values entered have to be numeric.")
Exit Sub
End If
End Sub