+ Reply to Thread
Results 1 to 18 of 18

code question

Hybrid View

  1. #1
    Gary Keramidas
    Guest

    code question

    i have a routine i wrote to add a range to an exiting formula. it has 24
    formulas on 12 sheets hat need to be updated. the linked cells are an
    external workbook with a sheet called branch.

    the routine takes about a minute and a half to execute, but it will only
    execute when a new person is added, couple times a year.

    it is about 50 lines including the dims. is it appropriate to post it so i
    can ask someone if there is a more efficient way?

    thanks

    --


    Gary




  2. #2
    Gareth
    Guest

    Re: code question

    Go ahead and post it. I'm sure someone will be able to take it on.

    Gary Keramidas wrote:
    > i have a routine i wrote to add a range to an exiting formula. it has 24
    > formulas on 12 sheets hat need to be updated. the linked cells are an
    > external workbook with a sheet called branch.
    >
    > the routine takes about a minute and a half to execute, but it will only
    > execute when a new person is added, couple times a year.
    >
    > it is about 50 lines including the dims. is it appropriate to post it so i
    > can ask someone if there is a more efficient way?
    >
    > thanks
    >


  3. #3
    Gary Keramidas
    Guest

    Re: code question

    ok, here it is. i used an attachment to help with line breaks

    --


    Gary


    "Gareth" <msng@garhooREMOVEME.com> wrote in message
    news:O95zlGBjFHA.1480@TK2MSFTNGP10.phx.gbl...
    > Go ahead and post it. I'm sure someone will be able to take it on.
    >
    > Gary Keramidas wrote:
    >> i have a routine i wrote to add a range to an exiting formula. it has 24
    >> formulas on 12 sheets hat need to be updated. the linked cells are an
    >> external workbook with a sheet called branch.
    >>
    >> the routine takes about a minute and a half to execute, but it will only
    >> execute when a new person is added, couple times a year.
    >>
    >> it is about 50 lines including the dims. is it appropriate to post it so
    >> i
    >> can ask someone if there is a more efficient way?
    >>
    >> thanks
    >>





    Attached Files Attached Files

  4. #4
    Tim Williams
    Guest

    Re: code question

    Don't post attachments: no-one will read them. Paste the code into the
    message body - work on line breaks as required.

    Tim

    "Gary Keramidas" <GKeramidas@comcast.net> wrote in message
    news:%23A7fPKBjFHA.1416@TK2MSFTNGP09.phx.gbl...
    > ok, here it is. i used an attachment to help with line breaks
    >
    > --
    >
    >
    > Gary
    >
    >
    > "Gareth" <msng@garhooREMOVEME.com> wrote in message
    > news:O95zlGBjFHA.1480@TK2MSFTNGP10.phx.gbl...
    >> Go ahead and post it. I'm sure someone will be able to take it on.
    >>
    >> Gary Keramidas wrote:
    >>> i have a routine i wrote to add a range to an exiting formula. it
    >>> has 24
    >>> formulas on 12 sheets hat need to be updated. the linked cells are
    >>> an
    >>> external workbook with a sheet called branch.
    >>>
    >>> the routine takes about a minute and a half to execute, but it
    >>> will only
    >>> execute when a new person is added, couple times a year.
    >>>
    >>> it is about 50 lines including the dims. is it appropriate to post
    >>> it so i
    >>> can ask someone if there is a more efficient way?
    >>>
    >>> thanks
    >>>

    >
    >
    >




  5. #5
    Gary Keramidas
    Guest

    Re: code question

    ok

    Option Explicit
    Dim uName As String
    Dim rNum As Integer
    Dim mName As Integer
    Dim cnt As Integer
    Dim Counter As Integer

    Sub Add_User()

    Application.ScreenUpdating = False

    Counter = 1
    cnt = 1
    mName = 4
    uName = "New Name Here" ' enter new person's name (workbook name)
    rNum = 39 + mName ' starting row for data in new sheet (43)


    Do
    For Counter = 1 To 12 Step 1
    Sheets(mName).Select
    With Sheets(mName)
    ActiveSheet.Unprotect
    .Range("C5").Formula = .Range("c5").Formula & "+[" & uName &
    ".xls]Branch!$C$" & rNum & ""
    .Range("C6").Formula = .Range("c6").Formula & "+[" & uName &
    ".xls]Branch!$F$" & rNum & ""

    .Range("D5").Formula = .Range("D5").Formula & "+[" & uName &
    ".xls]Branch!$D$" & rNum & ""
    .Range("D6").Formula = .Range("D6").Formula & "+[" & uName &
    ".xls]Branch!$G$" & rNum & ""

    .Range("E5").Formula = .Range("E5").Formula & "+[" & uName &
    ".xls]Branch!$H$" & rNum & ""
    .Range("E6").Formula = .Range("E6").Formula & "+[" & uName &
    ".xls]Branch!$I$" & rNum & ""

    rNum = rNum + 14
    .Range("C7").Formula = .Range("c7").Formula & "+[" & uName &
    ".xls]Branch!$C$" & rNum & ""
    .Range("C8").Formula = .Range("c8").Formula & "+[" & uName &
    ".xls]Branch!$F$" & rNum & ""

    .Range("D7").Formula = .Range("D7").Formula & "+[" & uName &
    ".xls]Branch!$D$" & rNum & ""
    .Range("D8").Formula = .Range("D8").Formula & "+[" & uName &
    ".xls]Branch!$G$" & rNum & ""

    .Range("E7").Formula = .Range("E7").Formula & "+[" & uName &
    ".xls]Branch!$H$" & rNum & ""
    .Range("E8").Formula = .Range("E8").Formula & "+[" & uName &
    ".xls]Branch!$I$" & rNum & ""

    rNum = rNum + 14
    .Range("C9").Formula = .Range("c9").Formula & "+[" & uName &
    ".xls]Branch!$C$" & rNum & ""
    .Range("C10").Formula = .Range("c10").Formula & "+[" & uName &
    ".xls]Branch!$F$" & rNum & ""

    .Range("D9").Formula = .Range("D9").Formula & "+[" & uName &
    ".xls]Branch!$D$" & rNum & ""
    .Range("D10").Formula = .Range("D10").Formula & "+[" & uName &
    ".xls]Branch!$G$" & rNum & ""

    .Range("E9").Formula = .Range("E9").Formula & "+[" & uName &
    ".xls]Branch!$H$" & rNum & ""
    .Range("E10").Formula = .Range("E10").Formula & "+[" & uName &
    ".xls]Branch!$I$" & rNum & ""


    rNum = rNum + 14
    .Range("C11").Formula = .Range("c11").Formula & "+[" & uName &
    ".xls]Branch!$C$" & rNum & ""
    .Range("C12").Formula = .Range("c12").Formula & "+[" & uName &
    ".xls]Branch!$F$" & rNum & ""

    .Range("D11").Formula = .Range("D11").Formula & "+[" & uName &
    ".xls]Branch!$D$" & rNum & ""
    .Range("D12").Formula = .Range("D12").Formula & "+[" & uName &
    ".xls]Branch!$G$" & rNum & ""

    .Range("E11").Formula = .Range("E11").Formula & "+[" & uName &
    ".xls]Branch!$H$" & rNum & ""
    .Range("E12").Formula = .Range("E12").Formula & "+[" & uName &
    ".xls]Branch!$I$" & rNum & ""


    End With
    mName = mName + 1
    rNum = 39 + mName
    ActiveSheet.Protect
    Next Counter
    Exit Do
    Loop
    Application.ScreenUpdating = True
    MsgBox "Done"
    End Sub

    --


    Gary


    "Tim Williams" <saxifrax@pacbell*dot*net> wrote in message
    news:OT3VbVBjFHA.2444@tk2msftngp13.phx.gbl...
    > Don't post attachments: no-one will read them. Paste the code into the
    > message body - work on line breaks as required.
    >
    > Tim
    >
    > "Gary Keramidas" <GKeramidas@comcast.net> wrote in message
    > news:%23A7fPKBjFHA.1416@TK2MSFTNGP09.phx.gbl...
    >> ok, here it is. i used an attachment to help with line breaks
    >>
    >> --
    >>
    >>
    >> Gary
    >>
    >>
    >> "Gareth" <msng@garhooREMOVEME.com> wrote in message
    >> news:O95zlGBjFHA.1480@TK2MSFTNGP10.phx.gbl...
    >>> Go ahead and post it. I'm sure someone will be able to take it on.
    >>>
    >>> Gary Keramidas wrote:
    >>>> i have a routine i wrote to add a range to an exiting formula. it has
    >>>> 24
    >>>> formulas on 12 sheets hat need to be updated. the linked cells are an
    >>>> external workbook with a sheet called branch.
    >>>>
    >>>> the routine takes about a minute and a half to execute, but it will
    >>>> only
    >>>> execute when a new person is added, couple times a year.
    >>>>
    >>>> it is about 50 lines including the dims. is it appropriate to post it
    >>>> so i
    >>>> can ask someone if there is a more efficient way?
    >>>>
    >>>> thanks
    >>>>

    >>
    >>
    >>

    >
    >




  6. #6
    Norman Jones
    Guest

    Re: code question

    Hi Gary,

    Independently of your code, I would suggest that you expand the ScreenUpdate
    wrapper to include calculation and (while you are at it) also include
    pagebreak displays. somehing like:

    Dim CalcMode As Long
    Dim PgBreakMode As Boolean

    With Application
    CalcMode = .Calculation
    .Calculation = xlCalculationManual
    .ScreenUpdating = False
    End With

    With ActiveSheet
    PgBreakMode = .DisplayPageBreaks
    .DisplayPageBreaks = False
    End With


    ' Your code



    With Application
    .Calculation = CalcMode
    .ScreenUpdating = True
    End With

    ActiveSheet.DisplayPageBreaks = PgBreakMode

    End Sub

    ---
    Regards,
    Norman



  7. #7
    Bob Phillips
    Guest

    Re: code question

    Seems odd it should take so long, so we are dealing with small improvements
    here, but here are a couple more.

    The Do loop seems totally superfluous, so remove the lines

    Do
    Exit Do
    Loop

    As you only deal with one sheet, no need to select it each loop, and the
    With reference can be outside the Loop

    With Sheets(mName)
    For Counter = 1 To 12 Step 1
    .Unprotect

    'main code

    mName = mName + 1
    rNum = 39 + mName
    ActiveSheet.Protect
    Next Counter

    End With

    --
    HTH

    Bob Phillips

    "Gary Keramidas" <GKeramidas@comcast.net> wrote in message
    news:urpY3ZBjFHA.3784@tk2msftngp13.phx.gbl...
    > ok
    >
    > Option Explicit
    > Dim uName As String
    > Dim rNum As Integer
    > Dim mName As Integer
    > Dim cnt As Integer
    > Dim Counter As Integer
    >
    > Sub Add_User()
    >
    > Application.ScreenUpdating = False
    >
    > Counter = 1
    > cnt = 1
    > mName = 4
    > uName = "New Name Here" ' enter new person's name (workbook name)
    > rNum = 39 + mName ' starting row for data in new sheet (43)
    >
    >
    > Do
    > For Counter = 1 To 12 Step 1
    > Sheets(mName).Select
    > With Sheets(mName)
    > ActiveSheet.Unprotect
    > .Range("C5").Formula = .Range("c5").Formula & "+[" & uName &
    > ".xls]Branch!$C$" & rNum & ""
    > .Range("C6").Formula = .Range("c6").Formula & "+[" & uName &
    > ".xls]Branch!$F$" & rNum & ""
    >
    > .Range("D5").Formula = .Range("D5").Formula & "+[" & uName &
    > ".xls]Branch!$D$" & rNum & ""
    > .Range("D6").Formula = .Range("D6").Formula & "+[" & uName &
    > ".xls]Branch!$G$" & rNum & ""
    >
    > .Range("E5").Formula = .Range("E5").Formula & "+[" & uName &
    > ".xls]Branch!$H$" & rNum & ""
    > .Range("E6").Formula = .Range("E6").Formula & "+[" & uName &
    > ".xls]Branch!$I$" & rNum & ""
    >
    > rNum = rNum + 14
    > .Range("C7").Formula = .Range("c7").Formula & "+[" & uName &
    > ".xls]Branch!$C$" & rNum & ""
    > .Range("C8").Formula = .Range("c8").Formula & "+[" & uName &
    > ".xls]Branch!$F$" & rNum & ""
    >
    > .Range("D7").Formula = .Range("D7").Formula & "+[" & uName &
    > ".xls]Branch!$D$" & rNum & ""
    > .Range("D8").Formula = .Range("D8").Formula & "+[" & uName &
    > ".xls]Branch!$G$" & rNum & ""
    >
    > .Range("E7").Formula = .Range("E7").Formula & "+[" & uName &
    > ".xls]Branch!$H$" & rNum & ""
    > .Range("E8").Formula = .Range("E8").Formula & "+[" & uName &
    > ".xls]Branch!$I$" & rNum & ""
    >
    > rNum = rNum + 14
    > .Range("C9").Formula = .Range("c9").Formula & "+[" & uName &
    > ".xls]Branch!$C$" & rNum & ""
    > .Range("C10").Formula = .Range("c10").Formula & "+[" & uName &
    > ".xls]Branch!$F$" & rNum & ""
    >
    > .Range("D9").Formula = .Range("D9").Formula & "+[" & uName &
    > ".xls]Branch!$D$" & rNum & ""
    > .Range("D10").Formula = .Range("D10").Formula & "+[" & uName &
    > ".xls]Branch!$G$" & rNum & ""
    >
    > .Range("E9").Formula = .Range("E9").Formula & "+[" & uName &
    > ".xls]Branch!$H$" & rNum & ""
    > .Range("E10").Formula = .Range("E10").Formula & "+[" & uName &
    > ".xls]Branch!$I$" & rNum & ""
    >
    >
    > rNum = rNum + 14
    > .Range("C11").Formula = .Range("c11").Formula & "+[" & uName &
    > ".xls]Branch!$C$" & rNum & ""
    > .Range("C12").Formula = .Range("c12").Formula & "+[" & uName &
    > ".xls]Branch!$F$" & rNum & ""
    >
    > .Range("D11").Formula = .Range("D11").Formula & "+[" & uName &
    > ".xls]Branch!$D$" & rNum & ""
    > .Range("D12").Formula = .Range("D12").Formula & "+[" & uName &
    > ".xls]Branch!$G$" & rNum & ""
    >
    > .Range("E11").Formula = .Range("E11").Formula & "+[" & uName &
    > ".xls]Branch!$H$" & rNum & ""
    > .Range("E12").Formula = .Range("E12").Formula & "+[" & uName &
    > ".xls]Branch!$I$" & rNum & ""
    >
    >
    > End With
    > mName = mName + 1
    > rNum = 39 + mName
    > ActiveSheet.Protect
    > Next Counter
    > Exit Do
    > Loop
    > Application.ScreenUpdating = True
    > MsgBox "Done"
    > End Sub
    >
    > --
    >
    >
    > Gary
    >
    >
    > "Tim Williams" <saxifrax@pacbell*dot*net> wrote in message
    > news:OT3VbVBjFHA.2444@tk2msftngp13.phx.gbl...
    > > Don't post attachments: no-one will read them. Paste the code into the
    > > message body - work on line breaks as required.
    > >
    > > Tim
    > >
    > > "Gary Keramidas" <GKeramidas@comcast.net> wrote in message
    > > news:%23A7fPKBjFHA.1416@TK2MSFTNGP09.phx.gbl...
    > >> ok, here it is. i used an attachment to help with line breaks
    > >>
    > >> --
    > >>
    > >>
    > >> Gary
    > >>
    > >>
    > >> "Gareth" <msng@garhooREMOVEME.com> wrote in message
    > >> news:O95zlGBjFHA.1480@TK2MSFTNGP10.phx.gbl...
    > >>> Go ahead and post it. I'm sure someone will be able to take it on.
    > >>>
    > >>> Gary Keramidas wrote:
    > >>>> i have a routine i wrote to add a range to an exiting formula. it has
    > >>>> 24
    > >>>> formulas on 12 sheets hat need to be updated. the linked cells are an
    > >>>> external workbook with a sheet called branch.
    > >>>>
    > >>>> the routine takes about a minute and a half to execute, but it will
    > >>>> only
    > >>>> execute when a new person is added, couple times a year.
    > >>>>
    > >>>> it is about 50 lines including the dims. is it appropriate to post it
    > >>>> so i
    > >>>> can ask someone if there is a more efficient way?
    > >>>>
    > >>>> thanks
    > >>>>
    > >>
    > >>
    > >>

    > >
    > >

    >
    >




  8. #8
    Bob Phillips
    Guest

    Re: code question

    Looked at it some more and the loop is also unnecessary. Just use an Excel
    formula that sums

    Sub Add_User()

    With Application
    CalcMode = .Calculation
    .Calculation = xlCalculationManual
    .ScreenUpdating = False
    End With

    With ActiveSheet
    PgBreakMode = .DisplayPageBreaks
    .DisplayPageBreaks = False
    End With

    cnt = 1
    mName = 4
    uName = "Bob" ' enter new person's name (workbook name)
    Rnum = 39 + mName ' starting row for data in new sheet (43)

    With Sheets(mName)
    .Unprotect
    .Range("C5").Formula = .Range("C5").Formula & _
    "+SUM([" & uName & ".xls]Branch!$C$" & Rnum & ":$C$" & Rnum + 11
    & ")"
    .Range("C6").Formula = .Range("C6").Formula & _
    "+SUM([" & uName & ".xls]Branch!$F$" & Rnum & ":$F$" & Rnum + 11
    & ")"

    .Range("D5").Formula = .Range("D5").Formula & _
    "+SUM([" & uName & ".xls]Branch!$D$" & Rnum & ":$D$" & Rnum + 11
    & ")"
    .Range("D6").Formula = .Range("D6").Formula & _
    "+SUM([" & uName & ".xls]Branch!$G$" & Rnum & ":$G$" & Rnum + 11
    & ")"

    .Range("E5").Formula = .Range("E5").Formula & _
    "+SUM([" & uName & ".xls]Branch!$H$" & Rnum & ":$E$" & Rnum + 11
    & ")"
    .Range("E6").Formula = .Range("E6").Formula & _
    "+SUM([" & uName & ".xls]Branch!$I$" & Rnum & ":$I$" & Rnum + 11
    & ")"

    Rnum = Rnum + 14
    .Range("C7").Formula = .Range("c7").Formula & _
    "+SUM([" & uName & ".xls]Branch!$C$" & Rnum & ":$C$" & Rnum + 11
    & ")"
    .Range("C8").Formula = .Range("c8").Formula & _
    "+SUM([" & uName & ".xls]Branch!$F$" & Rnum & ":$F$" & Rnum + 11
    & ")"

    .Range("D7").Formula = .Range("D7").Formula & _
    "+SUM([" & uName & ".xls]Branch!$D$" & Rnum & ":$D$" & Rnum + 11
    & ")"
    .Range("D8").Formula = .Range("D8").Formula & _
    "+SUM([" & uName & ".xls]Branch!$G$" & Rnum & ":$G$" & Rnum + 11
    & ")"

    .Range("E7").Formula = .Range("E7").Formula & _
    "+SUM([" & uName & ".xls]Branch!$H$" & Rnum & ":$E$" & Rnum + 11
    & ")"
    .Range("E8").Formula = .Range("E8").Formula & _
    "+SUM([" & uName & ".xls]Branch!$I$" & Rnum & ":$I$" & Rnum + 11
    & ")"

    Rnum = Rnum + 14
    .Range("C9").Formula = .Range("c9").Formula & _
    "+SUM([" & uName & ".xls]Branch!$C$" & Rnum & ":$C$" & Rnum + 11
    & ")"
    .Range("C10").Formula = .Range("c10").Formula & _
    "+SUM([" & uName & ".xls]Branch!$F$" & Rnum & ":$F$" & Rnum + 11
    & ")"

    .Range("D9").Formula = .Range("D9").Formula & _
    "+SUM([" & uName & ".xls]Branch!$D$" & Rnum & ":$D$" & Rnum + 11
    & ")"
    .Range("D10").Formula = .Range("D10").Formula & _
    "+SUM([" & uName & ".xls]Branch!$G$" & Rnum & ":$G$" & Rnum + 11
    & ")"

    .Range("E9").Formula = .Range("E9").Formula & _
    "+SUM([" & uName & ".xls]Branch!$H$" & Rnum & ":$E$" & Rnum + 11
    & ")"
    .Range("E10").Formula = .Range("E10").Formula & _
    "+SUM([" & uName & ".xls]Branch!$I$" & Rnum & ":$I$" & Rnum + 11
    & ")"

    Rnum = Rnum + 14
    .Range("C11").Formula = .Range("C11").Formula & _
    "+SUM([" & uName & ".xls]Branch!$C$" & Rnum & ":$C$" & Rnum + 11
    & ")"
    .Range("C12").Formula = .Range("C12").Formula & _
    "+SUM([" & uName & ".xls]Branch!$F$" & Rnum & ":$F$" & Rnum + 11
    & ")"

    .Range("D11").Formula = .Range("D11").Formula & _
    "+SUM([" & uName & ".xls]Branch!$D$" & Rnum & ":$D$" & Rnum + 11
    & ")"
    .Range("D12").Formula = .Range("D12").Formula & _
    "+SUM([" & uName & ".xls]Branch!$G$" & Rnum & ":$G$" & Rnum + 11
    & ")"

    .Range("E11").Formula = .Range("E11").Formula & _
    "+SUM([" & uName & ".xls]Branch!$H$" & Rnum & ":$H$" & Rnum + 11
    & ")"
    .Range("E12").Formula = .Range("E12").Formula & _
    "+SUM([" & uName & ".xls]Branch!$I$" & Rnum & ":$I$" & Rnum + 11
    & ")"

    mName = mName + 1
    Rnum = 39 + mName
    .Protect
    End With

    With Application
    CalcMode = .Calculation
    .Calculation = xlCalculationAutomatic
    .ScreenUpdating = True
    End With

    MsgBox "Done"

    End Sub


    --
    HTH

    Bob Phillips

    "Gary Keramidas" <GKeramidas@comcast.net> wrote in message
    news:urpY3ZBjFHA.3784@tk2msftngp13.phx.gbl...
    > ok
    >
    > Option Explicit
    > Dim uName As String
    > Dim rNum As Integer
    > Dim mName As Integer
    > Dim cnt As Integer
    > Dim Counter As Integer
    >
    > Sub Add_User()
    >
    > Application.ScreenUpdating = False
    >
    > Counter = 1
    > cnt = 1
    > mName = 4
    > uName = "New Name Here" ' enter new person's name (workbook name)
    > rNum = 39 + mName ' starting row for data in new sheet (43)
    >
    >
    > Do
    > For Counter = 1 To 12 Step 1
    > Sheets(mName).Select
    > With Sheets(mName)
    > ActiveSheet.Unprotect
    > .Range("C5").Formula = .Range("c5").Formula & "+[" & uName &
    > ".xls]Branch!$C$" & rNum & ""
    > .Range("C6").Formula = .Range("c6").Formula & "+[" & uName &
    > ".xls]Branch!$F$" & rNum & ""
    >
    > .Range("D5").Formula = .Range("D5").Formula & "+[" & uName &
    > ".xls]Branch!$D$" & rNum & ""
    > .Range("D6").Formula = .Range("D6").Formula & "+[" & uName &
    > ".xls]Branch!$G$" & rNum & ""
    >
    > .Range("E5").Formula = .Range("E5").Formula & "+[" & uName &
    > ".xls]Branch!$H$" & rNum & ""
    > .Range("E6").Formula = .Range("E6").Formula & "+[" & uName &
    > ".xls]Branch!$I$" & rNum & ""
    >
    > rNum = rNum + 14
    > .Range("C7").Formula = .Range("c7").Formula & "+[" & uName &
    > ".xls]Branch!$C$" & rNum & ""
    > .Range("C8").Formula = .Range("c8").Formula & "+[" & uName &
    > ".xls]Branch!$F$" & rNum & ""
    >
    > .Range("D7").Formula = .Range("D7").Formula & "+[" & uName &
    > ".xls]Branch!$D$" & rNum & ""
    > .Range("D8").Formula = .Range("D8").Formula & "+[" & uName &
    > ".xls]Branch!$G$" & rNum & ""
    >
    > .Range("E7").Formula = .Range("E7").Formula & "+[" & uName &
    > ".xls]Branch!$H$" & rNum & ""
    > .Range("E8").Formula = .Range("E8").Formula & "+[" & uName &
    > ".xls]Branch!$I$" & rNum & ""
    >
    > rNum = rNum + 14
    > .Range("C9").Formula = .Range("c9").Formula & "+[" & uName &
    > ".xls]Branch!$C$" & rNum & ""
    > .Range("C10").Formula = .Range("c10").Formula & "+[" & uName &
    > ".xls]Branch!$F$" & rNum & ""
    >
    > .Range("D9").Formula = .Range("D9").Formula & "+[" & uName &
    > ".xls]Branch!$D$" & rNum & ""
    > .Range("D10").Formula = .Range("D10").Formula & "+[" & uName &
    > ".xls]Branch!$G$" & rNum & ""
    >
    > .Range("E9").Formula = .Range("E9").Formula & "+[" & uName &
    > ".xls]Branch!$H$" & rNum & ""
    > .Range("E10").Formula = .Range("E10").Formula & "+[" & uName &
    > ".xls]Branch!$I$" & rNum & ""
    >
    >
    > rNum = rNum + 14
    > .Range("C11").Formula = .Range("c11").Formula & "+[" & uName &
    > ".xls]Branch!$C$" & rNum & ""
    > .Range("C12").Formula = .Range("c12").Formula & "+[" & uName &
    > ".xls]Branch!$F$" & rNum & ""
    >
    > .Range("D11").Formula = .Range("D11").Formula & "+[" & uName &
    > ".xls]Branch!$D$" & rNum & ""
    > .Range("D12").Formula = .Range("D12").Formula & "+[" & uName &
    > ".xls]Branch!$G$" & rNum & ""
    >
    > .Range("E11").Formula = .Range("E11").Formula & "+[" & uName &
    > ".xls]Branch!$H$" & rNum & ""
    > .Range("E12").Formula = .Range("E12").Formula & "+[" & uName &
    > ".xls]Branch!$I$" & rNum & ""
    >
    >
    > End With
    > mName = mName + 1
    > rNum = 39 + mName
    > ActiveSheet.Protect
    > Next Counter
    > Exit Do
    > Loop
    > Application.ScreenUpdating = True
    > MsgBox "Done"
    > End Sub
    >
    > --
    >
    >
    > Gary
    >
    >
    > "Tim Williams" <saxifrax@pacbell*dot*net> wrote in message
    > news:OT3VbVBjFHA.2444@tk2msftngp13.phx.gbl...
    > > Don't post attachments: no-one will read them. Paste the code into the
    > > message body - work on line breaks as required.
    > >
    > > Tim
    > >
    > > "Gary Keramidas" <GKeramidas@comcast.net> wrote in message
    > > news:%23A7fPKBjFHA.1416@TK2MSFTNGP09.phx.gbl...
    > >> ok, here it is. i used an attachment to help with line breaks
    > >>
    > >> --
    > >>
    > >>
    > >> Gary
    > >>
    > >>
    > >> "Gareth" <msng@garhooREMOVEME.com> wrote in message
    > >> news:O95zlGBjFHA.1480@TK2MSFTNGP10.phx.gbl...
    > >>> Go ahead and post it. I'm sure someone will be able to take it on.
    > >>>
    > >>> Gary Keramidas wrote:
    > >>>> i have a routine i wrote to add a range to an exiting formula. it has
    > >>>> 24
    > >>>> formulas on 12 sheets hat need to be updated. the linked cells are an
    > >>>> external workbook with a sheet called branch.
    > >>>>
    > >>>> the routine takes about a minute and a half to execute, but it will
    > >>>> only
    > >>>> execute when a new person is added, couple times a year.
    > >>>>
    > >>>> it is about 50 lines including the dims. is it appropriate to post it
    > >>>> so i
    > >>>> can ask someone if there is a more efficient way?
    > >>>>
    > >>>> thanks
    > >>>>
    > >>
    > >>
    > >>

    > >
    > >

    >
    >




  9. #9
    Tim Williams
    Guest

    Re: code question

    Yes, OK to post the code.

    Tim


    "Gary Keramidas" <GKeramidas@comcast.net> wrote in message
    news:eZaXLIAjFHA.3064@TK2MSFTNGP15.phx.gbl...
    >i have a routine i wrote to add a range to an exiting formula. it has
    >24 formulas on 12 sheets hat need to be updated. the linked cells are
    >an external workbook with a sheet called branch.
    >
    > the routine takes about a minute and a half to execute, but it will
    > only execute when a new person is added, couple times a year.
    >
    > it is about 50 lines including the dims. is it appropriate to post
    > it so i can ask someone if there is a more efficient way?
    >
    > thanks
    >
    > --
    >
    >
    > Gary
    >
    >
    >




+ Reply to Thread

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Search Engine Friendly URLs by vBSEO 3.6.0 RC 1