End if w/o if?

I've combined 2 macros that I got help writing here.
Sub AllSheetsToggleProtectWInd()
'for all sheets in currently active workbook, assigned to button
Dim TopCell As Range
Dim TopCol As Range
Dim Cols2Hide As Range
Dim wkSht As Worksheet

For Each wkSht In ActiveWorkbook.Worksheets
With wkSht
If .ProtectContents Then
.Unprotect Password:=PWORD
.Name = .Name & "##"
.Columns.Hidden = False
Else
Set TopCell = .Rows(3).Find(What:="top",
LookIn:=xlValues)
If Not TopCell Is Nothing Then ' if it found "top"
Set TopCol = .Columns(TopCell.Column)
Set Cols2Hide = .Range(TopCol, .Columns("AC"))
Cols2Hide.Hidden = True
.Protect Password:=PWORD
If .Name Like "*[##]" Then _
.Name = Left(.Name, Len(.Name) - 2)

End If
End With<-----[end with without with error]

Next wkSht

End Sub


But when I run it, I get an error of "End with without if", even though
there's very clearly a "with wksht" statement at the top. If I remark
out the End with, I get a "Next without For" error, even though there's
a "For" statement. So any ideas on why VBA can't see my with or For
each statements?
Thanks in advance.

Hi,

If .Name Like "*[##]" Then _
.Name = Left(.Name, Len(.Name) - 2)
End If ...... Missing here

HTh

"davegb" wrote:

> I've combined 2 macros that I got help writing here.
> Sub AllSheetsToggleProtectWInd()
> 'for all sheets in currently active workbook, assigned to button
> Dim TopCell As Range
> Dim TopCol As Range
> Dim Cols2Hide As Range
> Dim wkSht As Worksheet
>
> For Each wkSht In ActiveWorkbook.Worksheets
> With wkSht
> If .ProtectContents Then
> .Unprotect Password:=PWORD
> .Name = .Name & "##"
> .Columns.Hidden = False
> Else
> Set TopCell = .Rows(3).Find(What:="top",
> LookIn:=xlValues)
> If Not TopCell Is Nothing Then ' if it found "top"
> Set TopCol = .Columns(TopCell.Column)
> Set Cols2Hide = .Range(TopCol, .Columns("AC"))
> Cols2Hide.Hidden = True
> .Protect Password:=PWORD
> If .Name Like "*[##]" Then _
> .Name = Left(.Name, Len(.Name) - 2)
>
> End If
> End With<-----[end with without with error]
>
> Next wkSht
>
> End Sub
>
>
> But when I run it, I get an error of "End with without if", even though
> there's very clearly a "with wksht" statement at the top. If I remark
> out the End with, I get a "Next without For" error, even though there's
> a "For" statement. So any ideas on why VBA can't see my with or For
> each statements?
> Thanks in advance.
>
>

No, he has a line continuation, so no End If needed.

--
HTH

Bob Phillips

"Toppers" <Toppers@discussions.microsoft.com> wrote in message
news:26927AED-559E-4246-84E6-1D32263FAB3B@microsoft.com...
> Hi,
>
> If .Name Like "*[##]" Then _
> .Name = Left(.Name, Len(.Name) - 2)
> End If ...... Missing here
>
> HTh
>
> "davegb" wrote:
>
> > I've combined 2 macros that I got help writing here.
> > Sub AllSheetsToggleProtectWInd()
> > 'for all sheets in currently active workbook, assigned to button
> > Dim TopCell As Range
> > Dim TopCol As Range
> > Dim Cols2Hide As Range
> > Dim wkSht As Worksheet
> >
> > For Each wkSht In ActiveWorkbook.Worksheets
> > With wkSht
> > If .ProtectContents Then
> > .Unprotect Password:=PWORD
> > .Name = .Name & "##"
> > .Columns.Hidden = False
> > Else
> > Set TopCell = .Rows(3).Find(What:="top",
> > LookIn:=xlValues)
> > If Not TopCell Is Nothing Then ' if it found "top"
> > Set TopCol = .Columns(TopCell.Column)
> > Set Cols2Hide = .Range(TopCol, .Columns("AC"))
> > Cols2Hide.Hidden = True
> > .Protect Password:=PWORD
> > If .Name Like "*[##]" Then _
> > .Name = Left(.Name, Len(.Name) - 2)
> >
> > End If
> > End With<-----[end with without with error]
> >
> > Next wkSht
> >
> > End Sub
> >
> >
> > But when I run it, I get an error of "End with without if", even though
> > there's very clearly a "with wksht" statement at the top. If I remark
> > out the End with, I get a "Next without For" error, even though there's
> > a "For" statement. So any ideas on why VBA can't see my with or For
> > each statements?
> > Thanks in advance.
> >
> >

But it could be End If to If Not TopCell Is Nothing which admittedly could
come before If .name as per Don's reply. Both are valid I think.

"Bob Phillips" wrote:

> No, he has a line continuation, so no End If needed.
>
> --
> HTH
>
> Bob Phillips
>
> "Toppers" <Toppers@discussions.microsoft.com> wrote in message
> news:26927AED-559E-4246-84E6-1D32263FAB3B@microsoft.com...
> > Hi,
> >
> > If .Name Like "*[##]" Then _
> > .Name = Left(.Name, Len(.Name) - 2)
> > End If ...... Missing here
> >
> > HTh
> >
> > "davegb" wrote:
> >
> > > I've combined 2 macros that I got help writing here.
> > > Sub AllSheetsToggleProtectWInd()
> > > 'for all sheets in currently active workbook, assigned to button
> > > Dim TopCell As Range
> > > Dim TopCol As Range
> > > Dim Cols2Hide As Range
> > > Dim wkSht As Worksheet
> > >
> > > For Each wkSht In ActiveWorkbook.Worksheets
> > > With wkSht
> > > If .ProtectContents Then
> > > .Unprotect Password:=PWORD
> > > .Name = .Name & "##"
> > > .Columns.Hidden = False
> > > Else
> > > Set TopCell = .Rows(3).Find(What:="top",
> > > LookIn:=xlValues)
> > > If Not TopCell Is Nothing Then ' if it found "top"
> > > Set TopCol = .Columns(TopCell.Column)
> > > Set Cols2Hide = .Range(TopCol, .Columns("AC"))
> > > Cols2Hide.Hidden = True
> > > .Protect Password:=PWORD
> > > If .Name Like "*[##]" Then _
> > > .Name = Left(.Name, Len(.Name) - 2)
> > >
> > > End If
> > > End With<-----[end with without with error]
> > >
> > > Next wkSht
> > >
> > > End Sub
> > >
> > >
> > > But when I run it, I get an error of "End with without if", even though
> > > there's very clearly a "with wksht" statement at the top. If I remark
> > > out the End with, I get a "Next without For" error, even though there's
> > > a "For" statement. So any ideas on why VBA can't see my with or For
> > > each statements?
> > > Thanks in advance.
> > >
> > >
>
>
>

I see your point. As I say, you should indent Ifs, and don't use single line
Ifs, it all gets too confusing.

Bob

"Toppers" <Toppers@discussions.microsoft.com> wrote in message
news:576C31D0-B553-4F68-BC1A-B50EA74828F7@microsoft.com...
> But it could be End If to If Not TopCell Is Nothing which admittedly
could
> come before If .name as per Don's reply. Both are valid I think.
>
> "Bob Phillips" wrote:
>
> > No, he has a line continuation, so no End If needed.
> >
> > --
> > HTH
> >
> > Bob Phillips
> >
> > "Toppers" <Toppers@discussions.microsoft.com> wrote in message
> > news:26927AED-559E-4246-84E6-1D32263FAB3B@microsoft.com...
> > > Hi,
> > >
> > > If .Name Like "*[##]" Then _
> > > .Name = Left(.Name, Len(.Name) - 2)
> > > End If ...... Missing here
> > >
> > > HTh
> > >
> > > "davegb" wrote:
> > >
> > > > I've combined 2 macros that I got help writing here.
> > > > Sub AllSheetsToggleProtectWInd()
> > > > 'for all sheets in currently active workbook, assigned to button
> > > > Dim TopCell As Range
> > > > Dim TopCol As Range
> > > > Dim Cols2Hide As Range
> > > > Dim wkSht As Worksheet
> > > >
> > > > For Each wkSht In ActiveWorkbook.Worksheets
> > > > With wkSht
> > > > If .ProtectContents Then
> > > > .Unprotect Password:=PWORD
> > > > .Name = .Name & "##"
> > > > .Columns.Hidden = False
> > > > Else
> > > > Set TopCell = .Rows(3).Find(What:="top",
> > > > LookIn:=xlValues)
> > > > If Not TopCell Is Nothing Then ' if it found "top"
> > > > Set TopCol = .Columns(TopCell.Column)
> > > > Set Cols2Hide = .Range(TopCol, .Columns("AC"))
> > > > Cols2Hide.Hidden = True
> > > > .Protect Password:=PWORD
> > > > If .Name Like "*[##]" Then _
> > > > .Name = Left(.Name, Len(.Name) - 2)
> > > >
> > > > End If
> > > > End With<-----[end with without with error]
> > > >
> > > > Next wkSht
> > > >
> > > > End Sub
> > > >
> > > >
> > > > But when I run it, I get an error of "End with without if", even
though
> > > > there's very clearly a "with wksht" statement at the top. If I
remark
> > > > out the End with, I get a "Next without For" error, even though
there's
> > > > a "For" statement. So any ideas on why VBA can't see my with or For
> > > > each statements?
> > > > Thanks in advance.
> > > >
> > > >
> >
> >
> >

Agreed!

"Bob Phillips" wrote:

> I see your point. As I say, you should indent Ifs, and don't use single line
> Ifs, it all gets too confusing.
>
> Bob
>
> "Toppers" <Toppers@discussions.microsoft.com> wrote in message
> news:576C31D0-B553-4F68-BC1A-B50EA74828F7@microsoft.com...
> > But it could be End If to If Not TopCell Is Nothing which admittedly
> could
> > come before If .name as per Don's reply. Both are valid I think.
> >
> > "Bob Phillips" wrote:
> >
> > > No, he has a line continuation, so no End If needed.
> > >
> > > --
> > > HTH
> > >
> > > Bob Phillips
> > >
> > > "Toppers" <Toppers@discussions.microsoft.com> wrote in message
> > > news:26927AED-559E-4246-84E6-1D32263FAB3B@microsoft.com...
> > > > Hi,
> > > >
> > > > If .Name Like "*[##]" Then _
> > > > .Name = Left(.Name, Len(.Name) - 2)
> > > > End If ...... Missing here
> > > >
> > > > HTh
> > > >
> > > > "davegb" wrote:
> > > >
> > > > > I've combined 2 macros that I got help writing here.
> > > > > Sub AllSheetsToggleProtectWInd()
> > > > > 'for all sheets in currently active workbook, assigned to button
> > > > > Dim TopCell As Range
> > > > > Dim TopCol As Range
> > > > > Dim Cols2Hide As Range
> > > > > Dim wkSht As Worksheet
> > > > >
> > > > > For Each wkSht In ActiveWorkbook.Worksheets
> > > > > With wkSht
> > > > > If .ProtectContents Then
> > > > > .Unprotect Password:=PWORD
> > > > > .Name = .Name & "##"
> > > > > .Columns.Hidden = False
> > > > > Else
> > > > > Set TopCell = .Rows(3).Find(What:="top",
> > > > > LookIn:=xlValues)
> > > > > If Not TopCell Is Nothing Then ' if it found "top"
> > > > > Set TopCol = .Columns(TopCell.Column)
> > > > > Set Cols2Hide = .Range(TopCol, .Columns("AC"))
> > > > > Cols2Hide.Hidden = True
> > > > > .Protect Password:=PWORD
> > > > > If .Name Like "*[##]" Then _
> > > > > .Name = Left(.Name, Len(.Name) - 2)
> > > > >
> > > > > End If
> > > > > End With<-----[end with without with error]
> > > > >
> > > > > Next wkSht
> > > > >
> > > > > End Sub
> > > > >
> > > > >
> > > > > But when I run it, I get an error of "End with without if", even
> though
> > > > > there's very clearly a "with wksht" statement at the top. If I
> remark
> > > > > out the End with, I get a "Next without For" error, even though
> there's
> > > > > a "For" statement. So any ideas on why VBA can't see my with or For
> > > > > each statements?
> > > > > Thanks in advance.
> > > > >
> > > > >
> > >
> > >
> > >
>
>
>

Right, properly indenting the lines after

If Not TopCell Is Nothing Then ' if it found "top"

would've helped.

P.S. One line If statements are OK with me if they fit nicely on one line.


"Toppers" wrote:

> But it could be End If to If Not TopCell Is Nothing which admittedly could
> come before If .name as per Don's reply. Both are valid I think.
>
> "Bob Phillips" wrote:
>
> > No, he has a line continuation, so no End If needed.
> >
> > --
> > HTH
> >
> > Bob Phillips
> >
> > "Toppers" <Toppers@discussions.microsoft.com> wrote in message
> > news:26927AED-559E-4246-84E6-1D32263FAB3B@microsoft.com...
> > > Hi,
> > >
> > > If .Name Like "*[##]" Then _
> > > .Name = Left(.Name, Len(.Name) - 2)
> > > End If ...... Missing here
> > >
> > > HTh
> > >
> > > "davegb" wrote:
> > >
> > > > I've combined 2 macros that I got help writing here.
> > > > Sub AllSheetsToggleProtectWInd()
> > > > 'for all sheets in currently active workbook, assigned to button
> > > > Dim TopCell As Range
> > > > Dim TopCol As Range
> > > > Dim Cols2Hide As Range
> > > > Dim wkSht As Worksheet
> > > >
> > > > For Each wkSht In ActiveWorkbook.Worksheets
> > > > With wkSht
> > > > If .ProtectContents Then
> > > > .Unprotect Password:=PWORD
> > > > .Name = .Name & "##"
> > > > .Columns.Hidden = False
> > > > Else
> > > > Set TopCell = .Rows(3).Find(What:="top",
> > > > LookIn:=xlValues)
> > > > If Not TopCell Is Nothing Then ' if it found "top"
> > > > Set TopCol = .Columns(TopCell.Column)
> > > > Set Cols2Hide = .Range(TopCol, .Columns("AC"))
> > > > Cols2Hide.Hidden = True
> > > > .Protect Password:=PWORD
> > > > If .Name Like "*[##]" Then _
> > > > .Name = Left(.Name, Len(.Name) - 2)
> > > >
> > > > End If
> > > > End With<-----[end with without with error]
> > > >
> > > > Next wkSht
> > > >
> > > > End Sub
> > > >
> > > >
> > > > But when I run it, I get an error of "End with without if", even though
> > > > there's very clearly a "with wksht" statement at the top. If I remark
> > > > out the End with, I get a "Next without For" error, even though there's
> > > > a "For" statement. So any ideas on why VBA can't see my with or For
> > > > each statements?
> > > > Thanks in advance.
> > > >
> > > >
> >
> >
> >

Not sure I'm following some of your comments re indenting properly. I
imagine there are different approaches, just like naming variables, but
can someone give me some guidelines to help avoid this type of problem?
For instance, post how you would have indented my macro?
Thanks!

maybe

..Protect Password:=PWORD
END IF
If .Name Like "*[##]" Then _


--
Don Guillett
SalesAid Software
donaldb@281.com
"davegb" <davegb@safebrowse.com> wrote in message
news:1114524904.137484.83730@f14g2000cwb.googlegroups.com...
> I've combined 2 macros that I got help writing here.
> Sub AllSheetsToggleProtectWInd()
> 'for all sheets in currently active workbook, assigned to button
> Dim TopCell As Range
> Dim TopCol As Range
> Dim Cols2Hide As Range
> Dim wkSht As Worksheet
>
> For Each wkSht In ActiveWorkbook.Worksheets
> With wkSht
> If .ProtectContents Then
> .Unprotect Password:=PWORD
> .Name = .Name & "##"
> .Columns.Hidden = False
> Else
> Set TopCell = .Rows(3).Find(What:="top",
> LookIn:=xlValues)
> If Not TopCell Is Nothing Then ' if it found "top"
> Set TopCol = .Columns(TopCell.Column)
> Set Cols2Hide = .Range(TopCol, .Columns("AC"))
> Cols2Hide.Hidden = True
> .Protect Password:=PWORD
> If .Name Like "*[##]" Then _
> .Name = Left(.Name, Len(.Name) - 2)
>
> End If
> End With<-----[end with without with error]
>
> Next wkSht
>
> End Sub
>
>
> But when I run it, I get an error of "End with without if", even though
> there's very clearly a "with wksht" statement at the top. If I remark
> out the End with, I get a "Next without For" error, even though there's
> a "For" statement. So any ideas on why VBA can't see my with or For
> each statements?
> Thanks in advance.
>

Hi Dave


check my comments in line #########


--
Cheers
JulieD
check out www.hcts.net.au/tipsandtricks.htm
....well i'm working on it anyway
"davegb" <davegb@safebrowse.com> wrote in message
news:1114524904.137484.83730@f14g2000cwb.googlegroups.com...
> I've combined 2 macros that I got help writing here.
> Sub AllSheetsToggleProtectWInd()
> 'for all sheets in currently active workbook, assigned to button
> Dim TopCell As Range
> Dim TopCol As Range
> Dim Cols2Hide As Range
> Dim wkSht As Worksheet
>
> For Each wkSht In ActiveWorkbook.Worksheets
> With wkSht
> If .ProtectContents Then
> .Unprotect Password:=PWORD
> .Name = .Name & "##"
> .Columns.Hidden = False
> Else
> Set TopCell = .Rows(3).Find(What:="top",
> LookIn:=xlValues)
> If Not TopCell Is Nothing Then ' if it found "top"
########where is this IF's END IF???############

> Set TopCol = .Columns(TopCell.Column)
> Set Cols2Hide = .Range(TopCol, .Columns("AC"))
> Cols2Hide.Hidden = True
> .Protect Password:=PWORD
> If .Name Like "*[##]" Then _
> .Name = Left(.Name, Len(.Name) - 2)
>
> End If
> End With<-----[end with without with error]
>
> Next wkSht
>
> End Sub
>
>
> But when I run it, I get an error of "End with without if", even though
> there's very clearly a "with wksht" statement at the top. If I remark
> out the End with, I get a "Next without For" error, even though there's
> a "For" statement. So any ideas on why VBA can't see my with or For
> each statements?
> Thanks in advance.
>

Boy, is my face red! Somehow, as I wrote the message, I put down that
there was an "End If w/o an If" error. It's an "End with w/o with"
error, which is what I indicated in the code I posted. Does that make
more sense? Sorry for the confusion, working on too many things at
once.

Hi Dave

but as far as i can tell you do need this extra END IF and if you put it in
does your code then run correctly ... error messages aren't always 100%
accurate

--
Cheers
JulieD
check out www.hcts.net.au/tipsandtricks.htm
....well i'm working on it anyway
"davegb" <davegb@safebrowse.com> wrote in message
news:1114529063.255121.75850@o13g2000cwo.googlegroups.com...
> Boy, is my face red! Somehow, as I wrote the message, I put down that
> there was an "End If w/o an If" error. It's an "End with w/o with"
> error, which is what I indicated in the code I posted. Does that make
> more sense? Sorry for the confusion, working on too many things at
> once.
>

True, the compiler/interpreter can't see the "missing" With statement. The
End With appears to be inside the unclosed If statement.

"JulieD" wrote:

> Hi Dave
>
> but as far as i can tell you do need this extra END IF and if you put it in
> does your code then run correctly ... error messages aren't always 100%
> accurate
>
> --
> Cheers
> JulieD
> check out www.hcts.net.au/tipsandtricks.htm
> ....well i'm working on it anyway
> "davegb" <davegb@safebrowse.com> wrote in message
> news:1114529063.255121.75850@o13g2000cwo.googlegroups.com...
> > Boy, is my face red! Somehow, as I wrote the message, I put down that
> > there was an "End If w/o an If" error. It's an "End with w/o with"
> > error, which is what I indicated in the code I posted. Does that make
> > more sense? Sorry for the confusion, working on too many things at
> > once.
> >
>
>
>

It worked! Thanks a lot, Julie!

you're welcome

--
Cheers
JulieD

"davegb" <davegb@safebrowse.com> wrote in message
news:1114530168.323623.153710@o13g2000cwo.googlegroups.com...
> It worked! Thanks a lot, Julie!
>

Dave,
Did you ever resolve this problem? It is clearly a missing End If that is causing your problem as pointed out by others. The question now is where do you want the End If? I placed it in three different places and all three allow the code to run. It just depends on what the code is trying to do as to where it should be placed for the desired results.

See below for different places it worked for me.


Sub AllSheetsToggleProtectWInd()
'for all sheets in currently active workbook, assigned to button
Dim TopCell As Range
Dim TopCol As Range
Dim Cols2Hide As Range
Dim wkSht As Worksheet

For Each wkSht In ActiveWorkbook.Worksheets
With wkSht
If .ProtectContents Then
.Unprotect Password:=PWORD
.Name = .Name & "##"
.Columns.Hidden = False
Else
Set TopCell = .Rows(3).Find(What:="top",LookIn:=xlValues)
End If 'placed here will close your first If ... Else statement without the other If's nested

If Not TopCell Is Nothing Then ' if it found "top"
Set TopCol = .Columns(TopCell.Column)
Set Cols2Hide = .Range(TopCol, .Columns("AC"))
Cols2Hide.Hidden = True
.Protect Password:=PWORD)
End If 'Placed here will close your second If statement without nesting the below one line If...Then statement

If .Name Like "*[##]" Then _
.Name = Left(.Name, Len(.Name) - 2))
End If 'Placed here will close your second If statement with the one line If...Then nested

End If 'This will either close your first or second If statement depending on where you place the first End If
End With<-----[end with without with error]

Next wkSht

End Sub

Hope This Helps

B