Application ScreenUpdating and Error Handling

Hi,

When using Application ScreenUpdating = False and then turning it back on with Application ScreenUpdating = True where should the True line of code go when using error handling. Does it go right before End Sub as in the example below?

Example

Sub example ()

On Error GoTo ErrMsg

Application ScreenUpdating = False
'Code here

Exit Sub

ErrMsg:
MsgBox "Got an error."

Application ScreenUpdating = True

End Sub


Thanks for taking the time to review.
Karen

Hi !

Vraag, it should be but it's not always the case …

Karen, you must set ScreenUpdating to True between ErrMsg and the MsgBox codeline and just before the Exit Sub codeline …

@Vraag, from experience I have found it something of a myth.
It may be the case that on completion of a macro screen updating returns to true, however I have experienced on many occasions over the years this is not always the case when working with a UserForm environment, this is also supported in the link below.
Back to the OP question, place it both immediately before your 'Exit Sub' command and imediately after 'ErrMsg:' to ensure it is read in each scenario.
torachan.

https://www.atlaspm.com/toms-tutoria...rue-heres-why/

As I have also experimented the case without using any UserForm …

That was my thinking to be sure both scenarios are covered. Thanks

Thanks! Appreciate the response.

When using error handling using labels, it is definitely better to use two labels as in the example below. Then we clean up what we messed up in only one place (after the ExitSub label).

Please Login or Register  to view this content.

Artik

Vraag, Torachan (and Marc L) is right. There are situations when the screen is not refreshed after the code is finished, even though ScreenUpadting has been automatically reset to True (without our intervention). If you don't want to force a screen refresh at the end of the macro, always check if you can see what you expected.

Artik

A easy illustration on a userform cycle through the four command buttons twice, the screen updating does not return true when you unload the userform and reload it.
The initial true state is set by opening Excel not by the initialisation of VBA and does not reset until reverting back to Excel to start another procedure.Capture.JPG

Torachan, Your example is something else that I've been thinking about. In this example, the last False is because the main routine has not yet finished, eg

Please Login or Register  to view this content.

ScreenUpdating is automatically reset to True only after End Sub has been executed.
I mean the cases where the macro has finished and the user sees old (stale) data in the spreadsheet, even though it has actually changed. Only, for example, manual editing of cells or switching to another sheet and returning will refresh the view. These are rare cases so I can't remember the details. But it seems to me (not sure) that this is what happens when the code is working with the PivotTable.

Artik