Saving and Closing workbook leaves a blank excel shell open, why?

I have a report that i automated by the task scheduler and for some time i was ok with it staying open once it processed as i was already in other excel files working, so wasn't a big deal, last week i added the following to the processing and having some weird side effects.

This code works on saving and closing the file, BUT it leaves the excel shell open, meaning that the excel application is open, but no workbook is open.

Please Login or Register  to view this content.

All i want to do is close that instance of excel that was just opened and processed.

You need Application.Quit to close the application.

So just update it to this?

Please Login or Register  to view this content.

Yes, unless the code is actually in the active workbook, in which case just save the active workbook, then quit.

The report is scheduled to run tomorrow morning, so ill know if it works then, since it already ran and processed todays files, i cant test it now.

So my report just ran with the this code and still left the excel shell open after finishing.

Please Login or Register  to view this content.

So my actual report workbook closes and saves with the latest updates, but after that closes, the excel shell is left behind.

Is the code in that workbook?

Nope, its in my Module2 and called from my Module1 like this:

' Save and Close workbook
Call Module2.SaveAndClose

Its not so much an issue, more of a nuisance than anything else. But it would be nice to have it close once complete, specially if im not in excel at that moment.

Which workbook are those modules in? The one the code is closing or a different one?

same workbook that is being closed.

So my workbook which has the 2 modules is the one that is opened by a scheduled task at a certain time(9am) then in the "ThisWorkbook" object im using the Workbook_Open() and is where i call my sub that is in Module1

Please Login or Register  to view this content.

, which is where all the calls are made for the rest of the subs.
Now that im typing it out, i think when you asked earlier in the posts, i stated incorrectly.



The routine that is called in the above is the following:

Please Login or Register  to view this content.

If it's the workbook with the code in that is closing, you need something like:

Please Login or Register  to view this content.

Originally Posted by rorya

If it's the workbook with the code in that is closing, you need something like:

Please Login or Register  to view this content.

I have made the update and will post back tomorrow morning once it runs again.
thank you

Originally Posted by rorya

If it's the workbook with the code in that is closing, you need something like:

Please Login or Register  to view this content.

this did the trick, opened, processed, saved and closed within 2 seconds.. thank you

Glad we could help.