VBA Script Applying to other open workbooks

I am using a login form to customize which sheets to display based on who logs in. It works fine (though I know it's not the cleanest code) but if another workbook is open, I get "Subscript out of range." It appears to me that it is trying to find worksheets in the already open workbook instead of the one that is being logged into.

Instead of telling users they have to close all open workbooks before opening this one, is there a way to handle this error?

Code is below:

Private Sub cmdLogin_Click()

Dim user As String
Dim password As String

user = Me.txtUserID.Value
password = Me.txtPassword.Value

If (user = "admin" And password = "mon57701") Or (user = "rcsales" And password = "lifesong") Or (user = "showroom" And password = "update") Then


'THIS SECTION IS USED TO CUSTOMIZED LOGIN
If user = "rcsales" Then
Unload Me
Worksheets("LifeSong Report").Visible = False
Worksheets("RileyStatus2021").Visible = True
Worksheets("RileyStatus2021").Protect
Worksheets("RileySort").Visible = False
Worksheets("RileySales").Visible = True
Worksheets("RileySales").Protect
Worksheets("NCOCalc").Visible = False
Worksheets("COMMRATE").Visible = False
Worksheets("SFSales").Visible = False
Worksheets("Targets").Visible = True
Worksheets("Targets").Protect
Application.Visible = True
frmAdminMenu.Show


ElseIf user = "admin" Then
Unload Me
Worksheets("LifeSong Report").Visible = True
Worksheets("RileyStatus2021").Visible = True
Worksheets("RileyStatus2021").Unprotect
Worksheets("RileySort").Visible = False
Worksheets("RileySales").Visible = True
Worksheets("RileySales").Unprotect
Worksheets("NCOCalc").Visible = True
Worksheets("COMMRATE").Visible = False
Worksheets("SFSales").Visible = True
Worksheets("Targets").Visible = True
Worksheets("Targets").Unprotect
Application.Visible = True
frmAdminMenu.Show

Else
Unload Me
Worksheets("LifeSong Report").Visible = False
Worksheets("RileyStatus2021").Visible = False
Worksheets("RileyStatus2021").Protect
Worksheets("RileySort").Visible = False
Worksheets("RileySales").Visible = True
Worksheets("RileySales").Unprotect
Worksheets("NCOCalc").Visible = False
Worksheets("COMMRATE").Visible = False
Worksheets("SFSales").Visible = False
Worksheets("Targets").Visible = False
Worksheets("Targets").Protect
Application.Visible = True
frmAdminMenu.Show


End If

Administrative Note:

We would very much like to help you with your query, however you need to include code tags around your code.

Please take a moment to add the tags. Posting code between [code] [/code] tags makes your code much easier to read and copy for testing, and it also maintains VBA formatting.

Please see Forum Rule #2 about code tags and adjust accordingly. Click on Edit to open your post, then highlight your code and click the # icon at the top of your post window. More information about these and other tags can be found here

(Note: this change is not optional.)



Please attach a sample workbook (not a picture or pasted copy). Make sure there is just enough data to demonstrate your need. Include a BEFORE sheet and an AFTER sheet in the workbook if needed to show the process you're trying to complete or automate. Make sure your desired results are shown, mock them up manually if necessary.

Remember to desensitize the data.

Click on GO ADVANCED and then scroll down to Manage Attachments to open the upload window.

Thank you

Try:

Private Sub cmdLogin_Click()

Dim user As String
Dim password As String

user = Me.txtUserID.Value
password = Me.txtPassword.Value

If (user = "admin" And password = "mon57701") Or (user = "rcsales" And password = "lifesong") Or (user = "showroom" And password = "update") Then

With ThisWorkbook 
'THIS SECTION IS USED TO CUSTOMIZED LOGIN
  If user = "rcsales" Then
    Unload Me
    .Worksheets("LifeSong Report").Visible = False
    .Worksheets("RileyStatus2021").Visible = True
    .Worksheets("RileyStatus2021").Protect
    .Worksheets("RileySort").Visible = False
    .Worksheets("RileySales").Visible = True
    .Worksheets("RileySales").Protect
    .Worksheets("NCOCalc").Visible = False
    .Worksheets("COMMRATE").Visible = False
    .Worksheets("SFSales").Visible = False
    .Worksheets("Targets").Visible = True
    .Worksheets("Targets").Protect
    Application.Visible = True
    frmAdminMenu.Show

  ElseIf user = "admin" Then
    Unload Me
    .Worksheets("LifeSong Report").Visible = True
    .Worksheets("RileyStatus2021").Visible = True
    .Worksheets("RileyStatus2021").Unprotect
    .Worksheets("RileySort").Visible = False
    .Worksheets("RileySales").Visible = True
    .Worksheets("RileySales").Unprotect
    .Worksheets("NCOCalc").Visible = True
    .Worksheets("COMMRATE").Visible = False
    .Worksheets("SFSales").Visible = True
    .Worksheets("Targets").Visible = True
    .Worksheets("Targets").Unprotect
    Application.Visible = True
    frmAdminMenu.Show

  Else
    Unload Me
    .Worksheets("LifeSong Report").Visible = False
    .Worksheets("RileyStatus2021").Visible = False
    .Worksheets("RileyStatus2021").Protect
    .Worksheets("RileySort").Visible = False
    .Worksheets("RileySales").Visible = True
    .Worksheets("RileySales").Unprotect
    .Worksheets("NCOCalc").Visible = False
    .Worksheets("COMMRATE").Visible = False
    .Worksheets("SFSales").Visible = False
    .Worksheets("Targets").Visible = False
    .Worksheets("Targets").Protect
    Application.Visible = True
    frmAdminMenu.Show
  End If
End With

You're welcome. Thanks for the rep.

It only becomes simple when you've seen it before, or something similar ... and you remember what you did last time . No need to be embarrassed.