Textbox negative values not showing correctly

The ROI($) value is the SALE - INVESTMENT.
The ROI(%) value is the (SALE-INVESTMENT)/SALES

If the values are negative they are red and in brackets, but both still show the Minus sign, and the ROI (%) has a leading "Hashmark".

Option Explicit
Dim a As Long, f As Long
Dim c As Range
Dim ws As Worksheet

Private Sub CommandButton2_Click()

    If tboxSPINV <> "" And tboxSPSALES <> "" Then
    
    tboxSPROICASH.Value = tboxSPSALES - tboxSPINV
        If tboxSPROICASH.Value < 0 Then
        tboxSPROICASH.Value = Format(tboxSPROICASH, "($#,##0.00)")
        tboxSPROICASH.ForeColor = RGB(255, 0, 0)
        
        Else: tboxSPROICASH.Value = Format(tboxSPROICASH, "$#,##0.00)")
        tboxSPROICASH.ForeColor = RGB(0, 0, 0)
        End If
        
    tboxSPROIPER.Value = (tboxSPSALES - tboxSPINV) / tboxSPSALES
        If tboxSPROIPER < 0 Then
        tboxSPROIPER.Value = Format(tboxSPROIPER.Value, "(\#,##0.00%)")
        tboxSPROIPER.ForeColor = RGB(255, 0, 0)
        
        Else: tboxSPROIPER.Value = Format(tboxSPROIPER.Value, "#,##0.00%")
        tboxSPROIPER.ForeColor = RGB(0, 0, 0)
        End If
        
    End If
   
End Sub

Private Sub CommandButton4_Click()

    Unload Me

End Sub

Any solutions, suggestions or alternatives received gratefully as ever

Ochimus

  If tboxSPROICASH.Value < 0 Then
    tboxSPROICASH.Value = Format(tboxSPROICASH, "$#,##0.00;($#,##0.00)")
  
  ' ...
  
  If tboxSPROIPER < 0 Then
    tboxSPROIPER.Value = Format(tboxSPROIPER.Value, "#,##0.00%;(#,##0.00%)")

You can specify a format for positive and negative:

"#,##0.00%;(#,##0.00%)"

the \ in your format string was the reason for you getting a hash mark.

Or ...

Private Sub CommandButton2_Click()
  Dim d             As Double

  If tboxSPINV <> "" And tboxSPSALES <> "" Then
    d = tboxSPSALES.Value - tboxSPINV.Value
    With tboxSPROICASH
      .Value = Format(d, "$#,##0.00;($#,##0.00)")
      If d >= 0 Then .ForeColor = vbBlack Else .ForeColor = vbRed
    End With

    d = 1# - tboxSPINV.Value / tboxSPSALES.Value
    With tboxSPROIPER
      .Value = Format(d, "#,##0.00%;(#,##0.00%)")
      If d >= 0 Then .ForeColor = vbBlack Else .ForeColor = vbRed
    End With
  End If
End Sub

Compiles fine here. You sure you copied the code correctly?

You need to be very careful when adding strings. Use val to convert the textboxes to actual number values:

    e = d / (Val(tboxSPBUY.Value) + Val(tboxSPINV.Value))