Amazing disappearing error 1004

I wrote some VBA to copy a range from a worksheet and paste it as values to another worksheet in the same workbook. It failed with error 1004. I set the macro recorder running and collected the code generated when I performed the operation by hand. As a stand-alone macro, it worked without error. When I appended these lines of code unaltered to my existing macro, error 1004 again appeared. After some trial and error, I found that if I segregated the copy/paste to a subroutine and called it with the source range as a parameter, it ran without error. So, summarising:

Please Login or Register  to view this content.

....fails with error 1004. But:

Test(r)

..runs without error, when Test is defined as:

Please Login or Register  to view this content.

What is going on?

Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code.

Posting code between [CODE]Please [url=https://www.excelforum.com/login.php]Login or Register [/url] to view this content.[/CODE] tags makes your code much easier to read and copy for testing, it also maintains VBA formatting.

Click on Edit to open your thread, then highlight your code and click the # icon at the top of your post window. More information about these and other tags can be found here

I will do this for you on this occasion only.

You have not set r to a range which could be your problem

Avoid lots of other problems by not selecting everything in sight!!
Selecting is usually not required
It slows everything down

So if r is A1:A10

Please Login or Register  to view this content.

Selecting things
If it is necessary to select sheets & cells.....
..for sheets I generally use Activate

Please Login or Register  to view this content.

Activate a sheet before trying to select any cells

...for cells use Select

Please Login or Register  to view this content.

If you want to select several sheets(to do the same thing to all of them) then use select (only one sheet can be active at the same time)

r is set. I'm not that dumb!

Perhaps not
How are we supposed to know that? We cannot read invisible code
Free advice for you : Expect dumb answers if you provide incomplete information