Strange Results with custom filter and arrays

If vdata(i, 1) > Now Then
Checks column A, but B.
It would be easier to see why the code does not produce the desired result with a sample. Please attach a sample.
If you are merely checking for a condition, you could probably use a filter than a loop.

Hi thanks for your reply and sorry for my late response, im not sure there will be possible with a built in filter , (except for this sample) as I have several custom Filters using the same loop, I'll attach a workbook sample ,

(but it must be tested within 30 min or everything will be removed)

frederik

I do not see any error. Mind you the function "Now" is volatile.

Here is the 2nd code, I've updated the sample with all corresponding data

You are right! The code was not right.
Try

Sub RemovePassedDate()
Dim Lrow, i, j, k, c  As Long
Dim str As String
Dim vdata() As Variant
Dim vResult() As Variant
Dim Sheet As Worksheet
Set Sheet = ActiveWorkbook.Sheets("Sheet1")
Lrow = Sheet.Cells(Rows.Count, "B").End(xlUp).Row
Application.ScreenUpdating = False
vdata = Sheet.Range("A12:Z" & Lrow)
ReDim vResult(1 To UBound(vdata, 1), 1 To UBound(vdata, 2))
For i = LBound(vdata, 1) To UBound(vdata, 1)
 'If CDate(Format(vdata(i, 1), "dd/mm/yyyy hh:mm")) > Now Then
   If vdata(i, 1) > Now Then
        j = j + 1
      For c = 1 To UBound(vdata, 2)
         vResult(j, c) = vdata(i, c)
      Next c
   End If
Next i
If j > 0 Then
     Sheet.Range("A12:Z" & Lrow).ClearContents
     Sheet.Range("A12").Resize(j, UBound(vResult, 2)) = vResult
 End If
Application.ScreenUpdating = True
End Sub

Thanks for your help and good eye I see that you made several changes..
do you see what that is incorrect with the 2nd code also ? what was producing these strange results ?

I do not how I did notice the flow in the code when I first tested it.
It has many flows. You are right to see stange result.

Look at this

For c = 1 To UBound(vdata, 2)
         If c > 0 Then vResult(j, c - 1) = vdata(i, c)
      Next c
      j = j + 1

As the code loops through columns for the first time the first row (j) is 0

so that's whats producing the strange behavior? thanks for the help. Im totally busted I've painted my house today so I'm gonna test this more out tomorrow with a fresh head , Many thanks for your input and help

frederik

Edit: sorry I was not able to give you any more rep as I gave you earlier

There are few, but the main one is

The j value is calculated correctly but, when you dump the data back to excel, see what you get

Sheet.Range("A12:Z" & UBound(vResult, 1)) = vResult

and probably this line too

ReDim vResult(UBound(vdata, 1), UBound(vdata, 2))
I have never done output starting from 0, as oppose to 1.

Oh this became more complicated that I can comprehend at this point , also I used almost a full day compiling this as im no professional coder and this is some sort of extra hobby project ..

I had some problems with this code and you are right originally when I tried to dump it back into the sheet everything got offset by 1 , (column and row) so my workaround was this:

Then vResult(j, c - 1) = vdata(i, c)

I guess more was disturbed giving me incorrect values., I guess if I edit you version everything will work as expected ?

Yes, my version will work well. Test it tomorrow and post it back if you have any issue.

yup ill report back tomorrow.. thanks alot for your time and help .. you have been great.

frederik

Good morning. I tested this and it works great Im gonna study this a little more just to see exactly everything that I did incorrect.

- And you are a real life saver. Im working on a huge custom filter were I can remove countries / Leagues from this list,
running your latest edit now gave no errors. And also I can Run all three filters in a row without any problems

thanks alot

frederik