Error Handling not working

**no1uno** · 09-11-2017, 09:44 PM

Hi

I have a Error Handling routine that is not working. Could someone please have a look and see where I went wrong.

Basically, when the error occurs it does what it is supposed to do which is display message box, focus and clear text box. However, when there is not an error the main code executes the way it should but still displays the error message box.

Thanks

Private Sub cmdSearch_Click() 
    On Error Goto ErrHandler 
     
     
    If Me.txtPID.Value = "" Then 
        MsgBox "Please enter ID.", vbCritical 
        Me.txtPID.SetFocus 
        Exit Sub 
    End If 
     
     
    lblName = Application.VLookup(CLng(txtPID.Value), Worksheets("Lists").Range("M:P"), 2, 0) 
    lblStat = Application.VLookup(CLng(txtPID.Value), Worksheets("Lists").Range("M:P"), 4, 0) 
    lblGender = Application.VLookup(CLng(txtPID.Value), Worksheets("Lists").Range("M:P"), 3, 0) 
    lblRef = txtPID.Value & Format(txtDate.Text, "ddmm") & Application.VLookup(cboTime.Value, Worksheets("Lists").Range("F:G"), 2, 0) 
    Exit Sub 
     
     
ErrHandler: 
    MsgBox "Not a current ID. Please try again!", vbCritical 
    txtPID.Value = "" 
    Me.txtPID.SetFocus 
End Sub

**scottiex** · 09-11-2017, 10:01 PM

Are you sure it is not just that you are getting an error from one of those lines?

comment out the "on error" line, run it on some supposedly good data and tell us what like it errors on and what message.

**MarvinP** · 09-11-2017, 10:20 PM

Hi no1uno,

Is your code behind a worksheet or in a Module? If it is behind a worksheet, insert a real module and put the code in there. Try the below.

Sub cmdSearch_Click()
    On Error GoTo ErrHandler
      
    If Me.txtPID.Value = "" Then
        MsgBox "Please enter ID.", vbCritical
        Me.txtPID.SetFocus
        GoTo Ender
    End If
    
    lblName = Application.VLookup(CLng(txtPID.Value), Worksheets("Lists").Range("M:P"), 2, 0)
    lblStat = Application.VLookup(CLng(txtPID.Value), Worksheets("Lists").Range("M:P"), 4, 0)
    lblGender = Application.VLookup(CLng(txtPID.Value), Worksheets("Lists").Range("M:P"), 3, 0)
    lblRef = txtPID.Value & Format(txtDate.Text, "ddmm") & Application.VLookup(cboTime.Value, Worksheets("Lists").Range("F:G"), 2, 0)
    GoTo Ender
     
ErrHandler:
    MsgBox "Not a current ID. Please try again!", vbCritical
    txtPID.Value = ""
    Me.txtPID.SetFocus
    On Error GoTo 0
Ender:

End Sub

http://www.cpearson.com/excel/Scope.aspx