I don't want to duplicate code in sheets, so right now i have
callThisSub works
Please Login or Register to view this content.
callThisSub2 doesn't work, do I need to define it differently? the code is workbook specifik so I guess I should have it in thisworkbook and not in a module?
Last edited by elfor; 06-01-2017 at 08:51 AM.
Treat the code in a worksheet class module to be specific to that worksheet, and is only called from procedures in the same worksheet module - same for code in ThisWorkbook.
All common code goes in a standard code module.
And, as posted, your code will not compile. You don't declare CallThisSub & CallThisSub2 as a Sub or Function.
When you do correct that, it still won't compile but let's not overcomplicate things. One step at a time.
Last edited by cytop; 06-01-2017 at 09:18 AM.
Sub or function not defined for WorkBookTest
Please Login or Register to view this content.
That's right - now your problem is the syntax you use to call the subs.
If a Sub takes parameters and you bracket the parameter in a call to the Sub then you must use the CALL keyword.
If you don't bracket the parameters then you can simply call the procedure in-line without the bracketsPlease Login or Register to view this content.It is suggested you do not have Public Subs/Functions in what can be seen as a 'transient' module. The ThisWorkbook class is never going to disappear, but what if you have a procedure in a worksheet class and that worksheet is deleted later? The procedure disappears.Please Login or Register to view this content.
After saying that, you can call a procedure in the THisWorkbook class (or any sheet class module) by prefacing the procedure name with the container nameHowever, you will hit problems at some stage if you do that...Please Login or Register to view this content.
If i understand you correctly module1 is a transient module and I should use thisworkbook
If i then understand you correctly, I can call the workbook directly "ThisWorkBook.WorkBookTest "Hi" but that is not recommended as it can cause problems.Please Login or Register to view this content.
Though Call or inline still gives me the same error, i probably misinterpreted your text?
Please Login or Register to view this content.
Last edited by elfor; 06-01-2017 at 09:49 AM.
But you should treat ThisWorkbook the same as the individual sheets. Unless the code is only called from within the ThisWorkbook class (or is code for an event procedure) then it should go in a standard code modulePlease Login or Register to view this content.
There are currently 1 users browsing this thread. (0 members and 1 guests)
Posting Permissions
LinkBack URL
About LinkBacks
Register To Reply
Bookmarks