Userforms help

Hi Guys,

I have the below code and I think it is correct but it doesn't seem to call any subs when I hit OK if the checkboxes are checked. The other issue is when I hit okay and nothing is typed in the analyst name textbox, this comes up with a warning msg, as it should do, however whenever I leave one of the others blank it displays error messages for all the textboxes being blank even if they are not!

Just as an FYI, I have the checkboxes enter a value of true or false respectively into a spreadsheet next to the respective name, this is then copied next to it when you hit okay to remember the settings in case the user reopens the form changes the checkboxes and hits cancel. Cancel copies the saved options over the referenced ones for the subs to be called

Any ideas would be really handy!

Private Sub CheckBoxCUST_Click()
If CheckBoxCUST.Value = True Then
Sheets("VBA inputs").Range("B3").Value = "TRUE" 'Check
Else
Sheets("VBA inputs").Range("B3").Value = "FALSE" 'UnCheck
End If
End Sub

Private Sub CheckBoxSUP_Click()
If CheckBoxSUP.Value = True Then
Sheets("VBA inputs").Range("B2").Value = "TRUE" 'Check
Else
Sheets("VBA inputs").Range("B2").Value = "FALSE" 'UnCheck
End If
End Sub

Private Sub CheckBoxTRANS_Click()
If CheckBoxTRANS.Value = True Then
Sheets("VBA inputs").Range("B4").Value = "TRUE" 'Check
Else
Sheets("VBA inputs").Range("B4").Value = "FALSE" 'UnCheck
End If
End Sub

Private Sub CANCEL_Click()

Dim VBAinp As Worksheet
Dim CUST As Range
Dim SUP As Range
Dim Trans As Range
Set VBAinp = Sheets("VBA inputs")
Set CUST = VBAinp.Range("B2")
Set SUP = VBAinp.Range("B3")
Set Trans = VBAinp.Range("B4")


ToolSelec.Hide
VBAinp.Range("C2:C4").Copy Destination:=Sheets("VBA inputs").Range("B2:B4")

If CUST.Value = "True" Then
CheckBoxCUST.Value = True 'Check
ElseIf CUST.Value = "FALSE" Then
CheckBoxCUST.Value = False 'UnCheck
End If

If SUP.Value = "True" Then
CheckBoxSUP.Value = True 'Check
ElseIf SUP.Value = "FALSE" Then
CheckBoxSUP.Value = False 'UnCheck
End If

If Trans.Value = "True" Then
CheckBoxTRANS.Value = True 'Check
ElseIf Trans.Value = "FALSE" Then
CheckBoxTRANS.Value = False 'UnCheck
End If

Sheets("Transaction").Activate

End Sub

Private Sub ButtonOK_Click()

Dim VBAinp As Worksheet
Dim CUST As Range
Dim SUP As Range
Dim Trans As Range
Set VBAinp = Sheets("VBA inputs")
Set CUST = VBAinp.Range("B3")
Set SUP = VBAinp.Range("B2")
Set Trans = VBAinp.Range("B4")

ToolSelec.Hide
VBAinp.Range("B2:B4").Copy Destination:=VBAinp.Range("C2:C4")

If CUST.Value = "true" Then
    'Call Customers
End If
If SUP.Value = "TRUE" Then
    Call Suppliers
End If
If Trans.Value = "TRUE" Then
    Call Transaction_Freq
End If

End Sub

Thanks for the reply!

That does make sense

Here it is, I have taken out the main code, as the version I have at home isn't completed and would give endless errors.

The forms with the issues are toolselec and analyst input. the checkboxes in toolselec refer to subs in "MainCode"

You have done a mistake here :

If CUST.Value = "True" Then
    'Call Customers
End If
If SUP.Value = "True" Then
    Application.Run "Suppliers"
End If
If Trans.Value = "True" Then
    Call Transaction_Freq
End If

As True/False are Boolean they will not be bounded with double inverted comma. Correct them as below :

If CUST.Value = True Then
    'Call Customers
End If
If SUP.Value = True Then
    Application.Run "Suppliers"
End If
If Trans.Value = True Then
    Call Transaction_Freq
End If

Thanks! that worked, anything for my other issue?

On the analyst input form,when I hit okay and nothing is typed in the analyst name textbox, this comes up with a warning msg, as it should do, however whenever I leave one of the others blank it displays error messages for all the textboxes being blank even if they are not!

Thanks for the rep. For the error message you have used below code :

Private Sub OK_Click()

If AnalystName.Value = "" Then
GoTo Analysterr
Exit Sub
ElseIf Sortcode.Value = "" Then
GoTo SCerr
Exit Sub
ElseIf AccNo.Value = "" Then
GoTo ACCnoerr
Exit Sub
Else
Analyst_input.Hide
End If

Exit Sub
SCerr:
    MsgBox "Please Enter Sortcode", vbOKOnly, "Error"
ACCnoerr:
    MsgBox "Please Enter Account number", vbOKOnly, "Error"
Analysterr:
    MsgBox "Please Enter Your Name", vbOKOnly, "Error"
End Sub

Here you have declared Exit Sub after GoTo. But when you call GoTo then it goes to the line you declared and don't come back again unless you call them. So call exit Sub after MsgBox as below :

Private Sub OK_Click()

If AnalystName.Value = "" Then
GoTo Analysterr
ElseIf Sortcode.Value = "" Then
GoTo SCerr
ElseIf AccNo.Value = "" Then
GoTo ACCnoerr
Else
Analyst_input.Hide
End If

Exit Sub
SCerr:
    MsgBox "Please Enter Sortcode", vbOKOnly, "Error"
    Exit Sub
ACCnoerr:
    MsgBox "Please Enter Account number", vbOKOnly, "Error"
    Exit Sub
Analysterr:
    MsgBox "Please Enter Your Name", vbOKOnly, "Error"
    Exit Sub
End Sub