UserForm textbox save loop anomaly

**radddogg** · 11-09-2016, 05:09 AM

Hi all,

I'm hoping someone can point out why my userform is behaving oddly.

I have a userform with 5 command buttons and 5 text boxes. Each textbox has a unique 'tag' property which is used in the code. Buttons 1 to 4 fire the file dialog for the user to select a raw data excel file and puts the filepath into the corresponding textbox. CommandButton5 contains code which opens these filepaths. TextBox5 is a free text entry where the user can choose the project name. The code for CommandButton5 is below. Basically the form is supposed to get the user to select the 4 data files, open the files, save a temporary file with a filename of the textbox 'tag', open a blank workbook and save it with the filename of TextBox5.Value.

This all works perfectly except the file opened by TextBox4 is saved with the 'tag' property from TextBox5 and I have no idea why. Any ideas? thanks

I'd also appreciate any tips regarding anything I may have missed out of my code or any noob errors I've made.

Please Login or Register  to view this content.

**pjwhitfield** · 11-09-2016, 05:16 AM

By the looks of it, its saving Workbook 4 twice. Once correctly and then again with the TextBox5 value.

Although you open a blank workbook before textbox 5 action you dont tell Excel to save that one as the textbox5 one, you tell it to save the ActiveWorkbook

**radddogg** · 11-09-2016, 05:37 AM

Originally Posted by pjwhitfield

By the looks of it, its saving Workbook 4 twice. Once correctly and then again with the TextBox5 value.

Although you open a blank workbook before textbox 5 action you dont tell Excel to save that one as the textbox5 one, you tell it to save the ActiveWorkbook

Thanks for the reply. Hmm. I'm a little confused. Firstly, where in the code are you seeing that it is saving book4 twice? Secondly, why wouldn't the recently added workbook be the activeworkbook, and how can I make it active or at least save it correctly? Cheers

**radddogg** · 11-09-2016, 05:40 AM

Originally Posted by pjwhitfield

By the looks of it, its saving Workbook 4 twice. Once correctly and then again with the TextBox5 value.

Although you open a blank workbook before textbox 5 action you dont tell Excel to save that one as the textbox5 one, you tell it to save the ActiveWorkbook

Ah I get it!

TB5 is just a filename rather than a file path so it was throwing a file can't be found error. I added the error handler to skip opening that 'file' but the save action still happens. I get it.

So how to get round it? Maybe using a combobox instead but not very elegant. Hmm, will have a think.

**xlnitwit** · 11-09-2016, 05:59 AM

Perhaps thus

Please Login or Register  to view this content.

**radddogg** · 11-09-2016, 06:13 AM

Originally Posted by xlnitwit

Perhaps thus

Please Login or Register  to view this content.

Beautiful, thanks so much!

**xlnitwit** · 11-09-2016, 06:16 AM

You're welcome.

UserForm textbox save loop anomaly

LinkBack

Thread Tools

Rate This Thread

Display

UserForm textbox save loop anomaly

Re: UserForm tag anomaly

Re: UserForm tag anomaly

Re: UserForm tag anomaly

Re: UserForm tag anomaly

Re: UserForm tag anomaly

Re: UserForm textbox save loop anomaly

Thread Information

Users Browsing this Thread

Similar Threads

[SOLVED] Formula anomaly

[SOLVED] round up/down anomaly?

IF function anomaly

DATEDIF anomaly?

Printing Anomaly

[SOLVED] Formatting Anomaly

[SOLVED] VLOOKUP Anomaly

Bookmarks

Bookmarks

Posting Permissions