My loop is missing last iteration

Your code wasn't looping through the files in the folder

Try

Sub test()
    Dim wb As Workbook
    Dim ws As Worksheet
    Dim mRng As Range
    Dim cRng As Range
    Dim mCell As Range
    Dim cCell As Range

    Dim filename As String
    Dim folderPath As String
    
    Set Mwb = ActiveWorkbook
    Set mws = Worksheets(1)
    
    lr = ActiveSheet.UsedRange.SpecialCells(xlCellTypeLastCell).Row
    
    Set mRng = mws.Range("h1:h" & lr)
    
    folderPath = "C:\DATA\"
    
    file = Dir(folderPath)
    Application.ScreenUpdating = False
    
    While (file <> "")
    
        Set wb = Workbooks.Open(folderPath & file)
        Set ws = wb.Worksheets(1)
        
        lr = ActiveSheet.UsedRange.SpecialCells(xlCellTypeLastCell).Row
        
        Set cRng = ws.Range("H1:H" & lr)
            
            For Each mCell In mRng
                    For Each cCell In cRng
                        If cCell = mCell Then mCell.Offset(0, 1) = cCell.Offset(0, 1)
                    Next cCell
             Next mCell
        
        Workbooks(file).Close SaveChanges:=False
        
        file = Dir
    
    Wend
  
  mws.Range("h1") = mRng
  
  Application.ScreenUpdating = True

End Sub

Somewhat confused by which column the numbers are in : your code suggests "I", your description "G" and an image "T"!!!

The comparison loop could be replace by MATCH function.

Your example is missing value did you notice that?

Thank you in advance.

Originally Posted by YasserKhalil

Just try to remove that line

mws.Range("h1") = mRng

You have made it totally correct @YasserKhalil

there is another issue.

The issue is which order the loop read the files. cause the macro write over current values.

Why I thought your version of the macro is was missing values but actually my bad.




MFU7Quv.png


The macro ads First Test1.xlsx the values 30 and 40 then it adds test2.xlsx all cells even if they are empty.
So I need to create an criteria to the loop that asks" If Same Row Column "I" is empty skip the cell if not add

Do you see what I mean Master?

Thank you in advance.

Try

Sub test()
    Dim wb As Workbook
    Dim ws As Worksheet
    Dim mRng As Range
    Dim cRng As Range
    Dim mCell As Range
    Dim cCell As Range

    Dim filename As String
    Dim folderPath As String
    
    Set Mwb = ActiveWorkbook
    Set mws = Worksheets(1)
    
    lr = ActiveSheet.UsedRange.SpecialCells(xlCellTypeLastCell).Row
    
    Set mRng = mws.Range("h1:h" & lr)
    
    folderPath = "C:\Data\"
    
    file = Dir(folderPath)
    Application.ScreenUpdating = False
    
    While (file <> "")
    
        Set wb = Workbooks.Open(folderPath & file)
        Set ws = wb.Worksheets(1)
        
        lr = ActiveSheet.UsedRange.SpecialCells(xlCellTypeLastCell).Row
        
        Set cRng = ws.Range("H1:H" & lr)
            
            For Each Cell In cRng
            If IsNumeric(Cell.Offset(0, 1)) Then
                res = Application.Match(Cell, mRng, 0)
                If Not IsError(res) Then
                    mws.Cells(res, "I") = Cell.Offset(0, 1)
                End If
            End If
            
            Next Cell
        
        Workbooks(file).Close SaveChanges:=False
        
        file = Dir
    
    Wend
  
  
  
  Application.ScreenUpdating = True

End Sub

Still get same result :S sir.

3cquRGI.png

Results when I run with your data:

I01 10
I02
I03 30
I04 40
I05
I06 60

Check your data for leading/trailing blanks.

Originally Posted by JohnTopley

Results when I run with your data:

I01 10
I02
I03 30
I04 40
I05
I06 60

Check your data for leading/trailing blanks.

that strange see attached file

http://www.megafileupload.com/gav3/test.zip

Originally Posted by JohnTopley

Results when I run with your data:

I01 10
I02
I03 30
I04 40
I05
I06 60

Check your data for leading/trailing blanks.

You were correct!
Awesome thank you very much.

I am actually rewriting the function so I could understand it.

Could you please help me to understand this part of your code.

How does this work also could give another example of how to make just this snippet?

For Each Cell In cRng
            If IsNumeric(Cell.Offset(0, 1)) Then
                res = Application.Match(Cell, mRng, 0)
                If Not IsError(res) Then
                    mws.Cells(res, "I") = Cell.Offset(0, 1)
                End If
            End If

Next Cell

Thank you so much anyway.