Refresh an already declared variable

**EchoPassenger** · 09-18-2016, 04:01 AM

I have a macro in a master file which opens other smaller files and copies their data, it then moves these smaller files into a 'Done' folder with the current date and time appended to the file name.

Currently I have declared my DateTime variable at the start of the code before my For Each loop gets to work on the files. This means that the the same Time (hhmmss) is appended to each file. Now I assume I could just rearrange the code so the declaration is inside the loop so the Time variable (or at least the seconds) would be updated for each file, but is that the only way to get the different times on each file, or is there some sort of 'refresh' line I can add to the start of the loop that will update the variable value instead?

And on a related note, what is 'best practice' for declaring variables? Should they ideally all be declared at the start of the code or does it make no difference when or where you declare them (pending their usage obviously)?

**TMS** · 09-18-2016, 04:30 AM

Where you declare (Dim) your variable is unimportant as long as it is before the first time it is referred to (used). Just use

Please Login or Register  to view this content.

within the loop.

**cytop** · 09-18-2016, 04:31 AM

I assume I could just rearrange the code so the declaration is inside the loop

Simplest.

Best practice for declaring variables is to declare them at the lowest possible scope. If they are local to a procedure then declare at the beginning of the procedure before they are referenced in code (Declaration, not assigning a value, that can be done anywhere). If they are local to a module, then at the top of the module, and finally, Public variable are declared in standard code modules (only), but before module level variables (Just my preference to keep all 'related' variables together - it doesn't matter where they are declared as long as they are in the General Declarations section at the top of the module).