macro save in two path different

[max_max]

Hello everyone.
as correcting the part of the macro < if-then >:

Sub CopiaESalvaInPathX()
 
   Dim username As String
       
'-----------------------------------------------------------------------------------------
   username = Foglio5.Range("A2")
               
 If xlExcel8 Then '<<< excel 2003
  
 sPath = "C:\Documents and Settings\" & username & "\Documenti\rapportini_ore_straordinarie" 'excel 2003
  
Else
 
If xlExcel8 Then '<<< excel 2007 e superiore ??????
 
sPath = "C:\Users\" & username & "\Documents\rapportini_ore_straordinarie" 'excel 2007
 
End If

If Excel 2003 = sPath = "C:\Documents and Settings\" & username & "\Documenti\rapportini_ore_straordinarie" 'excel 2003

if excel 2007 = sPath = "C:\Users\" & username & "\Documents\rapportini_ore_straordinarie" 'excel 2007

I hope I was clear.
max_max

[daffodil11]

Sub CopiaESalvaInPathX()
 
   Dim username As String
       
'-----------------------------------------------------------------------------------------
   username = Foglio5.Range("A2")

Select Case Application.Version
    Case "11.0"
        sPath = "C:\Documents and Settings\" & username & "\Documenti\rapportini_ore_straordinarie" 'excel 2003
    Case "12.0"
        sPath = "C:\Users\" & username & "\Documents\rapportini_ore_straordinarie" 'excel 2007
End Select

End Sub

[max_max]

Thanks daffodil11.
The selection is automatically according to the installed version?
The modification must run on excel 2003 and 2007
A greeting and thanks.
max_max

[max_max]

It works well, I entered the exact change.
Thanks daffodil 11.
max_max

[max_max]

A curiosity.
If the application.version was superior to excel 2007 (I do not have a chance to try) the modification work?
max_max

[daffodil11]

No, but we can accommodate that as well.

Sub CopiaESalvaInPathX()
 
   Dim username As String
       
'-----------------------------------------------------------------------------------------
   username = Foglio5.Range("A2")

Select Case Application.Version
    Case "8.0"  'Excel 97
    
    Case "9.0"  'Excel 2000
    
    Case "10.0" 'Excel 2002
    
    Case "11.0" 'Excel 2003
        sPath = "C:\Documents and Settings\" & username & "\Documenti\rapportini_ore_straordinarie" 'excel 2003
    Case "12.0" 'Excel 2007
        sPath = "C:\Users\" & username & "\Documents\rapportini_ore_straordinarie" 'excel 2007
    Case "14.0" 'Excel 2010
    
    Case "15.0" 'Excel 2013
    
    Case "16.0" 'Excel 2016
    
End Select

End Sub

or you could just do a later or earlier than coercion

Sub CopiaESalvaInPathX()
   Dim username As String
'-----------------------------------------------------------------------------------------
   username = Foglio5.Range("A2")

Select Case Application.Version
    
    Case "9.0", "10.0", "11.0" 'Excel 2003
        sPath = "C:\Documents and Settings\" & username & "\Documenti\rapportini_ore_straordinarie" 'excel 2003
    Case "12.0", "14.0", "15.0", "16.0" 'Excel 2007
        sPath = "C:\Users\" & username & "\Documents\rapportini_ore_straordinarie" 'excel 2007
    
End Select
End Sub

[max_max]

Thank you so much daffobil11.
A greeting.
max_max
------------------------------------
Ti ringrazio tantissimo daffobil11.
Un saluto.
max_max

[max_max]

Hello can this change?

Sub CopiaESalvaInPathX()

   Dim username As String

   username = Foglio5.Range("A2")


Select Case  Application.OperatingSystem


    
    Case windows xp

        sPath = "C:\Documents and Settings\" & username & "\Documenti\rapportini_ore_straordinarie" 'excel 2003

    Case windows 7 / 8 / 10 

        sPath = "C:\Users\" & username & "\Documents\rapportini_ore_straordinarie" 'excel 2007
    
End Select

End Sub

max_max

[daffodil11]

Option Explicit
Private Type OSVERSIONINFO
  dwOSVersionInfoSize As Long
  dwMajorVersion As Long
  dwMinorVersion As Long
  dwBuildNumber As Long
  dwPlatformId As Long
  szCSDVersion As String * 128
End Type
Public Declare Function GetVersionExA Lib "kernel32" (lpVersionInformation As OSVERSIONINFO) As Integer
Public Function getVersion() As String
  Dim osinfo As OSVERSIONINFO
  Dim retvalue As Integer
  osinfo.dwOSVersionInfoSize = 148
  osinfo.szCSDVersion = Space$(128)
  retvalue = GetVersionExA(osinfo)
  getVersion = osinfo.dwMajorVersion & "." & osinfo.dwMinorVersion
End Function

Sub CopiaESalvaInPathX()

   Dim username As String

   username = Foglio5.Range("A2")


Select Case getVersion
    
    Case 5.1 'xp

        sPath = "C:\Documents and Settings\" & username & "\Documenti\rapportini_ore_straordinarie" 'excel 2003

    Case Else '5.2 Windows Server 2003, 6.0 Windows Vista, 6.1 Windows 7, 6.2 Windows 8, 10.0 Windows 10

        sPath = "C:\Users\" & username & "\Documents\rapportini_ore_straordinarie" 'excel 2007
    
End Select

End Sub

[max_max]

Thanks daffodil 11
I think it's entirely accurate.
I have to try the macro tomorrow morning.
A greeting and thanks.
max_max

[daffodil11]

It was an interesting challenge! Glad to have helped.

[max_max]

Not work in window xp - excel 2003
Work in Windows 7 - excel 2007
max_max

[daffodil11]

I will try harder!

[max_max]

Hello daffodil 11
After many tests I changed so:

Option Explicit

Private Type OSVERSIONINFO

    dwOSVersionInfoSize As Long
    dwMajorVersion As Long
    dwMinorVersion As Long
    dwBuildNumber As Long
    dwPlatformId As Long
    szCSDVersion As String * 128
End Type

Private Declare Function GetVersionEx Lib "kernel32" _
      Alias "GetVersionExA" (lpVersionInformation As _
      OSVERSIONINFO) As Long


Sub CopiaESalvaInPathX()

 Dim sPath As String
 Dim username As String

'-------------------------------------------
'versione windows
Dim oOSInfo As OSVERSIONINFO
oOSInfo.dwOSVersionInfoSize = Len(oOSInfo)
GetVersionEx oOSInfo
Dim Windows_version As String
                'Windows_version = oOSInfo.dwMajorVersion & "." & oOSInfo.dwMinorVersion
Windows_version = oOSInfo.dwMajorVersion
'-------------------------------------------
           
        
  username = Foglio5.Range("A2")
  
Select Case Windows_version
    
    Case 5 'xp

        sPath = "C:\Documents and Settings\" & username & "\Documenti\rapportini_ore_straordinarie" 'excel 2003

    Case Is > 5.1  'Windows Server 2003, 6.0 Windows Vista, 6.1 Windows 7, 6.2 Windows 8, 10.0 Windows 10

        sPath = "C:\Users\" & username & "\Documents\rapportini_ore_straordinarie" 'excel 2007
    
End Select   
  
 End Sub

and it is accurate or just a case of luck?
max_max

[daffodil11]

A little bit of both!

I'm no VBA expert, I just know enough to be dangerous. Looks like you got it work just fine!

[max_max]

The macros can be dangerous?

[daffodil11]

I meant I know enough to do effective, yet basic tasks. I'm still terrible at many, many things in VBA.

As a side note, VBA can be dangerous. THIS VBA macro is not dangerous. But even an antiquated programming language such as VBA can still do terrible, terrible things such as wipe computers, self-replicate, ie anything a normal computer virus does.

This is why anytime you open a *.xlsm you do not recognize, you should first open it with macros disabled and examine the code and make sure none of the code is locked or hidden. Only allow macros to run on a unknown workbook when you are sure it poses no threat.