Help to add code to save file as a specific name

[Learning ExL]

Hi all

i have put this on another forum but as yet i have not had a response. ive added a picture to demonstrate what it is that i would like to achieve.

i would like to add come code in to the following code.

Please Login or Register  to view this content.

i wish to combine the invoice number (example "12", located in cell N14) and add it to the client Id (example "oup102") so the file name will look like this "oup10212"

[Richard Buttrey]

Hi,

At the moment you're prompting for the file name with the GetSaveAsFileName instruction.

If you want to read the filename from the Excel App then comment out the GetSaveAs.... and use instead of

Filename:=Opendialog, _

this

Filename:=Sheet2.Range("J4")&Sheet2.Range("N14")

[Learning ExL]

Hi,

At the moment you're prompting for the file name with the GetSaveAsFileName instruction.

If you want to read the filename from the Excel App then comment out the GetSaveAs.... and use instead of

Filename:=Opendialog, _

this

Filename:=Sheet2.Range("J4")&Sheet2.Range("N14")

i tried that but did not work, here is the amended code if i read it right

Please Login or Register  to view this content.

[Richard Buttrey]

Delete the

Filename = Sheet2.Range("J4") & Sheet2.Range("N14")("", filefilter:="PDF Files (*.pdf), *.pdf", _
Title:="Your Invoice")

and instead include the Title:= bit further down in the Filename:= section

[Learning ExL]

Delete the

Filename = Sheet2.Range("J4") & Sheet2.Range("N14")("", filefilter:="PDF Files (*.pdf), *.pdf", _
Title:="Your Invoice")

and instead include the Title:= bit further down in the Filename:= section

all the following turns red

Please Login or Register  to view this content.

[Learning ExL]

error message

filefilter argument not found

[Learning ExL]

ok here is my code and works now

Please Login or Register  to view this content.

Many thanks for your help

[Richard Buttrey]

It will because the ...("N14")("".... bit is meaningless which is why I said to delete this wrapped round line. I didn't add but since you're not using the Opendialog variable neither do you need this whole section

Please Login or Register  to view this content.

and lower down use

Please Login or Register  to view this content.

Incidentally it's good practice to have an Option Explicit as the first line above any procedure and declare variables with a Dim statement. Without the Option Explicit variables like the 'opendialog' you were using (but not now) get declared automatically. This means that should you accidentally misspell the variable later when you give it a value, e.g suppose you wrote 'opendilog' = something or other, the misspelled opendilog is treated as a new variable and you'll be scratching your head wondering why, when later you use the correct name 'opendialog' thinking you've applied a value to it, things aren't working as you expect.