Set dim with if statements

**silkpantsman** · 10-07-2015, 05:52 AM

Hi,

I am attempting to set a declared dim inside an if statement and obviously not doing it correctly, declaring "inv1" multiple times is not the solution but the code below should show what i am trying to achieve. Any advice would be great.

Thanks,
SPM

Dim ws1 As Worksheet
Dim ws2 As Worksheet
Set ws1 = ThisWorkbook.Sheets("Sheet1")
Set ws2 = ThisWorkbook.Sheets("Sheet2")

Dim i As Integer
i = 0
    For Row = 1 To 500
        For Col = 1 To 20
                
            If ws1.Cells(Row, Col).Value = ws1.Cells(363, 3) Then
            
                If ws1.Cells(Row, 8).Value = AT Then
                    Dim inv1 As Worksheet
                    Set inv1 = ThisWorkbook.Sheets("Invoice (2)")
                ElseIf ws1.Cells(Row, 8).Value = DE Then
                    Dim inv1 As Worksheet
                    Set inv1 = ThisWorkbook.Sheets("Invoice (3)")
                ElseIf ws1.Cells(Row, 8).Value = BE Then
                    Dim inv As Worksheet
                    Set inv1 = ThisWorkbook.Sheets("Invoice (4)")
                End If
           End If
         Next
     Next

**Kyle123** · 10-07-2015, 05:55 AM

Just put the Dim at the top of the sub

**BadlySpelledBuoy** · 10-07-2015, 05:57 AM


Dim inv1 As Worksheet

Dim ws1 As Worksheet
Dim ws2 As Worksheet
Set ws1 = ThisWorkbook.Sheets("Sheet1")
Set ws2 = ThisWorkbook.Sheets("Sheet2")


Dim i As Integer
i = 0
    For Row = 1 To 500
        For Col = 1 To 20
                
            If ws1.Cells(Row, Col).Value = ws1.Cells(363, 3) Then
            
                If ws1.Cells(Row, 8).Value = AT Then
                    Set inv1 = ThisWorkbook.Sheets("Invoice (2)")
                ElseIf ws1.Cells(Row, 8).Value = DE Then
                    Set inv1 = ThisWorkbook.Sheets("Invoice (3)")
                ElseIf ws1.Cells(Row, 8).Value = BE Then
                    Set inv1 = ThisWorkbook.Sheets("Invoice (4)")
                End If
           End If
         Next
     Next

BSB

**silkpantsman** · 10-07-2015, 06:20 AM

Yeah that is what i did first time around and thought i was losing my nut when it was not working. So i am assuming the problem lies in the rest of my code. I get an application defined or object defined error.

Dim ws1 As Worksheet
Dim ws2 As Worksheet
Dim inv1 As Worksheet


Set ws1 = ThisWorkbook.Sheets("Sheet1")
Set ws2 = ThisWorkbook.Sheets("Sheet2")

Dim i As Integer

i = 0


    For Row = 1 To 500
        For Col = 1 To 20
                
            If ws1.Cells(Row, Col).Value = ws1.Cells(363, 3) Then
            
                If ws1.Cells(Row, 8).Value = AT Then
                   Set inv1 = ThisWorkbook.Sheets("Invoice (2)")
                ElseIf ws1.Cells(Row, 8).Value = DE Then
                   Set inv1 = ThisWorkbook.Sheets("Invoice (3)")
                ElseIf ws1.Cells(Row, 8).Value = BE Then
                   Set inv1 = ThisWorkbook.Sheets("Invoice (4)")
                End If
                
            
            If i = 0 Then
            
            inv1.Cells(19, 6).Value = ws1.Cells(Row, Col).Value 'PO number
            
            
            inv1.Cells(28, 1).Value = ws1.Cells(Row, 6).Value
            inv1.Cells(28, 6).Value = ws1.Cells(Row, 13).Value 
            inv1.Cells(28, 3).Value = ws1.Cells(Row, 9).Value 
            inv1.Cells(28, 4).Value = ws1.Cells(Row, 17).Value 
            inv1.Cells(28, 2).Value = ws1.Cells(Row, 7).Value 
            
            ElseIf i = 1 Then
            
            inv1.Cells(28, 8).Select
            ActiveCell.Offset(1).EntireRow.Insert Shift:=xlDown
            
            inv1.Range("H28").Select
            Selection.Copy
            inv1.Range("H29").Select
            ActiveSheet.Paste
            
            
            inv1.Cells(29, 1).Value = ws1.Cells(Row, 6).Value
            inv1.Cells(29, 6).Value = ws1.Cells(Row, 13).Value
            inv1.Cells(29, 3).Value = ws1.Cells(Row, 9).Value
            inv1.Cells(29, 4).Value = ws1.Cells(Row, 17).Value
            inv1.Cells(29, 2).Value = ws1.Cells(Row, 7).Value
            
            ElseIf i = 2 Then
            
            inv1.Cells(29, 8).Select
            ActiveCell.Offset(1).EntireRow.Insert Shift:=xlDown
            
            inv1.Range("H29").Select
            Selection.Copy
            inv1.Range("H30").Select
            ActiveSheet.Paste
            
            
            inv1.Cells(30, 1).Value = ws1.Cells(Row, 6).Value
            inv1.Cells(30, 6).Value = ws1.Cells(Row, 13).Value
            inv1.Cells(30, 3).Value = ws1.Cells(Row, 9).Value
            inv1.Cells(30, 4).Value = ws1.Cells(Row, 17).Value
            inv1.Cells(30, 2).Value = ws1.Cells(Row, 7).Value
            
            
            End If
            
            i = i + 1
            
            
            End If
            
        Next
    Next

End Sub

**Norie** · 10-07-2015, 06:25 AM

Do you have variables named AT, DE and BE etc or are you checking for the strings 'AT', 'DE' and 'BE'?

Dim ws1 As Worksheet
Dim ws2 As Worksheet
Dim inv1 As Worksheet
Dim i As Integer

Set ws1 = ThisWorkbook.Sheets("Sheet1")
Set ws2 = ThisWorkbook.Sheets("Sheet2")
Set inv1 = ThisWorkbook.Sheets("Invoice (2)")

i = 0

For Row = 1 To 500
    For Col = 1 To 20

        If ws1.Cells(Row, Col).Value = ws1.Cells(363, 3) Then

            If ws1.Cells(Row, 8).Value = "AT" Then
                Set inv1 = ThisWorkbook.Sheets("Invoice (2)")
            ElseIf ws1.Cells(Row, 8).Value = "DE" Then
                Set inv1 = ThisWorkbook.Sheets("Invoice (3)")
            ElseIf ws1.Cells(Row, 8).Value = "BE" Then
                Set inv1 = ThisWorkbook.Sheets("Invoice (4)")
            End If

            If i = 0 Then

                inv1.Cells(19, 6).Value = ws1.Cells(Row, Col).Value    'PO number


                inv1.Cells(28, 1).Value = ws1.Cells(Row, 6).Value
                inv1.Cells(28, 6).Value = ws1.Cells(Row, 13).Value
                inv1.Cells(28, 3).Value = ws1.Cells(Row, 9).Value
                inv1.Cells(28, 4).Value = ws1.Cells(Row, 17).Value
                inv1.Cells(28, 2).Value = ws1.Cells(Row, 7).Value

            ElseIf i = 1 Then

                inv1.Cells(28, 8).Offset(1).EntireRow.Insert Shift:=xlDown

                inv1.Range("H28").Copy inv1.Range("H29")

                inv1.Cells(29, 1).Value = ws1.Cells(Row, 6).Value
                inv1.Cells(29, 6).Value = ws1.Cells(Row, 13).Value
                inv1.Cells(29, 3).Value = ws1.Cells(Row, 9).Value
                inv1.Cells(29, 4).Value = ws1.Cells(Row, 17).Value
                inv1.Cells(29, 2).Value = ws1.Cells(Row, 7).Value

            ElseIf i = 2 Then

                inv1.Cells(29, 8).Offset(1).EntireRow.Insert Shift:=xlDown

                inv1.Range("H29").Copy inv1.Range("H30")

                inv1.Cells(30, 1).Value = ws1.Cells(Row, 6).Value
                inv1.Cells(30, 6).Value = ws1.Cells(Row, 13).Value
                inv1.Cells(30, 3).Value = ws1.Cells(Row, 9).Value
                inv1.Cells(30, 4).Value = ws1.Cells(Row, 17).Value
                inv1.Cells(30, 2).Value = ws1.Cells(Row, 7).Value


            End If

            i = i + 1


        End If

    Next
Next

**silkpantsman** · 10-07-2015, 06:36 AM

Your correct i should have been using "AT" etc as i am checking for a string, ty. I am still getting same error.

**Norie** · 10-07-2015, 06:38 AM

Where do you get the error?

**silkpantsman** · 10-07-2015, 07:09 AM

When i run code from VBA menu run time 1004 application defined or object defined error.

**Norie** · 10-07-2015, 10:17 AM

When I run the code in the workbook I do get an error but not the one you describe.

However if I replace the code in the workbook with the code I posted in post #5 the code runs without error.

**Kyle123** · 10-07-2015, 12:25 PM

Your post does not comply with Rule 8 of our Forum RULES. Do not crosspost your question on multiple forums without including links here to the other threads on other forums.

Cross-posting is when you post the same question in other forums on the web. The last thing you want to do is waste people's time working on an issue you have already resolved elsewhere. We prefer that you not cross-post at all, but if you do (and it's unlikely to go unnoticed), you MUST provide a link (copy the url from the address bar in your browser) to the cross-post.

Expect cross-posted questions without a link to be closed and a message will be posted by the moderator explaining why. We are here to help so help us to help you!

Read this to understand why we ask you to do this, and then please edit your first post to include links to any and all cross-posts in any other forums (not just this site).

**silkpantsman** · 10-07-2015, 12:28 PM

Originally Posted by Kyle123

Your post does not comply with Rule 8 of our Forum RULES. Do not crosspost your question on multiple forums without including links here to the other threads on other forums.

Cross-posting is when you post the same question in other forums on the web. The last thing you want to do is waste people's time working on an issue you have already resolved elsewhere. We prefer that you not cross-post at all, but if you do (and it's unlikely to go unnoticed), you MUST provide a link (copy the url from the address bar in your browser) to the cross-post.

Expect cross-posted questions without a link to be closed and a message will be posted by the moderator explaining why. We are here to help so help us to help you!

Read this to understand why we ask you to do this, and then please edit your first post to include links to any and all cross-posts in any other forums (not just this site).

Apologies, wont happen again...thanks for the help.

**Norie** · 10-08-2015, 03:34 AM

Nice.

Set dim with if statements

LinkBack

Thread Tools

Rate This Thread

Display

Hybrid View

Set dim with if statements

Re: Set dim with if statements

Re: Set dim with if statements

Re: Set dim with if statements

Re: Set dim with if statements

Re: Set dim with if statements

Re: Set dim with if statements

Re: Set dim with if statements

Re: Set dim with if statements

Re: Set dim with if statements

Re: Set dim with if statements

Re: Set dim with if statements

Thread Information

Users Browsing this Thread

Similar Threads

[SOLVED] Nested if statements containing multiple and statements

Formula with multiple IF statements and IF AND statements

Reading If statements and formulating values from if statements

questions with if statements and nested if statements

Nested If statements / logic statements

Nested IF statements or CHOOSE statements needed for multiple conditions formula

[SOLVED] operator statements, shorting when reusing one of the statements?

Bookmarks

Bookmarks

Posting Permissions