Collection inside a class, issues retrieving data

[bennett4455]

Hi guy's, im having issues extracting data from a collection inside a class modual. I have put the class into a collection and i can extract information from there, but i wanna know what ive done wrong as i cant get a reference from the class itself.
I think the issue is coming from this class modual below, when call .item(1) i dont get .sscc, i have over looked something but im not sure what for the life of me

'''''''''''''' info modual 


dim mycls as cls, mycls2 as cls2
dim rng,rng2 as range

Set mycls = New cls
Set mycls2 = New cls2


Worksheets("dump_data").Activate

 Set rng2 = Range("R2", Range("R60000").End(xlUp))
   

With mycls
                         
For Each c In rng2
.Add c.Value, .count ''''''''''''''''works added all to collection
Next
.item(.count).sscc''''''''''''''''''''' fail.....intelligence doesn't provide .sscc or anything else
.remove(.count).sscc'''''''''''''''fails aswell in the same way
end with

mycls2.Add mycls, mycls2.count + 1

mycls2.item(mycls2.count).pSSCC.item(1) ''''''''''works though ???

''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''class modual cls class

Private pId, pname as string
Public pSSCC As Collection
''''''''''''''''''''''''''''''''''''
'cls class
''''''''''''''''''''''''''''''''''''




''''''''''''''''''''''
' Id property
''''''''''''''''''''''
Public Property Get Id() As String
    Id = pId
End Property
Public Property Let Id(Value As String)
    pId = Value
End Property

''''''''''''''''''''''
' name  property
''''''''''''''''''''''
Public Property Get name() As String
    name = pname
End Property
Public Property Let name(Value As String)
    pname = Value
End Property


Private Sub Class_Initialize()
Set pSSCC = New Collection

End Sub

Public Sub Add(item As String, Key As String)
pSSCC.Add item, Key

End Sub

Public Property Get count() As Long
count = pSSCC.count

End Property

Public Property Get SSCC() As Collection
    SSCC = pSSCC

End Property

Public Property Let SSCC(Value As Collection)
    pSSCC = Value

End Property

Public Sub remove(indexorname As Variant)
pSSCC.remove indexorname

End Sub


''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''bugs out here
Public Property Get item(indexorname As Variant) As Collection
Set item = pSSCC(indexorname)

End Property

Public Function NewEnum() As IUnknown
    Set NewEnum = pSSCC.[_NewEnum]
End Function

''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''class modual cls2

Private Pcls2As Collection

Private Sub Class_Initialize()

Set Pcls2= New Collection

End Sub
Public Sub Add(item As cls, Key As String)
Pcls2.Add item, Key

End Sub
Public Property Get count() As Long
count = Pcls2.count

End Property
Public Sub remove(indexorname As Variant)
Pcls2.remove indexorname

End Sub

Public Property Get item(indexorname As Variant) As cls

Set item = Pcls2(indexorname)

End Property

Public Function NewEnum() As IUnknown
    Set NewEnum = Pcls2.[_NewEnum]
End Function

any ideas???? to point me in the right direction

[Kyle123]

Please use code tags, thems the rules. Until you do so we can't help. However as a pointer, since you're new are you returning the same thing from your item property in cls as cls2?

Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code.

Posting code between [CODE] [/CODE] tags makes your code much easier to read and copy for testing, it also maintains VBA formatting.

Highlight your code and click the # icon at the top of your post window. More information about these and other tags can be found here



(This thread should receive no further responses until this moderation request is fulfilled, as per Forum Rule 7)

[bennett4455]

sorry about that ive edited it now, yes i am looking for the same item() from both.
original cls has a collection and some other stuff, the second cls2 is just a custom collection class holding the original cls.
I have done something wrong in the original cls coz the insistence doesn't work on .item(1). but does mycls2.item(mycls2.count).pSSCC.item(1) ?? im all out of ideas and would greatly appreciate a point in the right direction


path is cls2......cls......collection.item()
i want to get to cls.collection before i add it to cls2
and it is a string input, large numbers really but integer and long cut off 0's at the end sometimes so using a string sorts this out

hope this is enough information, also running windows 8.1 and excel 2013 not that it will make much difference lol

[Kyle123]

But you aren't returning a collection here;

Public Property Get item(indexorname As Variant) As Collection
    Set item = pSSCC(indexorname)
End Property

You're returning an element from a collection, so it should really be:

Public Property Get item(indexorname As Variant) As String
    item = pSSCC(indexorname)
End Property

Since all you're really putting into the collection is a string. Does that make sense?

[bennett4455]

Hi, yes it does make sense, i have already tried this but i still had no joy?

[Kyle123]

Ok, start at the beginning. Your code doesn't make a huge amount of sense.

In non coding layman's terms, what are you actually trying to do? What's the goal of this exercise?

[bennett4455]

Ok goal is step one, input data into a cls modual,name as string, Id as string then a sscc collection, at this point I can't get .item. Step 2 is put that cls into a collection. Does that make it clearer ?

[Kyle123]

No, forget about how you want to do it, pretend classes don't exist.

Pretend I don't know any programming, what are you trying to do. Presumably you have a workbook with some data in and you're trying to put this into data structure to do what?

[bennett4455]

Ok a product has a name, Id and multiple sscc's or sometimes none associated with it. I want to be able to get hold of all the products within my code at times, also find product with no sscc associated with it before deciding if I should add it to the list of all products or not

[Kyle123]

So you want 2 things?

1. You want a list of all Products and their SSCS numbers
2. A list of selected products that you add to from the list of All Products

Is that correct?

Do you have a sample workbook with the data in?

[bennett4455]

Yes, I am currently on my phone, will send an example when I get back 2 my computer. Thanks for your patience lol

[Kyle123]

Ok mate, I'll have a look

Edit: Are you also trying to create custom collection classes or are you getting confused?

[bennett4455]

workbook is 2 big??? advice

[Kyle123]

Smaller sample workbook?

[bennett4455]

have a butchers, it should all make sense now

[bennett4455]

Any education that could point me in the right direction

[Kyle123]

How do you want to access the data? By SSCC, ID or Name?

How should the structure for 1A003 look like, it each sscc seems to have quantities rather than the ID, wouldn't you therefore use sscc as the top level collection?

[bennett4455]

I would like to access the sscc. You are right in a way, the sscc does reference a quantity, it is an item with a unique code attached so u could use it as a count, but I want to get a reference to it from the Id

[bennett4455]

Basically what i need is
MsgBox myStock.item(1).SSCC to work and
myStock.remove(1).SSCC
the rest i can sort out, cheers

[bennett4455]

I've figured out a work round but i still dont understand why .item().sscc wont work
Thanks to the guys who have had a look, much appreciated
work round is

Public Property Get SSCC(caller As Integer) As String
    SSCC = pSSCC.item(caller)
End Property

[Kyle123]

I'll post you some code tomorrow when I'm at work.

You haven't answered my question around how bothered you are about returning custom collections

[Kyle123]

Because item doesn't return an object, you don't create an object. You just add a string to a collection and try and return an object, but it's not an object, it's a string.

You haven't actually created an sscc object anywhere, if you want that then you meet to initialise that in our add method.

[bennett4455]

what a plum, penny has just dropped lol, i feel so stupid now. its the set item = lol
this is what u mean
Thanks for shaking me, im all sorted now thanks a million

Public Property Get item(index As Integer) As String

 item = pSSCC(index)

End Property

[Kyle123]

Yes, that's what I meant

[mikerickson]

My general solution is to declare Item as a Public collection
i.e.
Insead of

 Private Pcls2As Collection

Use

Public Item as Collection

[bennett4455]

Thanks a lot guys, how do I Mark this as resolved?