Collection inside a class, issues retrieving data

Please use code tags, thems the rules. Until you do so we can't help. However as a pointer, since you're new are you returning the same thing from your item property in cls as cls2?

Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code.

Posting code between [CODE]Please [url=https://www.excelforum.com/login.php]Login or Register [/url] to view this content.[/CODE] tags makes your code much easier to read and copy for testing, it also maintains VBA formatting.

Highlight your code and click the # icon at the top of your post window. More information about these and other tags can be found here



(This thread should receive no further responses until this moderation request is fulfilled, as per Forum Rule 7)

But you aren't returning a collection here;

Please Login or Register  to view this content.

You're returning an element from a collection, so it should really be:

Please Login or Register  to view this content.

Since all you're really putting into the collection is a string. Does that make sense?

Hi, yes it does make sense, i have already tried this but i still had no joy?

Ok, start at the beginning. Your code doesn't make a huge amount of sense.

In non coding layman's terms, what are you actually trying to do? What's the goal of this exercise?

Ok goal is step one, input data into a cls modual,name as string, Id as string then a sscc collection, at this point I can't get .item. Step 2 is put that cls into a collection. Does that make it clearer ?

No, forget about how you want to do it, pretend classes don't exist.

Pretend I don't know any programming, what are you trying to do. Presumably you have a workbook with some data in and you're trying to put this into data structure to do what?

Ok a product has a name, Id and multiple sscc's or sometimes none associated with it. I want to be able to get hold of all the products within my code at times, also find product with no sscc associated with it before deciding if I should add it to the list of all products or not

So you want 2 things?

1. You want a list of all Products and their SSCS numbers
2. A list of selected products that you add to from the list of All Products

Is that correct?

Do you have a sample workbook with the data in?

Yes, I am currently on my phone, will send an example when I get back 2 my computer. Thanks for your patience lol

workbook is 2 big??? advice

Smaller sample workbook?

have a butchers, it should all make sense now

Any education that could point me in the right direction

How do you want to access the data? By SSCC, ID or Name?

How should the structure for 1A003 look like, it each sscc seems to have quantities rather than the ID, wouldn't you therefore use sscc as the top level collection?

I would like to access the sscc. You are right in a way, the sscc does reference a quantity, it is an item with a unique code attached so u could use it as a count, but I want to get a reference to it from the Id

I've figured out a work round but i still dont understand why .item().sscc wont work
Thanks to the guys who have had a look, much appreciated
work round is

Please Login or Register  to view this content.

Because item doesn't return an object, you don't create an object. You just add a string to a collection and try and return an object, but it's not an object, it's a string.

You haven't actually created an sscc object anywhere, if you want that then you meet to initialise that in our add method.

I'll post you some code tomorrow when I'm at work.

You haven't answered my question around how bothered you are about returning custom collections

what a plum, penny has just dropped lol, i feel so stupid now. its the set item = lol
this is what u mean
Thanks for shaking me, im all sorted now thanks a million

Please Login or Register  to view this content.

Yes, that's what I meant

Thanks a lot guys, how do I Mark this as resolved?