Select variable data range for 2 columns

[dominicm]

Hello

Yesterday I got some help with code so that my code for inserting a graph looked for the last line of data that previous bit of code identified and not from line 3677 as the attached code currently shows. This was when the first part of the code was only selecting 1 column but now I need to graph two columns. The first part of code now correctly select the two columns.

So I recorded the macro for inserting the graph (after running the macro to select the two columns) and for that workbook it works fine and graphs correctly column E and P data just as I want. The problem is that recording the insert graph macro on that workbook puts in 3677 lines of data in the code. If I run the macro in another workbook that only has say 2000 lines of data the 3677 number is still used by the code.

what code do I need to replace the two references of 3677 in the graph code so that it always selects the last line of data that the first part of the macro code has selected?

Please Login or Register  to view this content.

thanks DOMINIC

[JasperD]

Surprising you got so many views and no reply, cause the answer is already there in your code...

the "lr = Worksheets("Sheet1").Cells(Rows.Count, "P").End(xlUp).Row" finds the last row of data in column "P" (hence lr).
So instead of making direct references to 3677, it should refer to lr.

For this to work, generally change codes where ranges are specifically mentioned as follows.
Example (before)

Please Login or Register  to view this content.

Example (after)

Please Login or Register  to view this content.

(you can actually lose the '$' as well and clear up your code)

In your code, it's changing the occurrences of "$3677" to " & lr"

Please Login or Register  to view this content.

Please click the * below if this helps