My code looks inefficient (but works)

**HappyHole** · 03-27-2015, 12:58 AM

Hi All

My code works, but looks really inefficient and I would welcome improvements.

Part 1. This looks at each column in a range and records the cell value as a variable called "Mth(X)" where X is the column number. I'm okay with this part.

Please Login or Register  to view this content.

Part 2. This part should find the starting column (StartCol), then write out the 12 variables recorded in part 1, moving across the range two columns at a time. This seems inefficient, but I couldn't figure out how to LOOP through my variables.

Please Login or Register  to view this content.

Any help provided would be appreciated.

Thanks in advance.

Happy Hole

**humdingaling** · 03-27-2015, 02:29 AM

probably something like this

Please Login or Register  to view this content.

*untested

you could probably shorten the code up even more to not have to use select but i am not sure what your code actually does and dont have the data to test

**JosephP** · 03-27-2015, 06:09 AM

maybe

Please Login or Register  to view this content.

**HappyHole** · 03-30-2015, 12:59 AM

Hello

Thanks to you both - I ended up with a solution that used a bit of each of your code and it's much shorter and efficient now. There's a lot of For/Next, Do/While and Do/Until loops in this routine and I'm quite the newbie with creating variables with loops, so it's great to get help to have this working. Makes me realise how wildly inefficient some my earlier stuff was.

Thanks again.

**zbor** · 03-30-2015, 02:23 AM

Your post does not comply with Rule 1 of our Forum RULES. Your post title should accurately and concisely describe your problem, not your anticipated solution.

Use terms appropriate to a Google search. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will be addressed according to the OP's experience in the forum: If you have less than 10 posts, expect (and respond to) a request to change your thread title. If you have 10 or more posts, expect your post to be locked, so you can start a new thread with an appropriate title.

To change a Title go to your first post, click EDIT then Go Advanced and change your title, if 2 days have passed ask a moderator to do it for you.

(This thread should receive no further responses until this moderation request is fulfilled, as per Forum Rule 7)

My code looks inefficient (but works)

LinkBack

Thread Tools

Rate This Thread

Display

My code looks inefficient (but works)

Re: My code looks inefficient (but works)

Re: My code looks inefficient (but works)

Re: My code looks inefficient (but works)

Re: My code looks inefficient (but works)

Thread Information

Users Browsing this Thread

Similar Threads

Inefficient code - macro takes too long

[SOLVED] Very inefficient code because of different sizes of arrays, how do i shorten my code?

Improve working, but inefficient code

Inefficient code

inefficient code?

Tags for this Thread

Bookmarks

Bookmarks

Posting Permissions