Cancel Inputbox not stoping Sub from excuting

[capson]

I have a Inputbox

Please Login or Register  to view this content.

when I click cancel I check for it with

Please Login or Register  to view this content.

When I click cancel the msgbox executes and says"Canceled!" but I do not Exit the sub all the code following executes

Thanks

[Richard Buttrey]

Hi,

If you've called that procedure could from another procedure then exiting the procedure will return you to the calling procedure and carry on. Use instead of Exit Sub, End.

[LJMetzger]

Hi capson,

Your question hits on one of the programming world's hot button topics. There are many ways to approach the problem. I agree that Richard's use of 'End' will work, but I disagree with it's use.

See the attached example file, and the identical code that follow here. It uses the approach that the program always continues processing to the end of the code, even if there is an error. This is accomplished by checking for errors during each step.

In your case, my approach is way over the top, but it gives an example of how to attempt to bulletproof your code. I include 'Location' numbers that can be used to help identify which section of code caused an error. All sections are optional, and you can implement as much or as little as you desire.

Please NOTE that I had to add a Boolean check of the InputBox return value, to differentiate Input of 0 (ZERO), from input of Cancel.

I hope this helps.

Please Login or Register  to view this content.

Lewis

[romperstomper]

@Lewis

If you really want to report the location of the error, it's easier to use line numbers and Erl.

[LJMetzger]

Rory,

Thanks for the tip. I must admit I didn't know that Erl() existed. After a little bit of research I don't care for it, especially since it needs Line Numbers. Line Numbers can be added manually, or can be added/removed using an external freeware tool like MZTools 3.0 http://www.mztools.com/index.aspx

I use and love MZTools, but I have hated line numbers since the late 1960s and my initial exposure to FORTRAN.

For anyone who is interested, here are a couple of examples using Erl() to identify a divide by zero error:

Please Login or Register  to view this content.

Lewis

[romperstomper]

Lewis,

I don't use it either but it seemed a lot simpler than using your variable.

[capson]

Thank you all for the help.

Lewis, I down loaded the file and will sudy it, thank you.