I need help with cleaning up some ugly Macro Code.

[Fhorst]

Hi All,

I made some ugly macro code.
It functions, but I do know it's not the "standard" way to get my trick done.

Here's some of the code:

Please Login or Register  to view this content.

I only need the value from Userform3 to be placed into the fields.
As I don't know how else to achieve this, I made a range, and that works.
But I'm sure it must be possible to point it to a cell.
To make it simple, the code I used : "Set lastrowD = ws.Range("D13:D14").Find" makes a range from D13 to D14, but as it add's 1, it's always D14.
And D14 is also the field that requires the value of that (name) field of the Userform3.

It's ugly. But it works ! And I'm happy about that

Next code that needs to be simplified:

Please Login or Register  to view this content.

I need a nice PrintOut, and I need 2 copies.
Tons of information on the WWW about printing, but how to make a simple duplicate copy? I really did search (for over 2 hours, then i gave up).
This code of mine works, it does the trick, but I'm sure there is a better way!

That's all for today

All the help is appreciated!

[shg]

As you would find in Help,

Please Login or Register  to view this content.

[Fhorst]

Thanks!

I did not look in the "Help"
Google usually gives better help then the build-in help, but in this case....

[jayesh25]

Fhorst. I'm assuming you're looking at pasting data on to Empty cells in Excel sheet? Sorry if that isn't the case the post isn't very clear.

However if that is the case you could use a more clearer method. Use the below code.

Please Login or Register  to view this content.

The method could've been shorter if your controls were named similar with numeric order..

[Fhorst]

Hi Jayesh,

I'm sorry that I can't be more clear.
I'll try to make it more specific:

Klant1.Value : needs to enter in field D13 on the sheet "Factuur"
Adres1.Value : needs to enter in field D14 on the sheet "Factuur"
Plaats1.Value : needs to enter in field D15 on the sheet "Factuur"
Postcode1.Value : needs to enter in field G15 on the sheet "Factuur"
Telefoon1.Value : needs to enter in field D16 on the sheet "Factuur"
Email1.Value : needs to enter in field G16 on the sheet "Factuur"
Werkbon_nr1.Value : needs to enter in field N14 on the sheet "Factuur"
Kenteken1.Value : needs to enter in field N15 on the sheet "Factuur"
km_stand1.Value : needs to enter in field N16 on the sheet "Factuur"

Thanks!

[jayesh25]

Well If it's a fixed cell you'd like your values to be pasted on then you could directly refer them to a cell range as below.

Please Login or Register  to view this content.

[shg]

Or ...

Please Login or Register  to view this content.

[Fhorst]

Thank you both! SHG and Jayesh25

The code is much better this way!

For me, the code from SHG looks like one I can follow, and edit if needed. (not that the one from Jayesh25 is not good, but one has to chose...)

Now I still have this issue :copy values and cross check

This post can be closed. (I think I can do that right?)

[shg]

You're welcome.